wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-28 00:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Cite/tests/parser/bookReferencing.txt

857 lines
37 KiB
Plaintext
Raw Normal View History

Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
Book Referencing attribute rejected by default
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=false
!! wikitext
<ref name="parent">[foo]</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="parent">[bar]</ref>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
<p><sup id="cite_ref-parent_1-0" class="reference"><a href="#cite_note-parent-1">&#91;1&#93;</a></sup>
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
</p>
invalid names, e.g. too many</span><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-parent-1"><span class="mw-cite-backlink"><a href="#cite_ref-parent_1-0">↑</a></span> <span class="reference-text">[foo]</span>
</li>
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
Book Referencing attribute allowed with feature flag set
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="parent">[foo]</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="parent">[bar]</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! html/php
<p><sup id="cite_ref-parent_1-0" class="reference"><a href="#cite_note-parent-1">&#91;1&#93;</a></sup>
</p>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<li id="cite_note-parent-1"><span class="mw-cite-backlink"><a href="#cite_ref-parent_1-0">↑</a></span> <span class="reference-text">[foo]</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">[bar]</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Extending the same base multiple times is fine
Stop formatting "1.2" as "1,2" in languages like German The new extends="…" feature is using numbers like "1.2". These should be localized in languages like Hebrew that uses other symbols for the digits. But the "." should not change. The existing feature when a <ref> is reused multiple times does have the same "issue". But it seems this is intentional, because it is covered by a test. Note this is not visible in German, because German uses custom labels "a", "b", and so on. This patch also improves the so called "smoke" tests and makes one cover numbers up to "1,10" for a <ref> that is reused that often. Bug: T239725 Change-Id: Iffcb56e1c7be09cefed9dabb1d6391eb6ad995ce
2019-12-04 08:10:03 +00:00
!! options
language=de
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page 2</ref>
<ref extends="a">page 3</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-3" class="reference"><a href="#cite_note-3">&#91;1.2&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page 2</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
<li id="cite_note-3"><span class="mw-cite-backlink"><a href="#cite_ref-3">↑</a></span> <span class="reference-text">page 3</span>
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! test
Extended references can be reused
!! options
language=de
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
<ref extends="a" name="b">page 2</ref>
<ref name="b" />
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
</p>
<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b_2-0">1.1,0</a></sup> <sup><a href="#cite_ref-b_2-1">1.1,1</a></sup></span> <span class="reference-text">page 2</span>
</li>
</ol></li>
</ol></div>
!! end
Add parser tests for reused extended <ref> before defined Bug: T240424 Change-Id: I945c2e12cfa3ff851380a1ff4491c8af076f523a
2019-12-11 15:30:17 +00:00
# TODO: The number for the first <ref> must be "1.1", not just "1"
!! test
T240424 - Extended reference reused before defined in the text
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="b" />
<ref name="b" extends="a">page 2</ref>
<ref name="a">book</ref>
!! html
<p><sup id="cite_ref-b_1-0" class="reference"><a href="#cite_note-b-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-b_1-1" class="reference"><a href="#cite_note-b-1">&#91;1.1&#93;</a></sup>
</p>
<sup id="cite_ref-a_2-0" class="reference"><a href="#cite_note-a-2">&#91;1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-2"><span class="mw-cite-backlink"><a href="#cite_ref-a_2-0">↑</a></span> <span class="reference-text">book</span>
<ol class="mw-extended-references"><li id="cite_note-b-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b_1-0">1.1.0</a></sup> <sup><a href="#cite_ref-b_1-1">1.1.1</a></sup></span> <span class="reference-text">page 2</span>
</li>
</ol></li>
</ol></div>
!! end
# TODO: This currently renders as if the extends="…" is not there
# TODO: Render a helpful error message to make this issue visible
# TODO: Find a way to render this properly
!! test
T240424 - Extended reference reused before defined in the <references> section
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a" />
<ref name="b" />
<references>
<ref name="b" extends="a">page 2</ref>
<ref name="a">book</ref>
</references>
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;2&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
<li id="cite_note-b-2"><span class="mw-cite-backlink"><a href="#cite_ref-b_2-0">↑</a></span> <span class="reference-text">page 2</span>
</li>
</ol></div>
!! end
Add parser test for duplicate extended references Bug: T240459 Change-Id: Ifc7a695e89a49ccc6c66d49efe41b2321b0915f0
2019-12-11 14:58:34 +00:00
# TODO: The two identical tags should be merged into one
!! test
T240459 - References should be merged when they have the exact same content
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
<ref extends="a">page 2</ref>
<ref extends="a">page 2</ref>
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
</p>
<sup id="cite_ref-3" class="reference"><a href="#cite_note-3">&#91;1.2&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page 2</span>
</li>
<li id="cite_note-3"><span class="mw-cite-backlink"><a href="#cite_ref-3">↑</a></span> <span class="reference-text">page 2</span>
</li>
</ol></li>
</ol></div>
!! end
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Naming book references is fine
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a" name="b">page 2</ref>
<ref extends="a" name="c">page 3</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<ref name="b" />
<ref name="c" />
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-c_3-0" class="reference"><a href="#cite_note-c-3">&#91;1.2&#93;</a></sup>
<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-c_3-1" class="reference"><a href="#cite_note-c-3">&#91;1.2&#93;</a></sup>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b_2-0">1.1.0</a></sup> <sup><a href="#cite_ref-b_2-1">1.1.1</a></sup></span> <span class="reference-text">page 2</span>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<li id="cite_note-c-3"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-c_3-0">1.2.0</a></sup> <sup><a href="#cite_ref-c_3-1">1.2.1</a></sup></span> <span class="reference-text">page 3</span>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Extending a reference that doesn't exist #1
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page 1</ref>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">&#91;1.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">page 1</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Extending a reference that doesn't exist #2
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref>book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page 1</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! html/php
<p><sup id="cite_ref-1" class="reference"><a href="#cite_note-1">&#91;1&#93;</a></sup>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</p>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;2.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">book</span>
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page 1</span>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
</ol></li>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</ol></div>
!! end
!! test
T236256 - Reference with the same name defined twice
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
<ref name="a">magazine</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page 1</ref>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-a_1-1" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
</p>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
<li id="cite_note-a-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-a_1-0">1.0</a></sup> <sup><a href="#cite_ref-a_1-1">1.1</a></sup></span> <span class="reference-text">book <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag; name "a" defined multiple times with different content</span></span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page 1</span>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</ol></div>
!! end
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Can't reuse a name for two book references
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a" name="b">page 2</ref>
<ref extends="a" name="b">page 3</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
Fix bad numbering when reusing sub-references Note this leaves *another* bug behind. When a <ref> is properly reused by name="…", and the content is fine (either missing or identical), possibly conflicting extends="…" attributes are currently entirely ignored. However, this is already much better than what happened before. Bug: T242110 Change-Id: Id808ce31c8036cc290f68bb3e8c5a7b12f4f44cf
2020-01-07 14:52:59 +00:00
<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Fix bad numbering when reusing sub-references Note this leaves *another* bug behind. When a <ref> is properly reused by name="…", and the content is fine (either missing or identical), possibly conflicting extends="…" attributes are currently entirely ignored. However, this is already much better than what happened before. Bug: T242110 Change-Id: Id808ce31c8036cc290f68bb3e8c5a7b12f4f44cf
2020-01-07 14:52:59 +00:00
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b_2-0">1.1.0</a></sup> <sup><a href="#cite_ref-b_2-1">1.1.1</a></sup></span> <span class="reference-text">page 2 <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag; name "b" defined multiple times with different content</span></span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
Fail early on nested extends="…", if possible This partly reverts Ied2e3f5. I haven't properly tested this before. Rendering a bad extends (that extends a <ref> that's already extended) not indented messes the order up and rips other extended <ref>s out of context. For now it might be better to stick to the previous, "magic" behavior: Such an extends behaves like it is extending the *parent*, and is ordered and indented as such. This is still not correct, but I feel this is much better than rendering such a bad extends on the top level. This patch also makes the code fail much earlier for a nested extends, if this decision can be made already. In this case the error message is rendered in the middle of the text (as other errors also are), not in the <references> section. Change-Id: I33c6a763cd6c11df09d10dfab73f955ed15e9d36
2019-12-09 08:37:38 +00:00
T236256 - Can't extend a book reference (no nesting)
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a" name="b">page 2</ref>
<ref extends="b">section 3</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
Fail early on nested extends="…", if possible This partly reverts Ied2e3f5. I haven't properly tested this before. Rendering a bad extends (that extends a <ref> that's already extended) not indented messes the order up and rips other extended <ref>s out of context. For now it might be better to stick to the previous, "magic" behavior: Such an extends behaves like it is extending the *parent*, and is ordered and indented as such. This is still not correct, but I feel this is much better than rendering such a bad extends on the top level. This patch also makes the code fail much earlier for a nested extends, if this decision can be made already. In this case the error message is rendered in the middle of the text (as other errors also are), not in the <references> section. Change-Id: I33c6a763cd6c11df09d10dfab73f955ed15e9d36
2019-12-09 08:37:38 +00:00
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
invalid names, e.g. too many</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink"><a href="#cite_ref-b_2-0">↑</a></span> <span class="reference-text">page 2</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Don't indent refs with forbidden extends="…" Change-Id: Ied2e3f56ce66d2a8ccf60df2bdbf99acad461595
2019-12-04 12:54:34 +00:00
</ol></li>
Fail early on nested extends="…", if possible This partly reverts Ied2e3f5. I haven't properly tested this before. Rendering a bad extends (that extends a <ref> that's already extended) not indented messes the order up and rips other extended <ref>s out of context. For now it might be better to stick to the previous, "magic" behavior: Such an extends behaves like it is extending the *parent*, and is ordered and indented as such. This is still not correct, but I feel this is much better than rendering such a bad extends on the top level. This patch also makes the code fail much earlier for a nested extends, if this decision can be made already. In this case the error message is rendered in the middle of the text (as other errors also are), not in the <references> section. Change-Id: I33c6a763cd6c11df09d10dfab73f955ed15e9d36
2019-12-09 08:37:38 +00:00
</ol></div>
!! end
!! test
T236256 - Can't extend a book reference (no nesting), specified in reverse order
!! config
wgCiteBookReferencing=true
!! wikitext
<ref extends="b">section 3</ref>
<ref extends="a" name="b">page 2</ref>
<ref name="a">book</ref>
<references />
!! html/php
<p><sup id="cite_ref-1" class="reference"><a href="#cite_note-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-a_3-0" class="reference"><a href="#cite_note-a-3">&#91;1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-3"><span class="mw-cite-backlink"><a href="#cite_ref-a_3-0">↑</a></span> <span class="reference-text">book</span>
<ol class="mw-extended-references"><li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">section 3 <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
Show error when extending a subreference Change-Id: Iaa47e302e5e49dfc190fde37567a3e7a2e743d67
2019-12-04 10:59:56 +00:00
invalid names, e.g. too many</span></span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Fail early on nested extends="…", if possible This partly reverts Ied2e3f5. I haven't properly tested this before. Rendering a bad extends (that extends a <ref> that's already extended) not indented messes the order up and rips other extended <ref>s out of context. For now it might be better to stick to the previous, "magic" behavior: Such an extends behaves like it is extending the *parent*, and is ordered and indented as such. This is still not correct, but I feel this is much better than rendering such a bad extends on the top level. This patch also makes the code fail much earlier for a nested extends, if this decision can be made already. In this case the error message is rendered in the middle of the text (as other errors also are), not in the <references> section. Change-Id: I33c6a763cd6c11df09d10dfab73f955ed15e9d36
2019-12-09 08:37:38 +00:00
<li id="cite_note-b-2"><span class="mw-cite-backlink"><a href="#cite_ref-b_2-0">↑</a></span> <span class="reference-text">page 2</span>
</li>
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
T236256 - Named reference without text
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a" />
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page 1</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
</p>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup><div class="mw-references-wrap"><ol class="references">
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page 1</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - No text for a book reference
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="foo">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="foo" />
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
<p><sup id="cite_ref-foo_1-0" class="reference"><a href="#cite_note-foo-1">&#91;1&#93;</a></sup>
</p>
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: The opening <code>&lt;ref&gt;</code> tag is malformed or has a bad name</span><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-foo-1"><span class="mw-cite-backlink"><a href="#cite_ref-foo_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Empty text for a book reference
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="foo">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="foo"></ref>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
<p><sup id="cite_ref-foo_1-0" class="reference"><a href="#cite_note-foo-1">&#91;1&#93;</a></sup>
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
</p>
refs with no name must have content</span><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-foo-1"><span class="mw-cite-backlink"><a href="#cite_ref-foo_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - De-facto empty text for a book reference
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="foo">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="foo"> </ref>
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
!! html/php
<p><sup id="cite_ref-foo_1-0" class="reference"><a href="#cite_note-foo-1">&#91;1&#93;</a></sup>
Block de-facto empty <ref> as if it's empty The use case we care about is this: <ref extends="some_book"> </ref> It doesn't make sense that works, but the following doesn't: <ref extends="some_book"></ref> We decided that both need to behave the same. For consistency this patch is applying the same change to all references, no matter if they use the extends attribute or not. This is an actual change and might make existing wikitext render differently. However, I would like to argue that all wikitext that was using this was broken. The effect of a <ref> </ref> with some whitespace is that the <references> section at the end of the article will contain – well – an empty footnote. Bug: T237241 Change-Id: Iaee35583eabcb416b0a06849b89ebbfb0fb7fef9
2019-11-20 14:44:12 +00:00
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
</p>
Block de-facto empty <ref> as if it's empty The use case we care about is this: <ref extends="some_book"> </ref> It doesn't make sense that works, but the following doesn't: <ref extends="some_book"></ref> We decided that both need to behave the same. For consistency this patch is applying the same change to all references, no matter if they use the extends attribute or not. This is an actual change and might make existing wikitext render differently. However, I would like to argue that all wikitext that was using this was broken. The effect of a <ref> </ref> with some whitespace is that the <references> section at the end of the article will contain – well – an empty footnote. Bug: T237241 Change-Id: Iaee35583eabcb416b0a06849b89ebbfb0fb7fef9
2019-11-20 14:44:12 +00:00
refs with no name must have content</span><div class="mw-references-wrap"><ol class="references">
Split out BookReferencing parser tests Encapsulate the feature tests in dedicated files. These are picked up by the test runner for matching glob `tests/parser/*.txt`, as can be shown by, phpunit.php --testsuite parsertests --filter=bookRef Also adds TODO comments to some tests, documenting how the current output will not match the fully implemented code's results. Bug: T236256 Change-Id: Ie3e769c84856256180754aeff417da893a84b479
2019-11-08 09:02:38 +00:00
<li id="cite_note-foo-1"><span class="mw-cite-backlink"><a href="#cite_ref-foo_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div>
!! end
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! test
T236256 - Everything in the same group
!! config
wgCiteBookReferencing=true
!! wikitext
<ref group="g1" name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref group="g1" extends="a" name="b">page</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<ref group="g1" name="b" />
<references group="g1"/>
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;g1 1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;g1 1.1&#93;</a></sup>
<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;g1 1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b_2-0">1.1.0</a></sup> <sup><a href="#cite_ref-b_2-1">1.1.1</a></sup></span> <span class="reference-text">page</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Base and book reference in different groups
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref group="g1" name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref group="g2" extends="a">page</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references group="g1"/>
<references group="g2"/>
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;g1 1&#93;</a></sup>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;g2 1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div>
<div class="mw-references-wrap"><ol class="references">
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Extending in the unnamed default group
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref group="g1" name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">page</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references group="g1"/>
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;g1 1&#93;</a></sup>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div><div class="mw-references-wrap"><ol class="references">
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
T236256 - Base in the unnamed default group
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref group="g1" extends="a">page</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references group="g1"/>
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;g1 1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
no text was provided for refs named <code>a</code></span><ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div><div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
</li>
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Extending a multi-part ref should be fine
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">part 1</ref>
<ref follow="a">part 2</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a">ok</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</p><p><sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">part 1 part 2</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">ok</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
# TODO:
# * Should render an error at the third reference.
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Dont allow splitting a book reference for now
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref extends="a" name="b">page 2</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<ref follow="b">and page 3 the same time?</ref>
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<ol class="mw-extended-references"><li id="cite_note-b-2"><span class="mw-cite-backlink"><a href="#cite_ref-b_2-0">↑</a></span> <span class="reference-text">page 2 and page 3 the same time?</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></li>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</ol></div>
!! end
!! test
[Refactor] Pass validation error with StatusValue This has clearer semantics than checking for a `false` attribute. Change-Id: I68f777eda40f8f157deafacaed02d4bd10cbf25c
2019-11-26 11:05:51 +00:00
T236256 - Can't be a follow up and a book reference the same time
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book 1</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref follow="a" extends="a">huh?</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
Block all combinations of refines="…" and follows="…" Note it doesn't make a difference if this is behind the feature flag or not. It should always be forbidden, and in fact is: Either the follows attribute is unknown, or the combination is forbidden. Bug: T236256 Change-Id: Iebbb2d1d5bab183ab0590b8a7a7f6e79d319b72c
2019-11-05 15:02:12 +00:00
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
invalid names, e.g. too many</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
Block all combinations of refines="…" and follows="…" Note it doesn't make a difference if this is behind the feature flag or not. It should always be forbidden, and in fact is: Either the follows attribute is unknown, or the combination is forbidden. Bug: T236256 Change-Id: Iebbb2d1d5bab183ab0590b8a7a7f6e79d319b72c
2019-11-05 15:02:12 +00:00
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book 1</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
</ol></div>
!! end
!! test
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
T236256 - Can't be a follow up and a book reference the same time, even when referencing 2 different bases
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book 1</ref>
<ref name="b">book 2</ref>
Rename refines -> extends Bug: T171581 Change-Id: I42b2d8859f2958357024cbba089715c10712f370
2019-11-12 10:03:44 +00:00
<ref follow="a" extends="b">huh?</ref>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;2&#93;</a></sup>
Block all combinations of refines="…" and follows="…" Note it doesn't make a difference if this is behind the feature flag or not. It should always be forbidden, and in fact is: Either the follows attribute is unknown, or the combination is forbidden. Bug: T236256 Change-Id: Iebbb2d1d5bab183ab0590b8a7a7f6e79d319b72c
2019-11-05 15:02:12 +00:00
<span class="error mw-ext-cite-error" lang="en" dir="ltr">Cite error: Invalid <code>&lt;ref&gt;</code> tag;
invalid names, e.g. too many</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
Block all combinations of refines="…" and follows="…" Note it doesn't make a difference if this is behind the feature flag or not. It should always be forbidden, and in fact is: Either the follows attribute is unknown, or the combination is forbidden. Bug: T236256 Change-Id: Iebbb2d1d5bab183ab0590b8a7a7f6e79d319b72c
2019-11-05 15:02:12 +00:00
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book 1</span>
Merge bookReferencingUnimplemented.txt into bookReferencing.txt What we find critical is: * That all tests relevant for book referencing are in a separate file. * That unimplemented stuff is marked with TODOs. Not having to move tests to another file allows for nice diffs. I tried to order the tests as good as I could. E.g. have all tests with a group="…" next to each other, followed by all with a follow="…". Change-Id: Idc1d9e7843b341235ab3d8ebe398e01946eb1845
2019-11-11 11:50:51 +00:00
</li>
<li id="cite_note-b-2"><span class="mw-cite-backlink"><a href="#cite_ref-b_2-0">↑</a></span> <span class="reference-text">book 2</span>
</li>
</ol></div>
!! end
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
# TODO
# * This should be invalid, there's no way to know that `footwo` should be subnumbered in a one-pass parse.
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
!! test
Extends <ref> defined in <references> called with #tag
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
!! wikitext
<ref name="foo">BAR</ref>
<ref name="footwo" />
{{#tag:references|
<ref name="footwo" extends="foo">p. 10</ref>
}}
!! html
<p><sup id="cite_ref-foo_1-0" class="reference"><a href="#cite_note-foo-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-footwo_2-0" class="reference"><a href="#cite_note-footwo-2">&#91;2&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-foo-1"><span class="mw-cite-backlink"><a href="#cite_ref-foo_1-0">↑</a></span> <span class="reference-text">BAR</span>
Split ref.number field This was carrying the entire footnote marker, but subreferences need to extract just the first (group ref sequence) part. Storing number and extendsIndex in two separate fields gives us more flexibility during rendering, for example these might use two different symbol sets. Change-Id: I75bd6644c336036f9e84ba91e1c35e05bc1ca7f3
2019-11-29 23:10:11 +00:00
<ol class="mw-extended-references"><li id="cite_note-footwo-2"><span class="mw-cite-backlink"><a href="#cite_ref-footwo_2-0">↑</a></span> <span class="reference-text">p. 10</span>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</li>
Split ref.number field This was carrying the entire footnote marker, but subreferences need to extract just the first (group ref sequence) part. Storing number and extendsIndex in two separate fields gives us more flexibility during rendering, for example these might use two different symbol sets. Change-Id: I75bd6644c336036f9e84ba91e1c35e05bc1ca7f3
2019-11-29 23:10:11 +00:00
</ol></li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></div>
!! end
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
!! test
Extends parent <ref> defined in <references> called with #tag
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
!! wikitext
<ref>BAR</ref>
<ref name="footwo" extends="foo">page 7</ref>
<ref name="foo" />
{{#tag:references|
<ref name="foo">book name</ref>
}}
!! html
<p><sup id="cite_ref-1" class="reference"><a href="#cite_note-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-footwo_2-0" class="reference"><a href="#cite_note-footwo-2">&#91;2.1&#93;</a></sup>
<sup id="cite_ref-foo_3-0" class="reference"><a href="#cite_note-foo-3">&#91;2&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">BAR</span>
</li>
<li id="cite_note-foo-3"><span class="mw-cite-backlink"><a href="#cite_ref-foo_3-0">↑</a></span> <span class="reference-text">book name</span>
<ol class="mw-extended-references"><li id="cite_note-footwo-2"><span class="mw-cite-backlink"><a href="#cite_ref-footwo_2-0">↑</a></span> <span class="reference-text">page 7</span>
</li>
</ol></li>
</ol></div>
!! end
!! test
Interleaved extends groups
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
!! wikitext
<ref name="a">text-a</ref>
<ref name="c">text-c</ref>
<ref extends="a">page b</ref>
<ref extends="c">page d</ref>
<references />
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-c_2-0" class="reference"><a href="#cite_note-c-2">&#91;2&#93;</a></sup>
</p><p><sup id="cite_ref-3" class="reference"><a href="#cite_note-3">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-4" class="reference"><a href="#cite_note-4">&#91;2.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">text-a</span>
<ol class="mw-extended-references"><li id="cite_note-3"><span class="mw-cite-backlink"><a href="#cite_ref-3">↑</a></span> <span class="reference-text">page b</span>
</li>
</ol></li>
<li id="cite_note-c-2"><span class="mw-cite-backlink"><a href="#cite_ref-c_2-0">↑</a></span> <span class="reference-text">text-c</span>
<ol class="mw-extended-references"><li id="cite_note-4"><span class="mw-cite-backlink"><a href="#cite_ref-4">↑</a></span> <span class="reference-text">page d</span>
</li>
</ol></li>
</ol></div>
!! end
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
!! test
Multiple groups with extends
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
!! wikitext
<ref name="a">text-a</ref>
<ref extends="a">page b</ref>
<references />
<ref name="c">text-c</ref>
<ref extends="c">page d</ref>
<references />
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">text-a</span>
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page b</span>
</li>
</ol></li>
</ol></div>
<p><sup id="cite_ref-c_3-0" class="reference"><a href="#cite_note-c-3">&#91;1&#93;</a></sup>
<sup id="cite_ref-4" class="reference"><a href="#cite_note-4">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-c-3"><span class="mw-cite-backlink"><a href="#cite_ref-c_3-0">↑</a></span> <span class="reference-text">text-c</span>
<ol class="mw-extended-references"><li id="cite_note-4"><span class="mw-cite-backlink"><a href="#cite_ref-4">↑</a></span> <span class="reference-text">page d</span>
</li>
</ol></li>
</ol></div>
!! end
Reset extendsCount after each group This was a bug which would affect book references, if the same group and parent ref name combination occur twice in an article. Change-Id: I608f58aac0cec31c8650835fc80195a87bc851d3
2019-11-29 22:24:51 +00:00
!! test
Multiple groups with extends, duplicated names across groups
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Reset extendsCount after each group This was a bug which would affect book references, if the same group and parent ref name combination occur twice in an article. Change-Id: I608f58aac0cec31c8650835fc80195a87bc851d3
2019-11-29 22:24:51 +00:00
!! wikitext
<ref name="a">text-a</ref>
<ref extends="a">page b</ref>
<references />
<ref name="a">text-c</ref>
<ref extends="a">page d</ref>
<references />
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">text-a</span>
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page b</span>
</li>
</ol></li>
</ol></div>
<p><sup id="cite_ref-a_3-0" class="reference"><a href="#cite_note-a-3">&#91;1&#93;</a></sup>
<sup id="cite_ref-4" class="reference"><a href="#cite_note-4">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-3"><span class="mw-cite-backlink"><a href="#cite_ref-a_3-0">↑</a></span> <span class="reference-text">text-c</span>
<ol class="mw-extended-references"><li id="cite_note-4"><span class="mw-cite-backlink"><a href="#cite_ref-4">↑</a></span> <span class="reference-text">page d</span>
</li>
</ol></li>
</ol></div>
!! end
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
!! test
Intervening ref before extends
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a">book</ref>
<ref>another</ref>
<ref extends="a">page 2</ref>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
<references />
!! html/php
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;2&#93;</a></sup>
Split ref.number field This was carrying the entire footnote marker, but subreferences need to extract just the first (group ref sequence) part. Storing number and extendsIndex in two separate fields gives us more flexibility during rendering, for example these might use two different symbol sets. Change-Id: I75bd6644c336036f9e84ba91e1c35e05bc1ca7f3
2019-11-29 23:10:11 +00:00
<sup id="cite_ref-3" class="reference"><a href="#cite_note-3">&#91;1.1&#93;</a></sup>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">book</span>
<ol class="mw-extended-references"><li id="cite_note-3"><span class="mw-cite-backlink"><a href="#cite_ref-3">↑</a></span> <span class="reference-text">page 2</span>
</li>
</ol></li>
Can use `extends` before its parent If `extends` is encountered before the parent ref, we reserve the sequence number and leave a placeholder to record the link between ref name and number. This is necessary to render a list like, "[1] [2.1] [2]", or to use subreferencing when the parent ref is declared in the references tag. When a placeholder is encountered during references section rendering, it means that the parent was never declared. Change-Id: I611cd1d73f775908926a803fae90d039ce122ab6
2019-11-29 11:50:07 +00:00
<li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">another</span>
</li>
Render nested references Forked from Icd933fc983. Bugs and unimplemented features are documented as TODOs in the parser test fixtures. Bug: T237241 Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-18 14:49:51 +00:00
</ol></div>
!! end
Numbering bug: Parser test which should fail Includes the TODO for what correct output looks like. Bug: T237241 Change-Id: I0e60724f2c418b19e5affc24dca7f446c2b38bb3
2019-12-09 08:52:33 +00:00
!! test
Normal refs after extends
Fix bad localization of extended references numbers when reused This adds a test for numbers like "1.2.0" that appear when an extended reference (e.g. "1.2.") is reused multiple times. The first separator is from the extended reference. We decided to never localize it. However, the second seperator is from reusing a reference. This was always localized. We believe this is a bug, but haven't fixed it yet. The test is documenting the status quo "1.2,0" with a comma. This kind of makes sense, one could argue, because the "1.2" appears like this up in the text, but the ",0" is a different indicator for a reuse, which *never* occurs in the text. Change-Id: Ie3d26bcadd8929b906bfbcac4806af2150d61f2a
2019-12-09 15:01:13 +00:00
!! config
wgCiteBookReferencing=true
Numbering bug: Parser test which should fail Includes the TODO for what correct output looks like. Bug: T237241 Change-Id: I0e60724f2c418b19e5affc24dca7f446c2b38bb3
2019-12-09 08:52:33 +00:00
!! wikitext
<ref name="a">text-a</ref>
<ref extends="a">page b</ref>
<ref name="c">text-c</ref>
<references />
!! html
<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>
<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">&#91;1.1&#93;</a></sup>
Fix footnote mark after extends numbering glitch The visible numbering needed to be rolled back after an extends. Bug: T237241 Change-Id: I95404515110df1fa7e3279ea499577df0ed45ddf
2019-12-09 09:19:55 +00:00
</p><p><sup id="cite_ref-c_3-0" class="reference"><a href="#cite_note-c-3">&#91;2&#93;</a></sup>
Numbering bug: Parser test which should fail Includes the TODO for what correct output looks like. Bug: T237241 Change-Id: I0e60724f2c418b19e5affc24dca7f446c2b38bb3
2019-12-09 08:52:33 +00:00
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-1"><span class="mw-cite-backlink"><a href="#cite_ref-a_1-0">↑</a></span> <span class="reference-text">text-a</span>
<ol class="mw-extended-references"><li id="cite_note-2"><span class="mw-cite-backlink"><a href="#cite_ref-2">↑</a></span> <span class="reference-text">page b</span>
</li>
</ol></li>
<li id="cite_note-c-3"><span class="mw-cite-backlink"><a href="#cite_ref-c_3-0">↑</a></span> <span class="reference-text">text-c</span>
</li>
</ol></div>
!! end
Fix bad numbering when reusing sub-references Note this leaves *another* bug behind. When a <ref> is properly reused by name="…", and the content is fine (either missing or identical), possibly conflicting extends="…" attributes are currently entirely ignored. However, this is already much better than what happened before. Bug: T242110 Change-Id: Id808ce31c8036cc290f68bb3e8c5a7b12f4f44cf
2020-01-07 14:52:59 +00:00
!! test
T242110: Copy-pasted, named sub-references should be merged and not mess with the numbering
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a1" extends="a">a1</ref>
<ref name="a1" extends="a">a1</ref>
<references>
<ref name="a">a</ref>
</references>
!! html
<p><sup id="cite_ref-a1_1-0" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-a1_1-1" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-a1-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-a1_1-0">1.1.0</a></sup> <sup><a href="#cite_ref-a1_1-1">1.1.1</a></sup></span> <span class="reference-text">a1</span>
</li>
</ol></li>
</ol></div>
!! end
!! test
T242110: Reused sub-references should be merged and not mess with the numbering
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a1" extends="a">a1</ref>
<ref name="a1" extends="a" />
<references>
<ref name="a">a</ref>
</references>
!! html
<p><sup id="cite_ref-a1_1-0" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-a1_1-1" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-a1-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-a1_1-0">1.1.0</a></sup> <sup><a href="#cite_ref-a1_1-1">1.1.1</a></sup></span> <span class="reference-text">a1</span>
</li>
</ol></li>
</ol></div>
!! end
# TODO: Currently, the extends attribute is ignored in this situation.
!! test
T242110: Bad extends attributes on reused sub-references should report an error
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a1" extends="a">a1</ref>
<ref name="a1" extends="unknown" />
<references>
<ref name="a">a</ref>
</references>
!! html
<p><sup id="cite_ref-a1_1-0" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-a1_1-1" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-a1-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-a1_1-0">1.1.0</a></sup> <sup><a href="#cite_ref-a1_1-1">1.1.1</a></sup></span> <span class="reference-text">a1</span>
</li>
</ol></li>
</ol></div>
!! end
!! test
T242110: Copy-pasted, named sub-references should appear in proper order
!! config
wgCiteBookReferencing=true
!! wikitext
<ref name="a1" extends="a">a1</ref>
<ref name="a1" extends="a">a1</ref>
<ref name="b1" extends="b">b1</ref>
<ref name="b1" extends="b" />
<ref name="c1" extends="c">c1</ref>
<ref name="c1" />
<references>
<ref name="a">a</ref>
<ref name="b">a</ref>
<ref name="c">a</ref>
</references>
!! html
<p><sup id="cite_ref-a1_1-0" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-a1_1-1" class="reference"><a href="#cite_note-a1-1">&#91;1.1&#93;</a></sup>
<sup id="cite_ref-b1_2-0" class="reference"><a href="#cite_note-b1-2">&#91;2.1&#93;</a></sup>
<sup id="cite_ref-b1_2-1" class="reference"><a href="#cite_note-b1-2">&#91;2.1&#93;</a></sup>
<sup id="cite_ref-c1_3-0" class="reference"><a href="#cite_note-c1-3">&#91;3.1&#93;</a></sup>
<sup id="cite_ref-c1_3-1" class="reference"><a href="#cite_note-c1-3">&#91;3.1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-a-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-a1-1"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-a1_1-0">1.1.0</a></sup> <sup><a href="#cite_ref-a1_1-1">1.1.1</a></sup></span> <span class="reference-text">a1</span>
</li>
</ol></li>
<li id="cite_note-b-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-b1-2"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-b1_2-0">2.1.0</a></sup> <sup><a href="#cite_ref-b1_2-1">2.1.1</a></sup></span> <span class="reference-text">b1</span>
</li>
</ol></li>
<li id="cite_note-c-"><span class="mw-cite-backlink">↑ </span> <span class="reference-text">a</span>
<ol class="mw-extended-references"><li id="cite_note-c1-3"><span class="mw-cite-backlink">↑ <sup><a href="#cite_ref-c1_3-0">3.1.0</a></sup> <sup><a href="#cite_ref-c1_3-1">3.1.1</a></sup></span> <span class="reference-text">c1</span>
</li>
</ol></li>
</ol></div>
!! end
Reference in a new issue Copy permalink