Kunal Mehta
72db0e9107
Avoid unnecessary is_bool
...
Strict equality already ensures that the global is a boolean.
Change-Id: I09011f4d6ac5fabe1154ef19d8ba34f289f764f7
2018-04-10 20:48:37 -07:00
Kunal Mehta
1c60788059
Set visibility on all functions
...
Change-Id: I1ced553ac5c18eafa83e32516ddc463feece96ef
2018-04-10 20:48:37 -07:00
Kunal Mehta
d90bfe3c12
isset() already checks whether the value is null
...
Change-Id: I35c1fe14ef5fc8b073d098b27dffd23b3abc2556
2018-04-10 20:48:37 -07:00
Kunal Mehta
c28084d3c5
Don't specify default parameters to SpecialPage::__construct()
...
Change-Id: I8fae3fee0edbc95b1bb7d012af6e4ce067bb4f62
2018-04-10 20:48:37 -07:00
Kunal Mehta
987392938b
Use ::class
...
Change-Id: Id43297b7930cd8f3e5a330c5e99fea9b85014c65
2018-04-10 20:48:37 -07:00
Kunal Mehta
4e1158b7d2
Add phan configuration
...
Change-Id: I8d438ad061500bc56f5e3e527f18296485988d6f
2018-04-08 18:50:31 -07:00
Timo Tijhof
38babc1011
Set visibility of CategoryTree::encodeOptions() as protected
...
Not referenced anywhere in Wikimedia Git, except for the one
method that uses it, in the same class here.
Also:
* Set explicit 'public' visibility of getOptionsAsJsStructure().
* Avoid use of !is_null().
* Avoid assignment in ternary.
Change-Id: I71d2a247e001b7f7f4f52546e8167a79d873076e
2018-02-16 19:30:51 -08:00
Kunal Mehta
8e51ea4e3a
Move classes into includes/
...
Change-Id: I308523aa764594798d72974fb79e19aef6c3f342
2018-02-08 22:23:07 -08:00