Commit graph

81 commits

Author SHA1 Message Date
Aryeh Gregor 064ce8137b Adapt CategoryTree to the new schema
This should obsolete $wgCategoryTreeMaxScanRows, added in r67179, so I
removed it.  Note that I only tested with very basic usage, since I
don't quite understand all the complicated things this extension can do,
and some code paths are certainly going to remain inefficient, since
arbitrary namespace filtering seems possible here (at least
renderChildren() has support for it).  However, clicking the little plus
sign on category pages should now scan only as many rows as are actually
used, so no limit should be necessary.

Sorting is now by cl_type, cl_sortkey instead of cl_sortkey.  This
change has to be made to all users for efficiency, since the old index
was dropped.  It means the sort order might be somewhat unexpected in
some cases, but for basic CategoryTree use it makes no difference, since
all the results have cl_type = 'subcat' anyway.

Fixes bug 23682, I think.
2010-08-16 21:57:49 +00:00
Aryeh Gregor e2300181e5 Save up to 200 queries per click in CategoryTree
Remember, people: if you use Titles that don't have all the proper
fields prefetched, LinkCache will fetch them for you, one by one.
Fetching page_id, page_len, page_is_latest, and page_latest will make
everything work without needless queries.
2010-08-16 21:37:26 +00:00
Aryeh Gregor 6873b490ef Use DB abstraction CategoryTree::renderChildren()
Formerly pieced it all together with strings.  This seems not to have
broken anything for basic usage, but I didn't test thoroughly.  Also
fixed some random style errors and unused variables while I was there.
2010-08-13 22:38:00 +00:00
Sam Reed 7beb050639 More wrong static method calls fixed 2010-07-26 13:30:31 +00:00
Sam Reed 78d6b8163d Remove some more unused globals
Kill a couple of other unused variables
2010-07-25 17:12:50 +00:00
Siebrand Mazeland ebff4d349b Replace Title::makeTitle[Safe]( NS_SPECIAL, 'x' ) with SpecialPage::getTitleFor ( 'x' )
And a few other minor changes.
2010-06-08 19:30:48 +00:00
Alexandre Emsenhuber 261d68c15a Big changes to extensions' documentation:
* changed all @addtogroup to @ingroup
* added some @file where needed
* changed some @package/@subpackage to @ingroup
2010-06-06 15:12:22 +00:00
Daniel Kinzler b719db957d PHP compatibility: 5.3.1 is picky about pass-by-reference. Restrict use of &$foo to actual output parameters. This should probably be done for the entire code base. 2010-06-02 09:10:09 +00:00
Roan Kattouw 833afe31a3 CategoryTree: Backport r67183 from 1.16wmf4 2010-06-01 14:28:08 +00:00
Tim Starling adca6de0aa * Per Aryeh's suggestion on CR r66987, treat categories larger than a certain size as empty. The visual presentation is not perfect, but it needs some more aggressive treatment than what I can give it right now.
* Get counts into local variables, to make the code slightly more compact.
2010-06-01 08:58:04 +00:00
Tim Starling 3c3fdfde1a * (bug 23682) Don't allow people to expand subtree when it's known to be empty, this is inefficient.
* Fixed a bug causing the "+" link to be shown even when the number of subcategories is zero, due to the DBMS returning a string instead of an integer, causing triple-equals comparison to fail.
2010-05-28 02:15:44 +00:00
Siebrand Mazeland bc388d6493 * stylize.php, trailing whitespace removed, indentation updated
* removed CategoryTree::init(). Loading messages explicitly is no longer needed
* removed commented out code bits.
2010-04-20 22:00:34 +00:00
Daniel Kinzler 8ca7b829d1 fix bug 20040: add PageRenderingHash to cache key to prevent cache mixup. Patch by Derk-Jan Hartman 2010-04-06 21:46:46 +00:00
Chad Horohoe 2db8ddf48b Get rid of the last (I think) php4-style calls to wfGetDB() 2010-02-13 23:03:40 +00:00
Jure Kajzer da16f18419 replaced hardcoded LIMIT with limitResult function call 2010-02-09 16:15:47 +00:00
Sam Reed 5d1c27e51a Mass convert NULL -> null. Left strings and comments alone, obviously.
As per ^demon's suggestion
2010-01-06 21:24:10 +00:00
Tim Starling 8daf5ed778 One more convert call, not sure where it came from. 2009-05-27 07:45:31 +00:00
Tim Starling 28959f9548 Fixed r51002 by also reverting r49856. 2009-05-27 06:17:56 +00:00
Tim Starling d0c62f44ce Reverted r49855, r49656, r49401, r49399, r49397. The language converter cannot be used outside the parser at present without generating a large number of bugs, due to global lifetime state variables, inappropriate $wgParser references, etc. Some refactoring needs to be done before it can be used in this way. 2009-05-26 07:46:29 +00:00
Philip Tzou 16c2b860ef Use $wgContLang->convertHtml() instead of htmlspecialchars(). 2009-04-25 05:19:46 +00:00
Philip Tzou 94cbc8721a Enabled LanguageConverter on extension:CategoryTree.
Convert title text displayed in Category with title mode.
2009-04-25 05:13:18 +00:00
Alexandre Emsenhuber 9700e2d54a * (bug 16744) Calling <categorytree> or {{#categorytree:...}} on non-existent category no longer expose strip markers
Changed call from wfMsgExt() with 'parseinline' as option to Parser::recursiveTagParse()
2009-04-14 17:44:55 +00:00
Andrew Garrett 3218558463 display: none; the CategoryTree expand links in the HTML, and have JS unhide them. 2009-03-06 23:13:49 +00:00
Siebrand Mazeland 9196456dfe Replace hard coded pipe separators with locale based 2009-02-09 21:59:06 +00:00
Daniel Kinzler 2e7c44ff98 don't use <a> for clickable bullets; improve usability (tab navigation) in text browsers 2008-11-14 12:47:54 +00:00
Daniel Kinzler 96bc20d349 fix typo: use 'parseinline' with wfMsgExt, not 'parserinline' 2008-11-14 12:34:38 +00:00
Brion Vibber 4648a812c9 Cleanup r42210 "* (bug 16015) Change parsing of MediaWiki:Categorytree-member-num to allow &nbsp;"
'parsemag' was mysteriously chaned to 'parseinline', which is incorrect given that the result is HTML-escaped with 'escapenoenities' -- they don't play nicely together. :)

Changed it back to 'parsemag'. 'parseinline' *without* 'escapenoentities' might also seem like a good choice, but didn't seem to be what was intended.

Also broke the very very very long line for legibility.
2008-10-20 00:57:55 +00:00
Raimond Spekking 7ac2cc94ad * (bug 16015) Change parsing of MediaWiki:Categorytree-member-num to allow &nbsp; 2008-10-18 21:28:23 +00:00
Huji 63d32a5d09 Counts should be shown using localized digits, just like r 37784 2008-07-25 21:55:13 +00:00
Daniel Kinzler 63e2567287 adding option for expandable category-bar. not fully functional until skin refactoring is merged in. Just dont use $wgCategoryTreeHijackPageCategories until then. 2008-07-11 23:18:41 +00:00
Daniel Kinzler 1490e3246d make member count display customizable via system messages 2008-07-11 23:07:01 +00:00
Daniel Kinzler e2dc29c1f5 added missing initialization for 'category not found' code path 2008-07-04 20:05:29 +00:00
Daniel Kinzler c185806c42 handle red category links (needed for inverse mode) 2008-07-02 20:19:54 +00:00
Daniel Kinzler bbdba735c6 optionally show category tree in the sidebar (requires skin update from r36917) 2008-07-02 15:13:45 +00:00
Daniel Kinzler e366e21edd added inverse mode to navigate parent categories 2008-07-02 09:49:28 +00:00
Daniel Kinzler f1ae48340e introduced configurable namespace filtering (and fixed some glitches) 2008-07-01 21:40:42 +00:00
Daniel Kinzler 2696d25af4 use wgMsgXXX consistently. Add support for {{PLURAL}} where appropriate (bug 14690). 2008-07-01 13:36:50 +00:00
Daniel Kinzler 30739f8a50 support common tag attributes 2008-06-30 21:35:01 +00:00
Daniel Kinzler d7958d00cf smarter modes for hideprefix option. namespace is now hidden for subcategories per default 2008-06-30 21:22:03 +00:00
Daniel Kinzler 595c3cfaef Show member counts in category tree. Requires r36814 of Category.php and CategoryPage.php. 2008-06-30 14:09:47 +00:00
Daniel Kinzler e7ce70ec45 make [+] link to target category if js is off 2008-06-28 20:47:44 +00:00
Daniel Kinzler dbfd3e4833 Restructuring and revamping; more messages, more options, better config, more flexible ajax interface. Should be fully backwards compatible. It will hopefully even work for people with old JS code cached. 2008-06-28 20:13:20 +00:00
Raimond Spekking 56bd285d84 * Add a nice fieldset around the input form
* Use proper XML function
2008-03-18 17:38:32 +00:00
Siebrand Mazeland 18ba9f7daa * CategoryTree uses wfLoadExtensionMessages now
* add descriptionmsg and version in extension credits where missing
* update Translate
2008-02-04 10:25:48 +00:00
Siebrand Mazeland bce152a958 Whitespace fixes 2008-02-04 09:22:12 +00:00
Siebrand Mazeland 52b4245dcf (bug 12608) Unifying the spelling of getDBkey() in the extension code. 2008-01-14 10:09:08 +00:00
Brion Vibber 6d8cbbd891 * (bug 11383) Don't pull subcategories for non-category pages in category tree 2007-09-18 15:52:30 +00:00
Daniel Kinzler dd5b464ccd avoid filesort. downside: subcategories are more likely to be lost if categories and pages are listed together, and the limit is hit; that is, the limit is not applied to the list as displayed. This is counter-intuitive (kind of like the paging of subcategories on category pages) 2007-09-01 11:26:00 +00:00
Brion Vibber d0b1db56b4 * (bug 11015) Handle HTTP errors for CategoryTree ajax request more gracefully. Instead of dumping the entire error page's HTML inline, display a nice clean bit of text with a functional retry link.
* Added $wgCategoryTreeVersion variable to bump JS and CSS URLs on update
2007-08-25 15:23:20 +00:00
Brion Vibber eafc0d758a Fix for bug 10883: correctly handle categories that look like interwikis if you ignore the namespace part 2007-08-25 12:40:40 +00:00