Commit graph

162 commits

Author SHA1 Message Date
Fomafix 6684f62bba Simplify by using Xml::element
Xml::element already makes the HTML encoding.

Change-Id: Idee5e6871c5a7b5e6763ebe85275598b9b217224
2018-04-18 09:36:40 +02:00
Kunal Mehta 50c10d1fcb Use standard GPL file header
Change-Id: Ic49d45d0a0cb640d40486735c95f13cc6e29063f
2018-04-16 22:38:06 +00:00
Kunal Mehta d85ca412b7 Don't conditionally register any hooks
Register all hooks unconditionally in extension.json, and then in the
hook
itself, check whether they should be doing anything.

Change-Id: I5f0019fc444371a24a11a25ca2d980c0a9ab5a61
2018-04-16 18:05:06 +00:00
libraryupgrader 5a7ebcfead build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.LicenseComment.InvalidLicenseTag

Change-Id: I13c4825186d8ba101feb2a2d28ee8dc9bc7306dd
2018-04-13 22:19:35 +00:00
Kunal Mehta 72db0e9107 Avoid unnecessary is_bool
Strict equality already ensures that the global is a boolean.

Change-Id: I09011f4d6ac5fabe1154ef19d8ba34f289f764f7
2018-04-10 20:48:37 -07:00
Kunal Mehta 1c60788059 Set visibility on all functions
Change-Id: I1ced553ac5c18eafa83e32516ddc463feece96ef
2018-04-10 20:48:37 -07:00
Kunal Mehta d90bfe3c12 isset() already checks whether the value is null
Change-Id: I35c1fe14ef5fc8b073d098b27dffd23b3abc2556
2018-04-10 20:48:37 -07:00
Kunal Mehta c28084d3c5 Don't specify default parameters to SpecialPage::__construct()
Change-Id: I8fae3fee0edbc95b1bb7d012af6e4ce067bb4f62
2018-04-10 20:48:37 -07:00
Kunal Mehta 987392938b Use ::class
Change-Id: Id43297b7930cd8f3e5a330c5e99fea9b85014c65
2018-04-10 20:48:37 -07:00
Kunal Mehta 4e1158b7d2 Add phan configuration
Change-Id: I8d438ad061500bc56f5e3e527f18296485988d6f
2018-04-08 18:50:31 -07:00
Timo Tijhof 38babc1011 Set visibility of CategoryTree::encodeOptions() as protected
Not referenced anywhere in Wikimedia Git, except for the one
method that uses it, in the same class here.

Also:
* Set explicit 'public' visibility of getOptionsAsJsStructure().
* Avoid use of !is_null().
* Avoid assignment in ternary.

Change-Id: I71d2a247e001b7f7f4f52546e8167a79d873076e
2018-02-16 19:30:51 -08:00
Kunal Mehta 8e51ea4e3a Move classes into includes/
Change-Id: I308523aa764594798d72974fb79e19aef6c3f342
2018-02-08 22:23:07 -08:00