wikimedia/mediawiki-extensions-CategoryTree
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CategoryTree synced 2024-11-27 09:43:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove eslint exception rule 'no-shadow' and rename variable

Browse source 
Also fix JSDoc warnings.

Change-Id: Idb2f15bd9ce134b17381bde1303a2e427c3056fb
This commit is contained in:
Fomafix 2021-08-21 15:21:15 +00:00 committed by Krinkle
parent 23d6c8f5bd
commit d1af686a0d
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.eslintrc.json
View file

@ -8,8 +8,5 @@
"env": { "env": {
"browser": true, "browser": true,
"commonjs": true "commonjs": true
},
"rules": {
"no-shadow": "warn"
} }
} }

7
modules/ext.categoryTree/ext.categoryTree.js
View file

@ -19,13 +19,12 @@
* http://www.gnu.org/copyleft/gpl.html * http://www.gnu.org/copyleft/gpl.html
* *
* @file * @file
* @ingroup Extensions
* @author Daniel Kinzler, brightbyte.de * @author Daniel Kinzler, brightbyte.de
*/ */
( function () { ( function () {
var loadChildren, var loadChildren,
data = require( './data.json' ); config = require( './data.json' );
/** /**
* Expands a given node (loading it's children if not loaded) * Expands a given node (loading it's children if not loaded)
@ -65,7 +64,7 @@
/** /**
* Handles clicks on the expand buttons, and calls the appropriate function * Handles clicks on the expand buttons, and calls the appropriate function
* *
* @context {Element} CategoryTreeToggle * @this {Element} CategoryTreeToggle
*/ */
function handleNode() { function handleNode() {
var $link = $( this ); var $link = $( this );
@ -144,7 +143,7 @@
ctTitle = $link.attr( 'data-ct-title' ); ctTitle = $link.attr( 'data-ct-title' );
ctMode = $linkParentCTTag.data( 'ct-mode' ); ctMode = $linkParentCTTag.data( 'ct-mode' );
ctMode = typeof ctMode === 'number' ? ctMode : undefined; ctMode = typeof ctMode === 'number' ? ctMode : undefined;
ctOptions = $linkParentCTTag.attr( 'data-ct-options' ) || data.defaultCtOptions; ctOptions = $linkParentCTTag.attr( 'data-ct-options' ) || config.defaultCtOptions;
// Mode and options have defaults or fallbacks, title does not. // Mode and options have defaults or fallbacks, title does not.
// Don't make a request if there is no title. // Don't make a request if there is no title.