wikimedia/mediawiki-extensions-CategoryTree
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CategoryTree synced 2024-11-27 09:43:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for null after Title::newFromText

Browse source 
Title::newFromText returns null on invalid title.

Change-Id: Iaef69584eff33b1b13669f8d0a3b8eeeba3755cc
This commit is contained in:
Fomafix 2022-11-10 19:27:04 +00:00
parent abbc5c5e32
commit cf8538086c
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/CategoryTree.php
View file

@ -468,9 +468,7 @@ class CategoryTree {
foreach ( $res as $row ) {
$title = Title::newFromText( $row->page_title, $row->page_namespace );
// Page name could have slashes, check the subpage for valid language built-in codes
$isValidLangCode = $title->getSubpageText();
if ( $title !== null && $isValidLangCode ) {
if ( $title !== null && $title->getSubpageText() ) {
$lb->addObj( $title->getBaseTitle() );
}
}