wikimedia/mediawiki-extensions-CategoryTree
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CategoryTree synced 2024-11-27 09:43:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use explicit nullable type on parameter arguments (for PHP 8.4)

Browse source 
Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.

Bug: T376276
Change-Id: I40bb7a0a02aaa467cbf0ae182adf5601ccbcb58e
This commit is contained in:
Andre Klapper 2024-10-26 14:43:17 +02:00 committed by Umherirrender
parent b5db5ef8ad
commit be5111cfb9
4 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.phpcs.xml
View file

@ -1,8 +1,6 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
</rule>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<file>.</file>
<arg name="extensions" value="php" />
<arg name="encoding" value="UTF-8" />

2
includes/CategoryTree.php
View file

@ -294,7 +294,7 @@ class CategoryTree {
* Returns a string with a HTML represenation of the given page.
* $info must be an associative array, containing at least a Title object under the 'title' key.
*/
public function renderNodeInfo( Title $title, Category $cat = null, int $children = 0 ): string {
public function renderNodeInfo( Title $title, ?Category $cat = null, int $children = 0 ): string {
$mode = $this->optionManager->getOption( 'mode' );
$isInCatNS = $title->inNamespace( NS_CATEGORY );

4
includes/Hooks.php
View file

@ -190,8 +190,8 @@ class Hooks implements
public function parserHook(
$cat,
array $argv,
Parser $parser = null,
PPFrame $frame = null
?Parser $parser = null,
?PPFrame $frame = null
) {
if ( $parser ) {
$parserOutput = $parser->getOutput();

4
includes/OptionManager.php
View file

@ -260,7 +260,7 @@ class OptionManager {
* @param int|null $depth
* @return string
*/
public function getOptionsAsCacheKey( int $depth = null ): string {
public function getOptionsAsCacheKey( ?int $depth = null ): string {
$key = '';
foreach ( $this->mOptions as $k => $v ) {
@ -280,7 +280,7 @@ class OptionManager {
* @param int|null $depth
* @return mixed
*/
public function getOptionsAsJsStructure( int $depth = null ) {
public function getOptionsAsJsStructure( ?int $depth = null ) {
$opt = $this->mOptions;
if ( $depth !== null ) {
$opt['depth'] = $depth;