From 77b047b12b729d01a079c96359e2708a75e68466 Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Tue, 5 Nov 2024 11:46:16 +0330 Subject: [PATCH] Remove page href from arrows As having href causes arrows to be clickable before JavaScript handler be loaded. And since that disables visited logic, let's remove it. Change-Id: Ice4c979d020342890fffd587bb5bee88fcc2a1ae --- includes/CategoryTree.php | 1 - modules/ext.categoryTree.styles.less | 4 ---- tests/parser/parserTests.txt | 4 ++-- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/includes/CategoryTree.php b/includes/CategoryTree.php index af4d6049..06a90ecd 100644 --- a/includes/CategoryTree.php +++ b/includes/CategoryTree.php @@ -354,7 +354,6 @@ class CategoryTree { // href and role will be added client-side 'class' => 'CategoryTreeToggle', 'data-ct-title' => $key, - 'href' => $title->getLocalURL(), ]; if ( $children === 0 ) { diff --git a/modules/ext.categoryTree.styles.less b/modules/ext.categoryTree.styles.less index a14f2a65..a103fd20 100644 --- a/modules/ext.categoryTree.styles.less +++ b/modules/ext.categoryTree.styles.less @@ -83,10 +83,6 @@ .CategoryTreeToggle { transition: transform 250ms ease; .expandable-arrow( @color-progressive ); - - &:visited { - .expandable-arrow( @color-visited ); - } } .CategoryTreeEmptyBullet, diff --git a/tests/parser/parserTests.txt b/tests/parser/parserTests.txt index dfc25408..2fdfe602 100644 --- a/tests/parser/parserTests.txt +++ b/tests/parser/parserTests.txt @@ -117,11 +117,11 @@ Tag with CategoryTree root and two subcategories !! wikitext CategoryTree root !! html/php -
CategoryTree root
CategoryTree 1
CategoryTree 2
+
CategoryTree root
CategoryTree 1
CategoryTree 2
!! html/parsoid
-
CategoryTree root
+
CategoryTree root
CategoryTree 1