From 63688178e965a10ac3c6b3ed8bb8988a4f88a9b1 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sat, 26 Oct 2024 14:43:17 +0200 Subject: [PATCH] Use explicit nullable type on parameter arguments (for PHP 8.4) Implicitly marking parameter $... as nullable is deprecated in PHP 8.4. The explicit nullable type must be used instead. Bug: T376276 Change-Id: I40bb7a0a02aaa467cbf0ae182adf5601ccbcb58e --- includes/CategoryTree.php | 2 +- includes/Hooks.php | 4 ++-- includes/OptionManager.php | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/CategoryTree.php b/includes/CategoryTree.php index 90c6a10c..077a938a 100644 --- a/includes/CategoryTree.php +++ b/includes/CategoryTree.php @@ -294,7 +294,7 @@ class CategoryTree { * Returns a string with a HTML represenation of the given page. * $info must be an associative array, containing at least a Title object under the 'title' key. */ - public function renderNodeInfo( Title $title, Category $cat = null, int $children = 0 ): string { + public function renderNodeInfo( Title $title, ?Category $cat = null, int $children = 0 ): string { $mode = $this->optionManager->getOption( 'mode' ); $isInCatNS = $title->inNamespace( NS_CATEGORY ); diff --git a/includes/Hooks.php b/includes/Hooks.php index 737964a5..805ccf4a 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -190,8 +190,8 @@ class Hooks implements public function parserHook( $cat, array $argv, - Parser $parser = null, - PPFrame $frame = null + ?Parser $parser = null, + ?PPFrame $frame = null ) { if ( $parser ) { $parserOutput = $parser->getOutput(); diff --git a/includes/OptionManager.php b/includes/OptionManager.php index 7416e23c..97eafa02 100644 --- a/includes/OptionManager.php +++ b/includes/OptionManager.php @@ -260,7 +260,7 @@ class OptionManager { * @param int|null $depth * @return string */ - public function getOptionsAsCacheKey( int $depth = null ): string { + public function getOptionsAsCacheKey( ?int $depth = null ): string { $key = ''; foreach ( $this->mOptions as $k => $v ) { @@ -280,7 +280,7 @@ class OptionManager { * @param int|null $depth * @return mixed */ - public function getOptionsAsJsStructure( int $depth = null ) { + public function getOptionsAsJsStructure( ?int $depth = null ) { $opt = $this->mOptions; if ( $depth !== null ) { $opt['depth'] = $depth;