Remove hook SkinJoinCategoryLinks

The hook `SkinJoinCategoryLinks` is not used and not triggered.

Also remove the style for the class CategoryTreeCategoryBarItem because
it is only used in skinJoinCategoryLinks::skinJoinCategoryLinks.

Change-Id: I52e4f819ff195fc1fa8a148b0bb58d95a4bf22d7

extension.json

@@ -99,7 +99,6 @@
 		"MakeGlobalVariablesScript": "CategoryTreeHooks::getConfigVars",
 		"ParserFirstCallInit": "CategoryTreeHooks::setHooks",
 		"OutputPageMakeCategoryLinks": "CategoryTreeHooks::outputPageMakeCategoryLinks",
-		"SkinJoinCategoryLinks": "CategoryTreeHooks::skinJoinCategoryLinks",
 		"BeforePageDisplay": "CategoryTreeHooks::addHeaders",
 		"BeforePageDisplayMobile": "CategoryTreeHooks::addHeaders",
 		"OutputPageParserOutput": "CategoryTreeHooks::parserOutput"

includes/CategoryTreeHooks.php

@@ -234,27 +234,6 @@ class CategoryTreeHooks {
 		return false;
 	}
 
-	/**
-	 * @param Skin $skin
-	 * @param array &$links
-	 * @param string &$result
-	 * @return bool
-	 */
-	public static function skinJoinCategoryLinks( $skin, &$links, &$result ) {
-		global $wgCategoryTreeHijackPageCategories;
-		if ( !$wgCategoryTreeHijackPageCategories ) {
-			// Not enabled, don't do anything.
-			return true;
-		}
-		$embed = '<div class="CategoryTreeCategoryBarItem">';
-		$pop = '</div>';
-		$sep = ' ';
-
-		$result = $embed . implode( "{$pop} {$sep} {$embed}", $links ) . $pop;
-
-		return false;
-	}
-
 	/**
 	 * @param array &$vars
 	 * @return bool

modules/ext.categoryTree.styles.css

@@ -96,14 +96,6 @@
 	font-style: italic;
 }
 
-.CategoryTreeCategoryBarItem {
-	display: inline-block;
-	/* why is the -0.5ex needed? */
-	margin: -0.5ex 0 0 1ex;
-	padding: 0;
-	vertical-align: top;
-}
-
 .CategoryTreeSection {
 	direction: ltr;
 }