mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-12-04 02:18:31 +00:00
745d911d68
Regression tests to make sure T286140 does not happen again. In the process, discovered what caused that bug with afl_rev_id not being set: EditRevUpdater::updateRev() compares the WikiPage given in the PageSaveComplete hook to the one given to it by AbuseFilterHooks from onEditFilterMergedContent, and compares the two using `===`, meaning that they must refer to the same underlying object. That bug was caused because AbuseFilterHooks changed to providing a different object, despite still referring to the same underlying page. We should probably change that behavior in EditRevUpdater, but for now updated AbuseFilterConsequencesTest to pass the same object around by using RequestContext::setWikiPage() and providing the WikiPage object to MediaWikiIntegrationTestCase::editPage(). Bug: T286140 Change-Id: I6562f513c463538af6b59b12a64564b254024613 |
||
---|---|---|
.. | ||
integration | ||
unit | ||
AbuseFilterBlockTest.php | ||
AbuseFilterConsequencesTest.php | ||
AbuseFilterCreateAccountTestTrait.php | ||
AbuseFilterFilterUserTest.php | ||
AbuseFilterRowsAndFiltersTestTrait.php | ||
AbuseFilterSaveTest.php | ||
AbuseFilterUploadTestTrait.php | ||
ConsequenceGetMessageTestTrait.php | ||
ConsequencesExecutorTest.php | ||
DegroupTest.php | ||
LazyVariableComputerDBTest.php | ||
RangeBlockTest.php | ||
RCVariableGeneratorTest.php | ||
SchemaChangesHandlerTest.php | ||
UpdateHitCountWatcherTest.php |