mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-12-03 01:56:28 +00:00
416dcd9ba3
- Add a helper method to output an unrecoverable error, comprising a button to go back to the filters list; - Move the token check to attemptSave, so to make the conditionals easier to read, and group errors together - Make buildFilterEditor take an HTML parameter for the error, so the caller can specify whether it's error or warning - Move the check for non-existing filters out of buildFilterEditor - Add a bunch of typehints - Don't set af_throttled and af_hit_count in the empty row template, but set af_deleted (these are only used in buildFilterEditor) - Make AbuseFilter::translateFromHistory consistently include the af_global property (previously it would only be set for global filters; this error was introduced when first implementing global filters) - The only user-facing change is that, when trying to use a custom warning/disallow message on a global filter, this is now considered a non-fatal error, so we now show the editing interface (and not just an unrecoverable error). The next step is resolving the @todo in buildFilterEditor about null checks. Change-Id: I9d217dcac3f4cc0b26e53eca735cc327d5efc76d |
||
|---|---|---|
| .. | ||
| AbuseFilterChangeTaggerTest.php | ||
| AbuseFilterKeywordsManagerTest.php | ||
| AbuseFilterParserTest.php | ||
| AbuseFilterParserTestCase.php | ||
| AbuseFilterTest.php | ||
| AbuseFilterTokenizerTest.php | ||
| AbuseFilterVariableGeneratorTest.php | ||
| AbuseFilterVariableHolderTest.php | ||
| AFPDataTest.php | ||
| SpecialAbuseFilterTest.php | ||