mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-24 14:13:54 +00:00
6c8a29698b
Ideally, this might live in MediaWikiIntegrationTestCase. For the createaccount one, AuthManager should also provide a method to log the creation, because currently we are forced to copypaste that code here. - Add the missing tests for 'upload' in RCVariableGenerator, and adjust the existing ones (delete file afterwards, more tablesUsed, use the right extension). - Exclude from the coverage report a couple of lines which should theoretically be unreachable. Escalate logging to WARN level, where it's more likely to be spotted. - Remove an unused method (RCVariableGenerator::newFromID). This denies the need to maintain and cover it. We also don't want this generator to act as a factory. Overall, this change brings the coverage for RCVariableGenerator to 100% Bug: T201193 Change-Id: I425c3d9f6800f74eb6e4eda483b90cfb3bbbcb51 |
||
---|---|---|
.. | ||
RCVariableGenerator.php | ||
RunVariableGenerator.php | ||
VariableGenerator.php |