mediawiki-extensions-AbuseF.../includes/FilterLookup.php
STran ca23e9f06b Convert af_hidden into a bitmask
Protected variables will cause the filter using them to become
protected as well. `af_hidden` can be used to track this flag,
as it is a TINYINT and can be converted into a bitmask with no
schema changes.

This is not a backwards-compatible change, as now all checks must
check the `hidden` flag specifically or otherwise will be cast to
true if any flag is set.

To support this change:
- "hidden" is considered a flag set in the `af_hidden`. This is a
  change in concept with no need for updates to the column values,
  as there is currently only one flag in the bitmask.
- `Flag`s store the bitmask as well as the state of single flags
  and can return either.
- Any checks against the `af_hidden` value no longer check a
  boolean value and instead now check the `hidden` flag value.

Bug: T363906
Change-Id: I358205cb1119cf1e4004892c37e36e0c0a864f37
2024-05-28 00:59:08 -07:00

532 lines
16 KiB
PHP

<?php
namespace MediaWiki\Extension\AbuseFilter;
use IDBAccessObject;
use MediaWiki\Extension\AbuseFilter\Filter\ClosestFilterVersionNotFoundException;
use MediaWiki\Extension\AbuseFilter\Filter\ExistingFilter;
use MediaWiki\Extension\AbuseFilter\Filter\FilterNotFoundException;
use MediaWiki\Extension\AbuseFilter\Filter\FilterVersionNotFoundException;
use MediaWiki\Extension\AbuseFilter\Filter\Flags;
use MediaWiki\Extension\AbuseFilter\Filter\HistoryFilter;
use MediaWiki\Extension\AbuseFilter\Filter\LastEditInfo;
use MediaWiki\Extension\AbuseFilter\Filter\Specs;
use RuntimeException;
use stdClass;
use WANObjectCache;
use Wikimedia\Rdbms\ILoadBalancer;
use Wikimedia\Rdbms\IReadableDatabase;
use Wikimedia\Rdbms\SelectQueryBuilder;
/**
* This class provides read access to the filters stored in the database.
*
* @todo Cache exceptions
*/
class FilterLookup implements IDBAccessObject {
public const SERVICE_NAME = 'AbuseFilterFilterLookup';
// Used in getClosestVersion
public const DIR_PREV = 'prev';
public const DIR_NEXT = 'next';
/**
* @var ExistingFilter[] Individual filters cache. Keys can be integer IDs, or global names
*/
private $cache = [];
/**
* @var ExistingFilter[][][] Cache of all active filters in each group. This is not related to
* the individual cache, and is replicated in WAN cache. The structure is
* [ local|global => [ group => [ ID => filter ] ] ]
* where the cache for each group has the same format as $this->cache
* Note that the keys are also in the form 'global-ID' for filters in 'global', although redundant.
*/
private $groupCache = [ 'local' => [], 'global' => [] ];
/** @var HistoryFilter[] */
private $historyCache = [];
/** @var int[] */
private $firstVersionCache = [];
/** @var int[] */
private $lastVersionCache = [];
/**
* @var int[][] [ filter => [ historyID => [ prev, next ] ] ]
* @phan-var array<int,array<int,array{prev?:int,next?:int}>>
*/
private $closestVersionsCache = [];
/** @var ILoadBalancer */
private $loadBalancer;
/** @var WANObjectCache */
private $wanCache;
/** @var CentralDBManager */
private $centralDBManager;
/**
* @var bool Flag used in PHPUnit tests to "hide" local filters when testing global ones, so that we can use the
* local database pretending it's not local.
*/
private bool $localFiltersHiddenForTest = false;
/**
* @param ILoadBalancer $loadBalancer
* @param WANObjectCache $cache
* @param CentralDBManager $centralDBManager
*/
public function __construct(
ILoadBalancer $loadBalancer,
WANObjectCache $cache,
CentralDBManager $centralDBManager
) {
$this->loadBalancer = $loadBalancer;
$this->wanCache = $cache;
$this->centralDBManager = $centralDBManager;
}
/**
* @param int $filterID
* @param bool $global
* @param int $flags One of the IDBAccessObject::READ_* constants
* @return ExistingFilter
* @throws FilterNotFoundException if the filter doesn't exist
* @throws CentralDBNotAvailableException
*/
public function getFilter(
int $filterID, bool $global, int $flags = IDBAccessObject::READ_NORMAL
): ExistingFilter {
$cacheKey = $this->getCacheKey( $filterID, $global );
if ( $flags !== IDBAccessObject::READ_NORMAL || !isset( $this->cache[$cacheKey] ) ) {
$dbr = ( $flags & IDBAccessObject::READ_LATEST )
? $this->getDBConnection( DB_PRIMARY, $global )
: $this->getDBConnection( DB_REPLICA, $global );
$row = $this->getAbuseFilterQueryBuilder( $dbr )
->where( [ 'af_id' => $filterID ] )
->recency( $flags )
->caller( __METHOD__ )->fetchRow();
if ( !$row ) {
throw new FilterNotFoundException( $filterID, $global );
}
$fname = __METHOD__;
$getActionsCB = function () use ( $dbr, $fname, $row ): array {
return $this->getActionsFromDB( $dbr, $fname, $row->af_id );
};
$this->cache[$cacheKey] = $this->filterFromRow( $row, $getActionsCB );
}
return $this->cache[$cacheKey];
}
/**
* Get all filters that are active (and not deleted) and in the given group
* @param string $group
* @param bool $global
* @param int $flags
* @return ExistingFilter[]
* @throws CentralDBNotAvailableException
*/
public function getAllActiveFiltersInGroup(
string $group, bool $global, int $flags = IDBAccessObject::READ_NORMAL
): array {
$domainKey = $global ? 'global' : 'local';
if ( $flags !== IDBAccessObject::READ_NORMAL || !isset( $this->groupCache[$domainKey][$group] ) ) {
if ( $global ) {
$globalRulesKey = $this->getGlobalRulesKey( $group );
$ret = $this->wanCache->getWithSetCallback(
$globalRulesKey,
WANObjectCache::TTL_WEEK,
function () use ( $group, $global, $flags ) {
return $this->getAllActiveFiltersInGroupFromDB( $group, $global, $flags );
},
[
'checkKeys' => [ $globalRulesKey ],
'lockTSE' => 300,
'version' => 3
]
);
} else {
$ret = $this->getAllActiveFiltersInGroupFromDB( $group, $global, $flags );
}
$this->groupCache[$domainKey][$group] = [];
foreach ( $ret as $key => $filter ) {
$this->groupCache[$domainKey][$group][$key] = $filter;
$this->cache[$key] = $filter;
}
}
return $this->groupCache[$domainKey][$group];
}
/**
* @param string $group
* @param bool $global
* @param int $flags
* @return ExistingFilter[]
*/
private function getAllActiveFiltersInGroupFromDB( string $group, bool $global, int $flags ): array {
if ( $this->localFiltersHiddenForTest && !$global ) {
return [];
}
$dbr = ( $flags & IDBAccessObject::READ_LATEST )
? $this->getDBConnection( DB_PRIMARY, $global )
: $this->getDBConnection( DB_REPLICA, $global );
$queryBuilder = $this->getAbuseFilterQueryBuilder( $dbr )
->where( [ 'af_enabled' => 1, 'af_deleted' => 0, 'af_group' => $group ] )
->recency( $flags );
if ( $global ) {
$queryBuilder->andWhere( [ 'af_global' => 1 ] );
}
// Note, excluding individually cached filter now wouldn't help much, so take it as
// an occasion to refresh the cache later
$rows = $queryBuilder->caller( __METHOD__ )->fetchResultSet();
$fname = __METHOD__;
$ret = [];
foreach ( $rows as $row ) {
$filterKey = $this->getCacheKey( $row->af_id, $global );
$getActionsCB = function () use ( $dbr, $fname, $row ): array {
return $this->getActionsFromDB( $dbr, $fname, $row->af_id );
};
$ret[$filterKey] = $this->filterFromRow(
$row,
// Don't pass a closure if global, as this is going to be serialized when caching
$global ? $getActionsCB() : $getActionsCB
);
}
return $ret;
}
/**
* @param int $dbIndex
* @param bool $global
* @return IReadableDatabase
* @throws CentralDBNotAvailableException
*/
private function getDBConnection( int $dbIndex, bool $global ): IReadableDatabase {
if ( $global ) {
return $this->centralDBManager->getConnection( $dbIndex );
} else {
return $this->loadBalancer->getConnection( $dbIndex );
}
}
/**
* @param IReadableDatabase $db
* @param string $fname
* @param int $id
* @return array
*/
private function getActionsFromDB( IReadableDatabase $db, string $fname, int $id ): array {
$res = $db->newSelectQueryBuilder()
->select( [ 'afa_consequence', 'afa_parameters' ] )
->from( 'abuse_filter_action' )
->where( [ 'afa_filter' => $id ] )
->caller( $fname )
->fetchResultSet();
$actions = [];
foreach ( $res as $actionRow ) {
$actions[$actionRow->afa_consequence] = $actionRow->afa_parameters !== ''
? explode( "\n", $actionRow->afa_parameters )
: [];
}
return $actions;
}
/**
* Get an old version of the given (local) filter, with its actions
*
* @param int $version Unique identifier of the version
* @param int $flags
* @return HistoryFilter
* @throws FilterVersionNotFoundException if the version doesn't exist
*/
public function getFilterVersion(
int $version,
int $flags = IDBAccessObject::READ_NORMAL
): HistoryFilter {
if ( $flags !== IDBAccessObject::READ_NORMAL || !isset( $this->historyCache[$version] ) ) {
$dbr = ( $flags & IDBAccessObject::READ_LATEST )
? $this->loadBalancer->getConnection( DB_PRIMARY )
: $this->loadBalancer->getConnection( DB_REPLICA );
$row = $this->getAbuseFilterHistoryQueryBuilder( $dbr )
->where( [ 'afh_id' => $version ] )
->recency( $flags )
->caller( __METHOD__ )->fetchRow();
if ( !$row ) {
throw new FilterVersionNotFoundException( $version );
}
$this->historyCache[$version] = $this->filterFromHistoryRow( $row );
}
return $this->historyCache[$version];
}
/**
* @param int $filterID
* @return HistoryFilter
* @throws FilterNotFoundException If the filter doesn't exist
*/
public function getLastHistoryVersion( int $filterID ): HistoryFilter {
if ( !isset( $this->lastVersionCache[$filterID] ) ) {
$dbr = $this->loadBalancer->getConnection( DB_REPLICA );
$row = $this->getAbuseFilterHistoryQueryBuilder( $dbr )
->where( [ 'afh_filter' => $filterID ] )
->orderBy( 'afh_id', SelectQueryBuilder::SORT_DESC )
->caller( __METHOD__ )->fetchRow();
if ( !$row ) {
throw new FilterNotFoundException( $filterID, false );
}
$filterObj = $this->filterFromHistoryRow( $row );
$this->lastVersionCache[$filterID] = $filterObj->getHistoryID();
$this->historyCache[$filterObj->getHistoryID()] = $filterObj;
}
return $this->historyCache[ $this->lastVersionCache[$filterID] ];
}
/**
* @param int $historyID
* @param int $filterID
* @param string $direction self::DIR_PREV or self::DIR_NEXT
* @return HistoryFilter
* @throws ClosestFilterVersionNotFoundException
*/
public function getClosestVersion( int $historyID, int $filterID, string $direction ): HistoryFilter {
if ( !isset( $this->closestVersionsCache[$filterID][$historyID][$direction] ) ) {
$comparison = $direction === self::DIR_PREV ? '<' : '>';
$order = $direction === self::DIR_PREV ? 'DESC' : 'ASC';
$dbr = $this->loadBalancer->getConnection( DB_REPLICA );
$row = $this->getAbuseFilterHistoryQueryBuilder( $dbr )
->where( [ 'afh_filter' => $filterID ] )
->andWhere( $dbr->expr( 'afh_id', $comparison, $historyID ) )
->orderBy( 'afh_timestamp', $order )
->caller( __METHOD__ )->fetchRow();
if ( !$row ) {
throw new ClosestFilterVersionNotFoundException( $filterID, $historyID );
}
$filterObj = $this->filterFromHistoryRow( $row );
$this->closestVersionsCache[$filterID][$historyID][$direction] = $filterObj->getHistoryID();
$this->historyCache[$filterObj->getHistoryID()] = $filterObj;
}
$histID = $this->closestVersionsCache[$filterID][$historyID][$direction];
return $this->historyCache[$histID];
}
/**
* Get the history ID of the first change to a given filter
*
* @param int $filterID
* @return int
* @throws FilterNotFoundException
*/
public function getFirstFilterVersionID( int $filterID ): int {
if ( !isset( $this->firstVersionCache[$filterID] ) ) {
$dbr = $this->loadBalancer->getConnection( DB_REPLICA );
$historyID = $dbr->newSelectQueryBuilder()
->select( 'MIN(afh_id)' )
->from( 'abuse_filter_history' )
->where( [ 'afh_filter' => $filterID ] )
->caller( __METHOD__ )
->fetchField();
if ( $historyID === false ) {
throw new FilterNotFoundException( $filterID, false );
}
$this->firstVersionCache[$filterID] = (int)$historyID;
}
return $this->firstVersionCache[$filterID];
}
/**
* Resets the internal cache of Filter objects
*/
public function clearLocalCache(): void {
$this->cache = [];
$this->groupCache = [ 'local' => [], 'global' => [] ];
$this->historyCache = [];
$this->firstVersionCache = [];
$this->lastVersionCache = [];
$this->closestVersionsCache = [];
}
/**
* Purge the shared cache of global filters in the given group.
* @note This doesn't purge the local cache
* @param string $group
*/
public function purgeGroupWANCache( string $group ): void {
$this->wanCache->touchCheckKey( $this->getGlobalRulesKey( $group ) );
}
/**
* @param string $group The filter's group (as defined in $wgAbuseFilterValidGroups)
* @return string
*/
private function getGlobalRulesKey( string $group ): string {
if ( !$this->centralDBManager->filterIsCentral() ) {
return $this->wanCache->makeGlobalKey(
'abusefilter',
'rules',
$this->centralDBManager->getCentralDBName(),
$group
);
}
return $this->wanCache->makeKey( 'abusefilter', 'rules', $group );
}
/**
* @param array $flags
* @return int
*/
private function getPrivacyLevelFromFlags( $flags ): int {
$hidden = in_array( 'hidden', $flags, true ) ?
Flags::FILTER_HIDDEN :
0;
return $hidden;
}
/**
* Note: this is private because no external caller should access DB rows directly.
* @param stdClass $row
* @return HistoryFilter
*/
private function filterFromHistoryRow( stdClass $row ): HistoryFilter {
$actionsRaw = unserialize( $row->afh_actions );
$actions = is_array( $actionsRaw ) ? $actionsRaw : [];
$flags = $row->afh_flags ? explode( ',', $row->afh_flags ) : [];
return new HistoryFilter(
new Specs(
trim( $row->afh_pattern ),
$row->afh_comments,
// FIXME: Make the DB field NOT NULL (T263324)
(string)$row->afh_public_comments,
array_keys( $actions ),
// FIXME Make the field NOT NULL and add default (T263324)
$row->afh_group ?? 'default'
),
new Flags(
in_array( 'enabled', $flags, true ),
in_array( 'deleted', $flags, true ),
$this->getPrivacyLevelFromFlags( $flags ),
in_array( 'global', $flags, true )
),
$actions,
new LastEditInfo(
(int)$row->afh_user,
$row->afh_user_text,
$row->afh_timestamp
),
(int)$row->afh_filter,
$row->afh_id
);
}
/**
* Note: this is private because no external caller should access DB rows directly.
* @param stdClass $row
* @param array[]|callable $actions
* @return ExistingFilter
*/
private function filterFromRow( stdClass $row, $actions ): ExistingFilter {
return new ExistingFilter(
new Specs(
trim( $row->af_pattern ),
// FIXME: Make the DB fields for these NOT NULL (T263324)
(string)$row->af_comments,
(string)$row->af_public_comments,
$row->af_actions !== '' ? explode( ',', $row->af_actions ) : [],
$row->af_group
),
new Flags(
(bool)$row->af_enabled,
(bool)$row->af_deleted,
(int)$row->af_hidden,
(bool)$row->af_global
),
$actions,
new LastEditInfo(
(int)$row->af_user,
$row->af_user_text,
$row->af_timestamp
),
(int)$row->af_id,
isset( $row->af_hit_count ) ? (int)$row->af_hit_count : null,
isset( $row->af_throttled ) ? (bool)$row->af_throttled : null
);
}
private function getAbuseFilterQueryBuilder( IReadableDatabase $dbr ): SelectQueryBuilder {
return $dbr->newSelectQueryBuilder()
->select( [
'af_id',
'af_pattern',
'af_timestamp',
'af_enabled',
'af_comments',
'af_public_comments',
'af_hidden',
'af_hit_count',
'af_throttled',
'af_deleted',
'af_actions',
'af_global',
'af_group',
'af_user' => 'actor_af_user.actor_user',
'af_user_text' => 'actor_af_user.actor_name',
'af_actor' => 'af_actor'
] )
->from( 'abuse_filter' )
->join( 'actor', 'actor_af_user', 'actor_af_user.actor_id = af_actor' );
}
private function getAbuseFilterHistoryQueryBuilder( IReadableDatabase $dbr ): SelectQueryBuilder {
return $dbr->newSelectQueryBuilder()
->select( [
'afh_id',
'afh_pattern',
'afh_timestamp',
'afh_filter',
'afh_comments',
'afh_public_comments',
'afh_flags',
'afh_actions',
'afh_group',
'afh_user' => 'actor_afh_user.actor_user',
'afh_user_text' => 'actor_afh_user.actor_name',
'afh_actor' => 'afh_actor'
] )
->from( 'abuse_filter_history' )
->join( 'actor', 'actor_afh_user', 'actor_afh_user.actor_id = afh_actor' );
}
/**
* @param int $filterID
* @param bool $global
* @return string
*/
private function getCacheKey( int $filterID, bool $global ): string {
return GlobalNameUtils::buildGlobalName( $filterID, $global );
}
/**
* "Hides" local filters when testing global ones, so that we can use the
* local database pretending it's not local.
* @codeCoverageIgnore
*/
public function hideLocalFiltersForTesting(): void {
if ( !defined( 'MW_PHPUNIT_TEST' ) ) {
throw new RuntimeException( 'Can only be called in tests' );
}
$this->localFiltersHiddenForTest = true;
}
}