mediawiki-extensions-AbuseF.../includes/Views
Daimona Eaytoy c8c66b55bc Two minor fixes to make code testable
Trying to write unit tests, there are some things in the code that make
it not well testable. Here, two of them are corrected:
1 - Use class constants instead of static variables inside a non-static
method. Otherwise such variables won't be reset between tests. The
change is made so that there'll be less impact on blame.
2 - Set af_enabled to true even in af_deleted is true as well. For three
reasons: the first is that we already perform validation for this, so no
need to secretly change the option to whatever we think would make
sense. Second, this redundant validation makes some tests fail. Third:
this way, if the user selects both enabled and deleted, when the warning
is shown he'll indeed see that both checkboxes are selected. Before, he
would only see wpFilterEnabled as selected.

Change-Id: Ib7a0335fa7fb3b8a21765438a720205656c1ea09
2018-07-05 00:07:46 +02:00
..
AbuseFilterView.php Make buildTestConditions more flexible 2018-06-26 00:45:33 +00:00
AbuseFilterViewDiff.php Merge "Use OOUI buttons instead of plain links and Html::errorbox for errors" 2018-05-03 00:41:21 +00:00
AbuseFilterViewEdit.php Two minor fixes to make code testable 2018-07-05 00:07:46 +02:00
AbuseFilterViewExamine.php Allow users with abusefilter-view-private to use testing interface 2018-06-24 14:10:38 +00:00
AbuseFilterViewHistory.php Add phan configuration 2018-04-30 08:32:58 +00:00
AbuseFilterViewImport.php Fix coding conventions exclusion rules 2018-04-20 08:40:18 +00:00
AbuseFilterViewList.php Reduce form whitespace on Special:AbuseFilter and compact variables 2018-06-19 12:13:29 +02:00
AbuseFilterViewRevert.php Add min and max date selectors to AbuseLog 2018-06-29 11:52:14 +02:00
AbuseFilterViewTestBatch.php Make /test filterable by action type 2018-06-26 00:48:09 +00:00
AbuseFilterViewTools.php Allow users with abusefilter-view-private to use testing interface 2018-06-24 14:10:38 +00:00