mediawiki-extensions-AbuseF.../includes/BlockedDomainFilter.php
Bartosz Dziewoński c458651370 Fix Status combining MessageSpecifier and parameters array
Constructing a Status like this does not make sense (and I want
to deprecate it in I0675e557bb93a1c990fa923c50b9f6ee8a9836c8),
because the parameters are ignored by most Status methods:

  $error = Message::newFromSpecifier( 'abusefilter-blocked-domains-attempted' );
  $status = Status::newFatal( $error, 'blockeddomain', 'blockeddomain' );

But it worked here, because FilteredActionsHandler::getApiStatus()
used a deprecated method that allowed inspecting them.

I feel like this code in BlockedDomainFilter has been added to make
the tests pass without thinking about what it actually does, which is
to output a bunch of useless incorrect data in API errors.

I'm not sure if we can remove that now without breaking API
compatibility, so add the useless data in FilteredActionsHandler
instead, closer to where it's output.

Change-Id: Ic12241bd3029bc1b0e7a0023689a2be35ccd30a8
2024-04-14 00:02:32 +00:00

146 lines
4.9 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
namespace MediaWiki\Extension\AbuseFilter;
use ExtensionRegistry;
use LogPage;
use ManualLogEntry;
use MediaWiki\CheckUser\Hooks as CUHooks;
use MediaWiki\Extension\AbuseFilter\Variables\UnsetVariableException;
use MediaWiki\Extension\AbuseFilter\Variables\VariableHolder;
use MediaWiki\Extension\AbuseFilter\Variables\VariablesManager;
use MediaWiki\Status\Status;
use MediaWiki\Title\Title;
use MediaWiki\User\User;
use Message;
/**
* Filters blocked domains
*
* @ingroup SpecialPage
*/
class BlockedDomainFilter {
public const SERVICE_NAME = 'AbuseFilterBlockedDomainFilter';
private VariablesManager $variablesManager;
private BlockedDomainStorage $blockedDomainStorage;
/**
* @param VariablesManager $variablesManager
* @param BlockedDomainStorage $blockedDomainStorage
*/
public function __construct(
VariablesManager $variablesManager,
BlockedDomainStorage $blockedDomainStorage
) {
$this->variablesManager = $variablesManager;
$this->blockedDomainStorage = $blockedDomainStorage;
}
/**
* @param VariableHolder $vars variables by the action
* @param User $user User that tried to add the domain, used for logging
* @param Title $title Title of the page that was attempted on, used for logging
* @return Status Error status if it's a match, good status if not
*/
public function filter( VariableHolder $vars, $user, $title ) {
global $wgAbuseFilterEnableBlockedExternalDomain;
$status = Status::newGood();
if ( !$wgAbuseFilterEnableBlockedExternalDomain ) {
return $status;
}
try {
$urls = $this->variablesManager->getVar( $vars, 'added_links', VariablesManager::GET_STRICT );
} catch ( UnsetVariableException $_ ) {
return $status;
}
$addedDomains = [];
foreach ( $urls->toArray() as $addedUrl ) {
$parsedHost = parse_url( (string)$addedUrl->getData(), PHP_URL_HOST );
if ( !is_string( $parsedHost ) ) {
continue;
}
// Given that we block subdomains of blocked domains too
// pretend that all of higher-level domains are added as well
// so for foo.bar.com, you will have three domains to check:
// foo.bar.com, bar.com, and com
// This saves string search in the large list of blocked domains
// making it much faster.
$domainString = '';
$domainPieces = array_reverse( explode( '.', strtolower( $parsedHost ) ) );
foreach ( $domainPieces as $domainPiece ) {
if ( !$domainString ) {
$domainString = $domainPiece;
} else {
$domainString = $domainPiece . '.' . $domainString;
}
// It should be a map, benchmark at https://phabricator.wikimedia.org/P48956
$addedDomains[$domainString] = true;
}
}
if ( !$addedDomains ) {
return $status;
}
$blockedDomains = $this->blockedDomainStorage->loadComputed();
$blockedDomainsAdded = array_intersect_key( $addedDomains, $blockedDomains );
if ( !$blockedDomainsAdded ) {
return $status;
}
$blockedDomainsAdded = array_keys( $blockedDomainsAdded );
$error = Message::newFromSpecifier( 'abusefilter-blocked-domains-attempted' );
$error->params( Message::listParam( $blockedDomainsAdded ) );
$status->fatal( $error );
$this->logFilterHit(
$user,
$title,
implode( ' ', $blockedDomainsAdded )
);
return $status;
}
/**
* Logs the filter hit to Special:Log
*
* @param User $user
* @param Title $title
* @param string $blockedDomain The blocked domain the user attempted to add
*/
private function logFilterHit( User $user, $title, $blockedDomain ) {
$logEntry = new ManualLogEntry( 'abusefilterblockeddomainhit', 'hit' );
$logEntry->setPerformer( $user );
$logEntry->setTarget( $title );
$logEntry->setParameters( [ '4::blocked' => $blockedDomain ] );
$logid = $logEntry->insert();
$log = new LogPage( 'abusefilterblockeddomainhit' );
if ( $log->isRestricted() ) {
// Make sure checkusers can see this action if the log is restricted
// (which is the default)
if ( ExtensionRegistry::getInstance()->isLoaded( 'CheckUser' ) ) {
$rc = $logEntry->getRecentChange( $logid );
CUHooks::updateCheckUserData( $rc );
}
} else {
// If the log is unrestricted, publish normally to RC,
// which will also update checkuser
$logEntry->publish( $logid, "rc" );
}
}
}