mediawiki-extensions-AbuseF.../tests/phpunit/AbuseFilterParserEquivsetTest.php
Daimona Eaytoy 472d1221bd tests: Increase and rebalance code coverage
Also fix a couple of broken tests in Consequences:
 - For createaccount, $user->addToDatabase must be called before
   testForAccountCreation, or it will throw a CannotCreateActorException.
 - In testThrottleLimit, also set wgAbuseFilterEmergencyDisableThreshold
   to avoid relying on the local config.

Bug: T201193
Change-Id: If1a50b0a729e4d554485f2e2225d5877510966b6
2020-02-07 18:32:17 +00:00

127 lines
3.6 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*
* @license GPL-2.0-or-later
*/
/**
* Tests that require Equivset, separated from the parser unit tests.
*
* @group Test
* @group AbuseFilter
* @group AbuseFilterParser
*
* @covers AbuseFilterCachingParser
* @covers AFPTreeParser
* @covers AFPTransitionBase
* @covers AFPTreeNode
* @covers AFPSyntaxTree
* @covers AFPParserState
* @covers AbuseFilterParser
* @covers AbuseFilterTokenizer
* @covers AFPToken
* @covers AFPData
*/
class AbuseFilterParserEquivsetTest extends MediaWikiIntegrationTestCase {
/**
* @see AbuseFilterParserTestCase::getParsers() - we cannot reuse that due to inheritance
* @return AbuseFilterParser[]
*/
protected function getParsers() {
static $parsers = null;
if ( !$parsers ) {
// We're not interested in caching or logging; tests should call respectively setCache
// and setLogger if they want to test any of those.
$contLang = new LanguageEn();
$cache = new EmptyBagOStuff();
$logger = new \Psr\Log\NullLogger();
$parser = new AbuseFilterParser( $contLang, $cache, $logger );
$parser->toggleConditionLimit( false );
$cachingParser = new AbuseFilterCachingParser( $contLang, $cache, $logger );
$cachingParser->toggleConditionLimit( false );
$parsers = [ $parser, $cachingParser ];
} else {
// Reset so that already executed tests don't influence new ones
$parsers[0]->resetState();
$parsers[0]->clearFuncCache();
$parsers[1]->resetState();
$parsers[1]->clearFuncCache();
}
return $parsers;
}
/**
* @param string $rule The rule to parse
* @dataProvider provideGenericTests
*/
public function testGeneric( $rule ) {
if ( !class_exists( 'Wikimedia\Equivset\Equivset' ) ) {
$this->markTestSkipped( 'Equivset is not installed' );
}
foreach ( $this->getParsers() as $parser ) {
$this->assertTrue( $parser->parse( $rule ), 'Parser used: ' . get_class( $parser ) );
}
}
/**
* @return Generator|array
*/
public function provideGenericTests() {
$testPath = __DIR__ . "/../parserTestsEquivset";
$testFiles = glob( $testPath . "/*.t" );
foreach ( $testFiles as $testFile ) {
$testName = basename( substr( $testFile, 0, -2 ) );
$rule = trim( file_get_contents( $testFile ) );
yield $testName => [ $rule ];
}
}
/**
* @param string $func
* @see AbuseFilterParserTest::testVariadicFuncsArbitraryArgsAllowed()
* @dataProvider variadicFuncs
*/
public function testVariadicFuncsArbitraryArgsAllowed( $func ) {
$argsList = str_repeat( ', "arg"', 50 );
$code = "$func( 'arg' $argsList )";
foreach ( $this->getParsers() as $parser ) {
$pname = get_class( $parser );
try {
$parser->parse( $code );
$this->assertTrue( true );
} catch ( AFPException $e ) {
$this->fail( "Got exception with parser $pname.\n$e" );
}
}
}
/**
* @return array
*/
public function variadicFuncs() {
return [
[ 'ccnorm_contains_any' ],
[ 'ccnorm_contains_all' ],
];
}
}