Go to file
Matěj Suchánek b7cda4de4c Prevent cache pollution in fetchAllTags and clean up
Previously, the cached value would depend on the tags
parameter to be updated. The provided value may be
different for each call, so callers may receive
unexpected values.

For example, while core usually calls this with core-defined
hooks, our method AbuseFilter::isAllowedTag calls this
providing an empty array. If core's call happened shortly
after ours and hit cache, its array would be overwritten
with only AbuseFilter's tags, the rest would be lost.

Also do some clean up:

- only call array_filter on explode'd array
- call array_unique on the value, since it's usual that
  multiple filters share the same tag

Noticed when thinking about moving this to a service.

Change-Id: I4f4322e80ec89e48458a3bf46a1146863bec8237
2020-10-07 15:20:41 +02:00
.phan Integrate with Renameuser 2020-10-01 08:10:22 +00:00
db_patches Merge "Actually apply patch-afl_change_deleted_patrolled." 2020-10-05 08:15:48 +00:00
i18n Localisation updates from https://translatewiki.net. 2020-10-07 08:34:11 +02:00
includes Prevent cache pollution in fetchAllTags and clean up 2020-10-07 15:20:41 +02:00
maintenance updateVarDumps: avoid using services in the constructor 2020-10-03 23:23:37 +00:00
modules Merge "ext.abuseFilter.edit.js - minor cleanup" 2020-09-30 09:30:14 +00:00
tests Merge "Use triple equals in abuse filter parser tests" 2020-10-06 17:42:29 +00:00
.eslintrc.json eslint config tweaks 2020-06-09 19:39:03 +01:00
.gitignore Add config for Selenium and basic tests 2019-09-17 16:23:07 +00:00
.gitreview
.phpcs.xml Fix remaining PHPCS issues 2020-01-21 12:36:37 +00:00
.stylelintrc.json
AbuseFilter.alias.php Add aliases for Serbian language 2018-12-24 02:16:55 +00:00
abusefilter.tables.pg.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sqlite.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 2018-09-01 05:29:54 +00:00
composer.json build: Updating mediawiki/mediawiki-phan-config to 0.10.3 2020-09-24 18:26:44 +00:00
COPYING
extension.json Add test traits for uploads and account creation 2020-10-04 13:16:58 +00:00
Gruntfile.js eslint config tweaks 2020-06-09 19:39:03 +01:00
hooks.txt Introduce a KeywordsManager service 2020-09-28 23:03:52 +00:00
package-lock.json build: Updating bl to 4.0.3 2020-09-09 18:15:30 +00:00
package.json build: Updating npm dependencies 2020-09-03 09:31:08 +00:00