mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-12-01 17:16:23 +00:00
ab2ad164ff
Add a lot more unit tests, improve code testability, remove duplicated integration tests. Change-Id: Id8c9266ae107217047f267296070f26f575889d1
140 lines
3.4 KiB
PHP
140 lines
3.4 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Block\BlockUser;
|
|
use MediaWiki\Block\BlockUserFactory;
|
|
use MediaWiki\Extension\AbuseFilter\Consequences\Consequence\RangeBlock;
|
|
use MediaWiki\Extension\AbuseFilter\Consequences\Parameters;
|
|
use MediaWiki\Extension\AbuseFilter\FilterUser;
|
|
use MediaWiki\User\UserIdentityValue;
|
|
|
|
/**
|
|
* @coversDefaultClass \MediaWiki\Extension\AbuseFilter\Consequences\Consequence\RangeBlock
|
|
* @covers \MediaWiki\Extension\AbuseFilter\Consequences\Consequence\BlockingConsequence
|
|
* @todo Make this a unit test once T266409 is resolved
|
|
*/
|
|
class RangeBlockTest extends MediaWikiIntegrationTestCase {
|
|
use ConsequenceGetMessageTestTrait;
|
|
|
|
private const CIDR_LIMIT = [
|
|
'IPv4' => 16,
|
|
'IPv6' => 19,
|
|
];
|
|
|
|
private function getMsgLocalizer() : MessageLocalizer {
|
|
$ml = $this->createMock( MessageLocalizer::class );
|
|
$ml->method( 'msg' )->willReturnCallback( function ( $k, $p ) {
|
|
return $this->getMockMessage( $k, $p );
|
|
} );
|
|
return $ml;
|
|
}
|
|
|
|
private function getFilterUser() : FilterUser {
|
|
$filterUser = $this->createMock( FilterUser::class );
|
|
$filterUser->method( 'getUser' )
|
|
->willReturn( new UserIdentityValue( 2, 'FilterUser', 3 ) );
|
|
return $filterUser;
|
|
}
|
|
|
|
public function provideExecute() : iterable {
|
|
yield 'IPv4 range block' => [
|
|
'1.2.3.4',
|
|
[
|
|
'IPv4' => 16,
|
|
'IPv6' => 18,
|
|
],
|
|
'1.2.0.0/16',
|
|
true
|
|
];
|
|
yield 'IPv6 range block' => [
|
|
// random IP from https://en.wikipedia.org/w/index.php?title=IPv6&oldid=989727833
|
|
'2001:0db8:0000:0000:0000:ff00:0042:8329',
|
|
[
|
|
'IPv4' => 15,
|
|
'IPv6' => 19,
|
|
],
|
|
'2001:0:0:0:0:0:0:0/19',
|
|
true
|
|
];
|
|
yield 'IPv4 range block constrained by core limits' => [
|
|
'1.2.3.4',
|
|
[
|
|
'IPv4' => 15,
|
|
'IPv6' => 19,
|
|
],
|
|
'1.2.0.0/16',
|
|
true
|
|
];
|
|
yield 'IPv6 range block constrained by core limits' => [
|
|
'2001:0db8:0000:0000:0000:ff00:0042:8329',
|
|
[
|
|
'IPv4' => 16,
|
|
'IPv6' => 18,
|
|
],
|
|
'2001:0:0:0:0:0:0:0/19',
|
|
true
|
|
];
|
|
yield 'failure' => [
|
|
'1.2.3.4',
|
|
self::CIDR_LIMIT,
|
|
'1.2.0.0/16',
|
|
false
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideExecute
|
|
* @covers ::__construct
|
|
* @covers ::execute
|
|
*/
|
|
public function testExecute(
|
|
string $requestIP, array $rangeBlockSize, string $target, bool $result
|
|
) {
|
|
$params = $this->provideGetMessageParameters()->current()[0];
|
|
$blockUser = $this->createMock( BlockUser::class );
|
|
$blockUser->expects( $this->once() )
|
|
->method( 'placeBlockUnsafe' )
|
|
->willReturn( $result ? Status::newGood() : Status::newFatal( 'error' ) );
|
|
$blockUserFactory = $this->createMock( BlockUserFactory::class );
|
|
$blockUserFactory->expects( $this->once() )
|
|
->method( 'newBlockUser' )
|
|
->with(
|
|
$target,
|
|
$this->anything(),
|
|
'1 week',
|
|
$this->anything(),
|
|
$this->anything()
|
|
)
|
|
->willReturn( $blockUser );
|
|
|
|
$rangeBlock = new RangeBlock(
|
|
$params,
|
|
'1 week',
|
|
$blockUserFactory,
|
|
$this->getFilterUser(),
|
|
$this->getMsgLocalizer(),
|
|
$rangeBlockSize,
|
|
self::CIDR_LIMIT,
|
|
$requestIP
|
|
);
|
|
$this->assertSame( $result, $rangeBlock->execute() );
|
|
}
|
|
|
|
/**
|
|
* @covers ::getMessage
|
|
* @dataProvider provideGetMessageParameters
|
|
*/
|
|
public function testGetMessage( Parameters $params ) {
|
|
$rangeBlock = new RangeBlock(
|
|
$params,
|
|
'0',
|
|
$this->createMock( BlockUserFactory::class ),
|
|
$this->createMock( FilterUser::class ),
|
|
$this->getMsgLocalizer(),
|
|
[ 'IPv6' => 24, 'IPv4' => 24 ],
|
|
self::CIDR_LIMIT,
|
|
'1.1.1.1'
|
|
);
|
|
$this->doTestGetMessage( $rangeBlock, $params, 'abusefilter-blocked-display' );
|
|
}
|
|
}
|