mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-09-24 10:48:17 +00:00
904d9cddbb
The consequence-taking logic is moved away from AbuseFilterRunner, to dedicated classes. There's now one class per consequence, encapsulating everything it needs to take the consequence. Several interfaces allow customizing different types of consequences. Every "special check" in AbuseFilter was generalized to use these interfaces, rather than knowing how to handle each consequence. Adding more consequences from other extensions will also be easier, and it should happen via a hook (not a global), returning a class that implements Consequence. The BCConsequence class was temporarily added for legacy custom consequences. A ConsequenceFactory class is added to instantiate consequences; this would possibly benefit from using ObjectFactory, but it doesn't because it would also reduce readability (although we might do that in the future). These classes are still not covered by unit tests, and this is left to do for later. The new unit tests should mostly replace AbuseFilterConsequencesTest. @covers tag were added to keep the status quo (i.e. code that was considered covered while in AbuseFilterRunner will still be considered covered), although we'll have to adjust them. Change-Id: Ia1a9a8bbf55ddd875dfd5bbc55fcd612cff568ef |
||
|---|---|---|
| .. | ||
| api | ||
| Consequence | ||
| Filter | ||
| Hooks | ||
| LogFormatter | ||
| pagers | ||
| parser | ||
| ParserNS | ||
| special | ||
| VariableGenerator | ||
| Views | ||
| Watcher | ||
| AbuseFilter.php | ||
| AbuseFilterChangesList.php | ||
| AbuseFilterHooks.php | ||
| AbuseFilterPermissionManager.php | ||
| AbuseFilterPreAuthenticationProvider.php | ||
| AbuseFilterRunner.php | ||
| AbuseFilterServices.php | ||
| AbuseFilterVariableHolder.php | ||
| AFComputedVariable.php | ||
| BlockAutopromoteStore.php | ||
| CentralDBManager.php | ||
| CentralDBNotAvailableException.php | ||
| ChangeTagger.php | ||
| ChangeTagsManager.php | ||
| ConsequencesFactory.php | ||
| FilterCompare.php | ||
| FilterImporter.php | ||
| FilterLookup.php | ||
| FilterProfiler.php | ||
| FilterStore.php | ||
| FilterUser.php | ||
| FilterValidator.php | ||
| InvalidImportDataException.php | ||
| KeywordsManager.php | ||
| ServiceWiring.php | ||
| TableDiffFormatterFullContext.php | ||