mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-29 08:14:42 +00:00
2793e7f1cf
Introduce ReversibleConsequence interface for Consequence classes whose potentially destructive actions can be reverted using Special:AbuseFilter/revert. This allows moving reverting logic from AbuseFilterViewRevert to individual Consequence classes and testing. Unfortunately, the code is definitely not very clean now. Change-Id: I558da711f1645ccf64792c6102cf743827171320
176 lines
5.2 KiB
PHP
176 lines
5.2 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Extension\AbuseFilter\AbuseFilterServices;
|
|
use MediaWiki\Extension\AbuseFilter\Consequences\Consequence\Degroup;
|
|
use MediaWiki\Extension\AbuseFilter\Consequences\Parameters;
|
|
use MediaWiki\Extension\AbuseFilter\Filter\MutableFilter;
|
|
use MediaWiki\Extension\AbuseFilter\FilterUser;
|
|
use MediaWiki\Extension\AbuseFilter\KeywordsManager;
|
|
use MediaWiki\Linker\LinkTarget;
|
|
use MediaWiki\User\UserGroupManager;
|
|
use MediaWiki\User\UserIdentity;
|
|
use MediaWiki\User\UserIdentityValue;
|
|
|
|
/**
|
|
* @coversDefaultClass \MediaWiki\Extension\AbuseFilter\Consequences\Consequence\Degroup
|
|
* @covers ::__construct
|
|
*/
|
|
class DegroupTest extends MediaWikiIntegrationTestCase {
|
|
|
|
private function getParameters( UserIdentity $user ) : Parameters {
|
|
$filter = MutableFilter::newDefault();
|
|
$filter->setID( 1 );
|
|
$filter->setName( 'Degrouping filter' );
|
|
return new Parameters(
|
|
$filter,
|
|
false,
|
|
$user,
|
|
$this->createMock( LinkTarget::class ),
|
|
'edit'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @covers ::execute
|
|
*/
|
|
public function testExecute() {
|
|
$user = new UserIdentityValue( 1, 'Degrouped user', 2 );
|
|
$params = $this->getParameters( $user );
|
|
$userGroupManager = $this->createMock( UserGroupManager::class );
|
|
$userGroupManager->method( 'listAllImplicitGroups' )
|
|
->willReturn( [ '*', 'user' ] );
|
|
$userGroupManager->expects( $this->once() )
|
|
->method( 'removeUserFromGroup' )
|
|
->with( $user, 'sysop' );
|
|
$filterUser = AbuseFilterServices::getFilterUser();
|
|
|
|
$degroup = new Degroup(
|
|
$params,
|
|
AbuseFilterVariableHolder::newFromArray(
|
|
[ 'user_groups' => [ '*', 'user', 'sysop' ] ],
|
|
$this->createMock( KeywordsManager::class )
|
|
),
|
|
$userGroupManager,
|
|
$filterUser
|
|
);
|
|
$this->assertTrue( $degroup->execute() );
|
|
}
|
|
|
|
/**
|
|
* @covers ::execute
|
|
*/
|
|
public function testExecute_noGroups() {
|
|
$user = new UserIdentityValue( 1, 'Degrouped user', 2 );
|
|
$params = $this->getParameters( $user );
|
|
$userGroupManager = $this->createMock( UserGroupManager::class );
|
|
$userGroupManager->method( 'listAllImplicitGroups' )
|
|
->willReturn( [ '*', 'user' ] );
|
|
$userGroupManager->expects( $this->never() )
|
|
->method( 'removeUserFromGroup' );
|
|
|
|
$degroup = new Degroup(
|
|
$params,
|
|
AbuseFilterVariableHolder::newFromArray(
|
|
[ 'user_groups' => [ '*', 'user' ] ],
|
|
$this->createMock( KeywordsManager::class )
|
|
),
|
|
$userGroupManager,
|
|
$this->createMock( FilterUser::class )
|
|
);
|
|
$this->assertFalse( $degroup->execute() );
|
|
}
|
|
|
|
/**
|
|
* @covers ::execute
|
|
*/
|
|
public function testExecute_variableNotSet() {
|
|
$user = new UserIdentityValue( 1, 'Degrouped user', 2 );
|
|
$params = $this->getParameters( $user );
|
|
$userGroupManager = $this->createMock( UserGroupManager::class );
|
|
$userGroupManager->method( 'listAllImplicitGroups' )
|
|
->willReturn( [ '*', 'user' ] );
|
|
$userGroupManager->method( 'getUserEffectiveGroups' )
|
|
->with( $user )
|
|
->willReturn( [ '*', 'user', 'sysop' ] );
|
|
$userGroupManager->expects( $this->once() )
|
|
->method( 'removeUserFromGroup' )
|
|
->with( $user, 'sysop' );
|
|
$filterUser = AbuseFilterServices::getFilterUser();
|
|
|
|
$degroup = new Degroup(
|
|
$params,
|
|
new AbuseFilterVariableHolder( $this->createMock( KeywordsManager::class ) ),
|
|
$userGroupManager,
|
|
$filterUser
|
|
);
|
|
$this->assertTrue( $degroup->execute() );
|
|
}
|
|
|
|
/**
|
|
* @covers ::execute
|
|
*/
|
|
public function testExecute_anonymous() {
|
|
$user = new UserIdentityValue( 0, 'Anonymous user', 1 );
|
|
$params = $this->getParameters( $user );
|
|
$userGroupManager = $this->createMock( UserGroupManager::class );
|
|
$userGroupManager->expects( $this->never() )->method( $this->anything() );
|
|
$filterUser = $this->createMock( FilterUser::class );
|
|
$filterUser->expects( $this->never() )->method( $this->anything() );
|
|
|
|
$degroup = new Degroup(
|
|
$params,
|
|
$this->createMock( AbuseFilterVariableHolder::class ),
|
|
$userGroupManager,
|
|
$filterUser
|
|
);
|
|
$this->assertFalse( $degroup->execute() );
|
|
}
|
|
|
|
public function provideRevert() : array {
|
|
return [
|
|
[ true, [ '*', 'user', 'sysop' ] ],
|
|
[ true, [ '*', 'user', 'canceled', 'sysop' ] ],
|
|
[ false, [ '*', 'user', 'sysop' ], [ 'sysop' ] ],
|
|
[ false, [ '*', 'user', 'canceled' ] ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers ::revert
|
|
* @dataProvider provideRevert
|
|
*/
|
|
public function testRevert( bool $success, array $hadGroups, array $hasGroups = [] ) {
|
|
$user = new UserIdentityValue( 1, 'Degrouped user', 2 );
|
|
$params = $this->getParameters( $user );
|
|
$userGroupManager = $this->createMock( UserGroupManager::class );
|
|
$userGroupManager->method( 'listAllImplicitGroups' )
|
|
->willReturn( [ '*', 'user' ] );
|
|
$userGroupManager->method( 'getUserGroups' )
|
|
->with( $user )
|
|
->willReturn( $hasGroups );
|
|
$userGroupManager->method( 'addUserToGroup' )
|
|
->willReturnCallback( function ( $_, $group ) use ( $hasGroups ) {
|
|
return $group === 'sysop';
|
|
} );
|
|
$degroup = new Degroup(
|
|
$params,
|
|
new AbuseFilterVariableHolder( $this->createMock( KeywordsManager::class ) ),
|
|
$userGroupManager,
|
|
$this->createMock( FilterUser::class )
|
|
);
|
|
|
|
$info = [
|
|
'vars' => AbuseFilterVariableHolder::newFromArray(
|
|
[ 'user_groups' => $hadGroups ],
|
|
$this->createMock( KeywordsManager::class )
|
|
)
|
|
];
|
|
$performer = $this->getTestUser()->getUser();
|
|
$this->assertSame(
|
|
$success,
|
|
$degroup->revert( $info, $performer, 'reason' )
|
|
);
|
|
}
|
|
|
|
}
|