Daimona Eaytoy 6ac574dada Add missing permission check to canSeeLogDetailsForFilter ... `canSeeLogDetails` should also be checked when a filter is protected, as it is the base right for being able to see abuselog entries. With this in mind, check that immediately at the beginning of the method, instead of repeating calls. Also merge the conditionals, and return early when a permission check fails. Move a test up so that it comes immediately after its data provider, and add test cases for a few combinations of rights. Change-Id: Ic3cf58f43803bef8bf2d65566434baff145b3fd5		2024-07-02 22:43:09 +02:00
..
Api	Remove AbuseFilterActorMigration	2024-06-15 09:42:27 +02:00
ChangeTags	Support more log actions in testing interface	2024-06-19 17:35:43 +02:00
Consequences	Use StatusValue::getMessages() instead of deprecated methods	2024-05-28 21:04:59 +00:00
EditBox	Use namespaced classes	2024-06-12 20:01:35 +02:00
Filter	Allow variables to be restricted by user right	2024-06-04 06:54:53 -07:00
Hooks	Remove unused phan suppressions	2024-06-28 12:15:49 +02:00
LogFormatter	Use namespaced classes	2024-06-12 20:01:35 +02:00
Pager	Remove AbuseFilterActorMigration	2024-06-15 09:42:27 +02:00
Parser	Use namespaced classes	2024-06-12 20:01:35 +02:00
Special	Merge "Add protected variable view permission checks"	2024-06-13 13:18:14 +00:00
VariableGenerator	Support more log actions in testing interface	2024-06-19 17:35:43 +02:00
Variables	Fix variable descriptions showing raw "($1)"	2024-06-16 22:11:08 +02:00
View	Support more log actions in testing interface	2024-06-19 17:35:43 +02:00
Watcher	Migrate to IDatabase::newUpdateQueryBuilder	2024-04-15 23:07:44 +02:00
AbuseFilter.php	Use actor table in AbuseFilter	2023-03-22 14:01:29 +01:00
AbuseFilterChangesList.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
AbuseFilterPermissionManager.php	Add missing permission check to canSeeLogDetailsForFilter	2024-07-02 22:43:09 +02:00
AbuseFilterPreAuthenticationProvider.php	Use namespaced classes	2023-12-10 23:03:12 +01:00
AbuseFilterServices.php	Remove AbuseFilterActorMigration	2024-06-15 09:42:27 +02:00
AbuseLogger.php	Remove modification of wgCheckUserLogAdditionalRights	2024-06-27 16:43:25 +00:00
AbuseLoggerFactory.php	Use namespaced classes	2023-12-10 23:03:12 +01:00
ActionSpecifier.php
BlockAutopromoteStore.php	Use namespaced classes	2023-12-10 23:03:12 +01:00
BlockedDomainFilter.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
BlockedDomainStorage.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
CentralDBManager.php	Fix various typos and documentation issues	2023-09-04 12:55:17 +02:00
CentralDBNotAvailableException.php
EchoNotifier.php	Use namespaced Title	2023-08-19 19:49:36 +02:00
EditRevUpdater.php	Migrate to IDatabase::newUpdateQueryBuilder	2024-04-15 23:07:44 +02:00
EditStashCache.php	Add new variable for last edit time	2024-04-10 23:12:45 +00:00
EmergencyCache.php
FilterCompare.php	Convert af_hidden into a bitmask	2024-05-28 00:59:08 -07:00
FilterImporter.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
FilterLookup.php	Allow variables to be restricted by user right	2024-06-04 06:54:53 -07:00
FilterProfiler.php	build: Updating mediawiki/mediawiki-codesniffer to 43.0.0	2024-03-16 18:53:05 +00:00
FilterRunner.php	Use namespaced classes	2023-12-10 23:03:12 +01:00
FilterRunnerFactory.php	Use namespaced classes	2023-12-10 23:03:12 +01:00
FilterStore.php	Remove AbuseFilterActorMigration	2024-06-15 09:42:27 +02:00
FilterUser.php	Don't attempt to steal or create the FilterUser in CheckUserHandler	2024-01-31 19:32:52 +00:00
FilterUtils.php	Allow variables to be restricted by user right	2024-06-04 06:54:53 -07:00
FilterValidator.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
GlobalNameUtils.php
InvalidImportDataException.php
KeywordsManager.php	Add user_unnamed_ip variable	2024-05-23 07:19:48 -07:00
RunnerData.php
ServiceWiring.php	Remove AbuseFilterActorMigration	2024-06-15 09:42:27 +02:00
SpecsFormatter.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
TableDiffFormatterFullContext.php	Use the new Wikimedia\Diff namespace	2023-06-29 11:56:13 +10:00
TextExtractor.php	Use namespaced classes	2024-06-12 20:01:35 +02:00
ThrottleFilterPresentationModel.php	Use namespaced classes	2024-06-12 20:01:35 +02:00