Daimona Eaytoy 416dcd9ba3 Simplify ViewEdit, round 2 ... - Add a helper method to output an unrecoverable error, comprising a button to go back to the filters list; - Move the token check to attemptSave, so to make the conditionals easier to read, and group errors together - Make buildFilterEditor take an HTML parameter for the error, so the caller can specify whether it's error or warning - Move the check for non-existing filters out of buildFilterEditor - Add a bunch of typehints - Don't set af_throttled and af_hit_count in the empty row template, but set af_deleted (these are only used in buildFilterEditor) - Make AbuseFilter::translateFromHistory consistently include the af_global property (previously it would only be set for global filters; this error was introduced when first implementing global filters) - The only user-facing change is that, when trying to use a custom warning/disallow message on a global filter, this is now considered a non-fatal error, so we now show the editing interface (and not just an unrecoverable error). The next step is resolving the @todo in buildFilterEditor about null checks. Change-Id: I9d217dcac3f4cc0b26e53eca735cc327d5efc76d		2020-10-23 13:00:43 +00:00
..
AbuseFilterView.php	Avoid direct coupling between SpecialAbuseFilter and AbuseFilterView	2020-10-17 00:37:11 +02:00
AbuseFilterViewDiff.php	Clean up view classes	2020-10-13 10:38:43 +02:00
AbuseFilterViewEdit.php	Simplify ViewEdit, round 2	2020-10-23 13:00:43 +00:00
AbuseFilterViewExamine.php	Add an AbuseFilterPermissionManager service	2020-10-10 14:03:29 +02:00
AbuseFilterViewHistory.php	Avoid direct coupling between SpecialAbuseFilter and AbuseFilterView	2020-10-17 00:37:11 +02:00
AbuseFilterViewImport.php	Add an AbuseFilterPermissionManager service	2020-10-10 14:03:29 +02:00
AbuseFilterViewList.php	Prevent uncaught warnings/exception on Special:AbuseFilter	2020-10-20 13:59:45 +02:00
AbuseFilterViewRevert.php	Clean up view classes	2020-10-13 10:38:43 +02:00
AbuseFilterViewTestBatch.php	Add an AbuseFilterPermissionManager service	2020-10-10 14:03:29 +02:00
AbuseFilterViewTools.php	Add an AbuseFilterPermissionManager service	2020-10-10 14:03:29 +02:00