mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-23 21:53:35 +00:00
30227231f6
A filter using a protected variable can be loaded via filter id
using testing tools even though the user might not have the right
to view protected variables. This can potentially leak PII and as
such, testing tools should check for the right before allowing
protected filters to be seen.
- Unload a filter asap if it uses protected variables and the
requestor doesn't have viewing rights. This:
+ disallows loading of existing protected filters on page load
+ disallows testing against rules that use protected variables
+ disallows subsequent requests for protected filters (via API)
There is a known bug (see T369620) where no user feedback is
provided if an API request for a filter returns no result (typically
when no filter matches the requested id). This commit adds another
pathway to that bug (the filter exists but is protected and not
returned by the API) but does not update this UI/UX.
Bug: T364834
Change-Id: I6a572790edd743596d70c9c4a2ee52b4561e25f3
|
||
|---|---|---|
| .. | ||
| Api | ||
| ChangeTags | ||
| Consequences | ||
| EditBox | ||
| Filter | ||
| Hooks | ||
| LogFormatter | ||
| Pager | ||
| Parser | ||
| Special | ||
| VariableGenerator | ||
| Variables | ||
| View | ||
| Watcher | ||
| AbuseFilter.php | ||
| AbuseFilterChangesList.php | ||
| AbuseFilterPermissionManager.php | ||
| AbuseFilterPreAuthenticationProvider.php | ||
| AbuseFilterServices.php | ||
| AbuseLogger.php | ||
| AbuseLoggerFactory.php | ||
| ActionSpecifier.php | ||
| BlockAutopromoteStore.php | ||
| BlockedDomainFilter.php | ||
| BlockedDomainStorage.php | ||
| CentralDBManager.php | ||
| CentralDBNotAvailableException.php | ||
| EchoNotifier.php | ||
| EditRevUpdater.php | ||
| EditStashCache.php | ||
| EmergencyCache.php | ||
| FilterCompare.php | ||
| FilterImporter.php | ||
| FilterLookup.php | ||
| FilterProfiler.php | ||
| FilterRunner.php | ||
| FilterRunnerFactory.php | ||
| FilterStore.php | ||
| FilterUser.php | ||
| FilterUtils.php | ||
| FilterValidator.php | ||
| GlobalNameUtils.php | ||
| InvalidImportDataException.php | ||
| KeywordsManager.php | ||
| RunnerData.php | ||
| ServiceWiring.php | ||
| SpecsFormatter.php | ||
| TableDiffFormatterFullContext.php | ||
| TextExtractor.php | ||
| ThrottleFilterPresentationModel.php | ||