Go to file
Daimona Eaytoy 215f16a177 Prevent uncaught warnings/exception on Special:AbuseFilter
This patch addresses two issues observed in WMF production:
 - Specifying a search mode without a search pattern would result in a
   call to mb_stripos (in AbuseFilterPager) with an empty delimiter,
   which triggers a PHP warning. Avoid this by checking that the search
   pattern is not the empty string, and unset the search mode if that's
   the case.
 - Trying to use an invalid search mode would result in an unhandled
   LogicException. We have some code in place to check the validity of
   the URL parameter, but the relevant code didn't reset the search mode
   to null, hence AbuseFilterPager would throw before we can show a
   pretty error to the user.

Bug: T265994
Change-Id: Ib19d36d6265981097bbb551783fdac8bdaa98854
2020-10-20 13:59:45 +02:00
.phan Integrate with Renameuser 2020-10-01 08:10:22 +00:00
db_patches Merge "Actually apply patch-afl_change_deleted_patrolled." 2020-10-05 08:15:48 +00:00
i18n Localisation updates from https://translatewiki.net. 2020-10-20 08:28:55 +02:00
includes Prevent uncaught warnings/exception on Special:AbuseFilter 2020-10-20 13:59:45 +02:00
maintenance Merge "Minor updates related to var dumps" 2020-10-19 08:27:05 +00:00
modules Merge "ViewEdit: avoid linebreaks in form labels" 2020-10-14 15:29:02 +00:00
tests Cleanup filter id handling on Special:AbuseFilter/history 2020-10-10 11:40:46 +00:00
.eslintrc.json eslint config tweaks 2020-06-09 19:39:03 +01:00
.gitignore Add config for Selenium and basic tests 2019-09-17 16:23:07 +00:00
.gitreview Whoops, track not trace 2016-10-24 17:01:30 -07:00
.phpcs.xml Fix remaining PHPCS issues 2020-01-21 12:36:37 +00:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-10 21:00:53 +00:00
AbuseFilter.alias.php Add aliases for Serbian language 2018-12-24 02:16:55 +00:00
abusefilter.tables.pg.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sqlite.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 2018-09-01 05:29:54 +00:00
composer.json build: Updating mediawiki/mediawiki-phan-config to 0.10.3 2020-09-24 18:26:44 +00:00
COPYING
extension.json Use new services in AbuseFilterRunner 2020-10-14 23:08:32 +00:00
Gruntfile.js eslint config tweaks 2020-06-09 19:39:03 +01:00
hooks.txt Update reference to core hooks documentation 2020-10-14 22:09:15 +00:00
package-lock.json build: Updating bl to 4.0.3 2020-09-09 18:15:30 +00:00
package.json build: Updating npm dependencies 2020-09-03 09:31:08 +00:00