mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-12 00:38:23 +00:00
215f16a177
This patch addresses two issues observed in WMF production: - Specifying a search mode without a search pattern would result in a call to mb_stripos (in AbuseFilterPager) with an empty delimiter, which triggers a PHP warning. Avoid this by checking that the search pattern is not the empty string, and unset the search mode if that's the case. - Trying to use an invalid search mode would result in an unhandled LogicException. We have some code in place to check the validity of the URL parameter, but the relevant code didn't reset the search mode to null, hence AbuseFilterPager would throw before we can show a pretty error to the user. Bug: T265994 Change-Id: Ib19d36d6265981097bbb551783fdac8bdaa98854 |
||
|---|---|---|
| .phan | ||
| db_patches | ||
| i18n | ||
| includes | ||
| maintenance | ||
| modules | ||
| tests | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| AbuseFilter.alias.php | ||
| abusefilter.tables.pg.sql | ||
| abusefilter.tables.sql | ||
| abusefilter.tables.sqlite.sql | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| extension.json | ||
| Gruntfile.js | ||
| hooks.txt | ||
| package-lock.json | ||
| package.json | ||