mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-15 10:15:24 +00:00
11d922d1bd
Copying my investigation from I8c93e2ae7e7bd4fc561c5e8490ed2feb1ef0edc2:
This code was introduced in 2009, see rEABF0f1eb8db78bfa83ddb93427f39aad619523d8f25:
$display = wfMsg( "abusefilter-action-$action" );
$display = wfEmptyMsg( "abusefilter-action-$action", $display ) ? $action : $display;
And wfEmptyMsg looked like this:
function wfEmptyMsg( $msg, $wfMsgOut ) {
return $wfMsgOut === htmlspecialchars( "<$msg>" );
}
so this made sense. But then, in 2010 (rMWae3ced88e535c7fd046f0ad6f0710cc87f0004ea) the function was changed:
function wfEmptyMsg( $key ) {
global $wgMessageCache;
return $wgMessageCache->get( $key ) === false;
}
without anyone removing the parameter from AbuseFilter.
Finally, in 2012 (rEABF176227e721c9475de2c2163d3b6e20ca4769c406) the usage of wfEmptyMsg was removed, and $display became a parameter to wfMessage().
Long story short, no need to pass that parameter.
Change-Id: Iad875f0c0ab5aaa06c795232638f52e9ca62786e
|
||
|---|---|---|
| .. | ||
| api | ||
| Hooks | ||
| pagers | ||
| parser | ||
| special | ||
| VariableGenerator | ||
| Views | ||
| AbuseFilter.php | ||
| AbuseFilterChangesList.php | ||
| AbuseFilterHooks.php | ||
| AbuseFilterModifyLogFormatter.php | ||
| AbuseFilterPreAuthenticationProvider.php | ||
| AbuseFilterRightsLogFormatter.php | ||
| AbuseFilterRunner.php | ||
| AbuseFilterServices.php | ||
| AbuseFilterSuppressLogFormatter.php | ||
| AbuseFilterVariableHolder.php | ||
| AbuseLogHitFormatter.php | ||
| AFComputedVariable.php | ||
| KeywordsManager.php | ||
| ServiceWiring.php | ||
| TableDiffFormatterFullContext.php | ||