mediawiki-extensions-AbuseF.../includes/Filter/AbstractFilter.php
STran bf28dbce0e Allow variables to be restricted by user right
Some exposed variables (eg. `user_ip`) used in filters are sensitive
and need to only be available to restricted groups of users.

Back-end changes:
- Add `AbuseFilterProtectedVariables` which defines what variables are
  protected by the new right `abusefilter-access-protected-vars`
- Add the concept of a `protected` variable, the use of which will
  denote the entire filter as protected via a flag on `af_hidden`

New UX features:
- Display changes to the protected status of filters on history and diff
  pages
- Check for protected variables and the right to see them in filter
  validation and don't allow a filter to be saved if it uses a variable
  that the user doesn't have access to
- Check for the right to view protected variables before allowing access
  and edits to existing filters that use them

Bug: T364465
Bug: T363906
Change-Id: I828bbb4015e87040f69a8e10c7888273c4f24dd3
2024-06-04 06:54:53 -07:00

169 lines
3.3 KiB
PHP

<?php
namespace MediaWiki\Extension\AbuseFilter\Filter;
use Wikimedia\Assert\Assert;
/**
* Immutable value object that represents a single filter. This object can be used to represent
* filters that do not necessarily exist in the database. You'll usually want to use subclasses.
*/
class AbstractFilter {
/** @var Specs */
protected $specs;
/** @var Flags */
protected $flags;
/**
* @var array[]|null Actions and parameters, can be lazy-loaded with $actionsCallback
*/
protected $actions;
/**
* @var callable|null
* @todo Evaluate whether this can be avoided, e.g. by using a JOIN. This property also makes
* the class not serializable.
*/
protected $actionsCallback;
/**
* @param Specs $specs
* @param Flags $flags
* @param callable|array[] $actions Array with params or callable that will return them
* @phan-param array[]|callable():array[] $actions
*/
public function __construct(
Specs $specs,
Flags $flags,
$actions
) {
$this->specs = clone $specs;
$this->flags = clone $flags;
Assert::parameterType( 'callable|array', $actions, '$actions' );
if ( is_callable( $actions ) ) {
$this->actionsCallback = $actions;
} elseif ( is_array( $actions ) ) {
$this->setActions( $actions );
}
}
/**
* @return Specs
*/
public function getSpecs(): Specs {
return clone $this->specs;
}
/**
* @return Flags
*/
public function getFlags(): Flags {
return clone $this->flags;
}
/**
* @return string
*/
public function getRules(): string {
return $this->specs->getRules();
}
/**
* @return string
*/
public function getComments(): string {
return $this->specs->getComments();
}
/**
* @return string
*/
public function getName(): string {
return $this->specs->getName();
}
/**
* @note Callers should not rely on the order, because it's nondeterministic.
* @return string[]
*/
public function getActionsNames(): array {
return $this->specs->getActionsNames();
}
/**
* @return string
*/
public function getGroup(): string {
return $this->specs->getGroup();
}
/**
* @return bool
*/
public function isEnabled(): bool {
return $this->flags->getEnabled();
}
/**
* @return bool
*/
public function isDeleted(): bool {
return $this->flags->getDeleted();
}
/**
* @return bool
*/
public function isHidden(): bool {
return $this->flags->getHidden();
}
/**
* @return bool
*/
public function isProtected(): bool {
return $this->flags->getProtected();
}
/**
* @return int
*/
public function getPrivacyLevel(): int {
return $this->flags->getPrivacyLevel();
}
/**
* @return bool
*/
public function isGlobal(): bool {
return $this->flags->getGlobal();
}
/**
* @return array[]
*/
public function getActions(): array {
if ( $this->actions === null ) {
$this->setActions( call_user_func( $this->actionsCallback ) );
// This is to ease testing
$this->actionsCallback = null;
}
return $this->actions;
}
/**
* @param array $actions
*/
protected function setActions( array $actions ): void {
$this->actions = $actions;
$this->specs->setActionsNames( array_keys( $actions ) );
}
/**
* Make sure we don't leave any (writeable) reference
*/
public function __clone() {
$this->specs = clone $this->specs;
$this->flags = clone $this->flags;
}
}