Siebrand Mazeland
176227e721
Maintenance for AbuseFilter extension.
...
* Replace deprecated methods.
* Remove no longer needed function fnmatch().
* Remove superfluous newlines.
* Remove unused and redundant local variables and globals.
* Deglobalization.
* Update documentation.
* Fix incorrect return values or add FIXMEs when in doubt.
* Escape output in a few places where needed.
* Remove unneeded MEDIAWIKI constant checks.
* Fix various JSHint/JSLint issues.
Patch Set 11: Merged https://gerrit.wikimedia.org/r/24701 into
this one per Siebrand's request
Change-Id: I02ba4ce31b6aca5b7324114093f8ece143abc295
2012-10-09 22:26:45 +02:00
grunny
13bdc746ed
Add missing message from the edit view for global filters
...
This message is used on the edit view when global filters are enabled to specify
whether or not a filter is global.
Patch Set 2: Add comments on where the message is used along with other messages
that can be formed by the concatenated string so they are easier to find
Change-Id: I5d1e99fa1dcaea8ed298affbd6388042f58686ee
2012-09-04 19:13:02 +10:00
csteipp
1973ea6714
Add Global Rules
...
* Update rules list view to show global rules toggle, global rules
* Update rule processing to get global rules from memcache, if no
rule exists, get them from the central database and store them in
memcache
* Delete global rule key whenever global rules are updated
* Add filtering for log by wiki on the central database, updated
table definitions to add index on afl_wiki
* Add global $wgAbuseFilterDisallowGlobalLocalBlocks so local wikis
can prevent global rules from locally blocking, removing or revoking
permissions.
* patchset 13: Include recommendations from Tim. Add db updates to
LoadExtensionSchemaUpdates hook.
* patchset 14: forgot to add new files
Change-Id: Id69a9d603f9679f838e8691c651a3e9d8461b422
2012-08-27 03:30:07 +00:00
Liangent
1b7994b3bd
Use a new message for subtitle of edit view when creating filter
...
Change-Id: Ie956ce2954e8f2507191677561fe68b548eddba5
2012-07-02 01:43:47 +08:00
Andrew Garrett
18bac6fed9
AbuseFilter: Make it possible to have differing default warning messages for differing filter groups.
...
Includes JS to sneakily change the default message if the user changes the filter group without having selected the "warn" action yet.
Change-Id: Ic753c3e018321dba3bf9f6d7bcee10a49c9faac8
2012-06-26 21:56:30 +02:00
Andrew Garrett
b8ef2830bb
Add some documentation improvements to Views/AbuseFilterViewEdit.php
...
Change-Id: I1f6fa1ff32b6fb1d71f99b0d456972c4ecaed29c
2012-06-17 23:03:39 +02:00
Alex Monk
5a05bb7e47
(bug 37335) Let people with abusefilter-view-private see diffs for changes to private abusefilters.
...
Change-Id: I0db040f327ed501714f70ede4abc3654799973f5
2012-06-07 16:55:09 +01:00
Andrew Garrett
dc207d0cbd
Abuse Filter: Allow filters to be split into "groups" for the purposes of operating them on different types of input.
...
The purpose of this change is to allow AFTv5 developers to run a separate list of filters against article feedback actions without issues of cross-contamination and bumping up against the condition limit.
Change-Id: I758795f01eaf3ff56c5720d660cd989ef95764a7
2012-05-12 12:53:32 +10:00
Sam Reed
69e582dc17
More documentation stubs
...
Fix Html::inputLabel to Xml::inputLabel
Fix up some deprecated code
Change-Id: If6503b1794d89666206802591094949e5d715ac1
2012-03-26 16:03:23 +02:00
Roan Kattouw
6c4bd57043
Revert r111217 (unreviewed rev in AbuseFilter) and its dependencies r113585, r113587, r113588, r113589.
...
All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
2012-03-21 19:41:11 +00:00
Sam Reed
05a9d4d061
More documentation stubs
...
Fix Html::inputLabel to Xml::inputLabel
Fix up some deprecated code
2012-03-11 20:51:54 +00:00
Sam Reed
642200ea1c
Add some more __METHOD__
2012-02-29 15:36:10 +00:00
Andrew Garrett
e2479d45da
(bug 33392) Fix issue where users without permission to add restricted actions could nonetheless remove them. Patch by Nikola Kovacs, with modifications for code style.
2012-02-08 01:02:11 +00:00
Sam Reed
1b383fe0ae
Fix r98659 per Nikerabbit
2012-01-13 20:41:16 +00:00
Sam Reed
a084822a88
Documentation
...
Remove unreachable return
Remove unused globals
2012-01-05 20:31:02 +00:00
Mark A. Hershberger
4e8be82722
Bug 33380 - Details of actions caught by a private filter should be private
...
Author: Nikola Kovacs
Hide private information from logs
2012-01-03 17:29:10 +00:00
Mark A. Hershberger
a4858a5109
Fix Bug 33390 - Examine page is visible for hidden log entries
...
Fix Bug 24186 - "Examine" page is visible to users without abusefilter-log-detail right
Author: Nikola Kovacs
There was a more complex patch on Bug 24186, but I think he makes a
good argument why his is better.
Beware: I'm not set up to test AbuseFilter, but I didn't see anyone
else in core MW who regularly works on it.
2011-12-27 23:35:24 +00:00
Liangent
c576289635
Followup r100969: There may be Mac newlines as well.
2011-12-10 08:40:11 +00:00
Victor Vasiliev
0f89170b4e
Fix a syntax error caused by using the same variable name for two different things.
2011-11-27 08:58:46 +00:00
John Du Hart
7cf809bb0e
Changes from r103817
2011-11-22 16:08:18 +00:00
John Du Hart
274dcd06a2
Pass one of converting AbuseFilter to use ContextSource
...
The main AbuseFilter class still needs to be fixed up, but that's a bigger job and I'm out of time
2011-11-16 05:34:24 +00:00
Liangent
44f71ac0b7
Normalize newline before exploding by "\n"
2011-10-27 12:50:48 +00:00
Liangent
8ac1b4c619
Newline to <br> replacement should take place after escaping
2011-10-27 12:17:48 +00:00
Raimond Spekking
4e578cac93
Run some filter IDs through formatNum() for better l10n
2011-10-17 07:56:05 +00:00
Andrew Garrett
4a37f1b892
Respond to CR on r96225: use rawParam
2011-10-02 07:06:38 +00:00
Andrew Garrett
137e0ece3a
Do not use replaceafter, per r52735 CR
2011-09-04 14:12:18 +00:00
Siebrand Mazeland
8ecd76b867
Use Linker statically.
...
No constant check needed for files only containing a class.
2011-09-02 15:34:55 +00:00
John Du Hart
b30697e94c
Adds ResourceLoader support to AbuseFilter
...
Rewrote javascript to use jQuery
Added API modules to replace sajax_* calls
Solves bug 29714
2011-08-26 20:12:34 +00:00
Sam Reed
a9e738f099
More document
...
Few minor code improvements
2011-08-24 22:11:52 +00:00
John Du Hart
e6e286ba31
(bug 30480) Fixes AbuseFilter's tool page from having its own subtitle, it shoudl have the navigation bar instead
2011-08-22 21:52:07 +00:00
Robin Pepermans
b7881fc102
(bug 25898) AbuseFilter: clearer permission error when attempting to view diff of private filter
...
Also change some link functions to use Linker::link*
2011-07-14 04:57:29 +00:00
Robin Pepermans
f4750e9250
(bug 23086) AbuseFilter config diff date and time should use user preference instead of UTC
2011-07-06 23:14:04 +00:00
Happy-melon
12e1428629
* Implement an extensible Block::prevents( <action> ) function to replace the plethora of direct member variable accesses This pushes the historic *disable*-createaccount-vs-*allow* usertalk-edit wierdness down to the database layer
...
* Implement accessors for isHardblock() and getRangeStart()/getRangeEnd() in the same fashion.
* Make the corresponding variables private, removing external accessors. This required updating AbuseFilter with non-B/C code, so I also implemented the rest of the changes I've made to the blocking backend in that extension.
* Move the "get an IP range which encompasses the given IP/range" logic to Block.php; will be needed later... :D
2011-03-19 23:47:08 +00:00
Sam Reed
6d548203f7
Parameter and Return Type hints
2011-02-10 17:32:57 +00:00
Sam Reed
a0a6d18b88
Code cleanup, mainly unused variables
2010-11-04 01:29:10 +00:00
Sam Reed
6098610527
Another big cull on unused variables and such
2010-10-29 21:55:29 +00:00
Sam Reed
961f512452
More deprecated method call removals and updates
2010-10-29 15:32:44 +00:00
Sam Reed
cf800e4c18
Start removing/fixing calls to deprecated methods in WMF used extensions
2010-10-29 15:14:44 +00:00
Jack Phoenix
5e0330c6cc
AbuseFilter: coding style tweaks, changed some while loops to foreach (as per http://www.mediawiki.org/wiki/Manual:Coding_conventions#Assignment_expressions ) and added __METHOD__ to one DB query
2010-08-19 21:12:09 +00:00
Sam Reed
485a5b0856
Minor revert of CentralNotice.db.php
...
Add some braces
Remove more unused variables
2010-07-26 21:55:18 +00:00
Sam Reed
bfeb901839
Remove some more unused variables
2010-07-24 21:32:07 +00:00
Sam Reed
6981886b50
Nuke some more unused globals
2010-07-24 21:12:27 +00:00
Aryeh Gregor
ed5b83e6ac
Remove most named character references from output
...
Recommit of r66254 to trunk. This was just
find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +
followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives. The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html >.
I cleared it with Tim and Brion on IRC before committing. It might
cause a few problems, but I tried to be careful; please report any
issues.
I skipped all messages files. I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.
This should get rid of all named entities everywhere except messages. I
skipped a few things like   that I noticed in manual inspection,
because they weren't well-formed XML anyway.
Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you. Die.
2010-05-30 17:33:59 +00:00
Raimond Spekking
de5b7258b9
Add accesskeys 's' for save actions
2010-03-13 17:35:12 +00:00
Raimond Spekking
ac8439bd8a
Use commaList() for better i18n
2010-03-13 17:23:08 +00:00
Siebrand Mazeland
b274606879
Update code formatting, run stylize.php, whitespace updates
2010-02-13 14:10:36 +00:00
Siebrand Mazeland
e86b1357ac
Update break notation to self enclosed and properly spaced
2009-11-14 20:59:15 +00:00
Jack Phoenix
e2a16fe755
AbuseFilter: big commit - coding style & spacing cleanup; also marked SpecialPages' construct() and execute() functions as public and capitalized some SQL keywords
2009-10-07 13:57:06 +00:00
Andrew Garrett
13ab814753
AbuseFilter: Show permissions errors on new filter and importing a filter when the user does not have permission.
...
Resolves bug 20467
2009-09-18 10:05:20 +00:00
Andrew Garrett
6133a51192
Fix bug 19799, hide public versions of private filters.
2009-08-07 16:13:06 +00:00
