3 commits

Author	SHA1	Message	Date
Matěj Suchánek	702d77e3ce	Create real integration test for variables ... For fixing bugs like T65632, T105325, or T264104, we will need to update code in more than one place at once. To prevent regressions, create an integration test which tests the whole pipeline, from the request submission to variable evaluation. Edits are simulated using action=edit API call because the hook AbuseFilter uses is run from EditPage. To increase confidence in test coverage, remove some annotations from AbuseFilterConsequencesTest or make them less greedy. Ideally, it would only test consequences. This patch includes refactoring of AbuseFilterCreateAccountTestTrait which now only inserts the user into the database if it really should be created. It also restores test coverage of some other classes. Change-Id: I661f4e0e2bcac4770e499708fca4e4e153f31fed	2022-11-26 18:51:38 +01:00
Daimona Eaytoy	496c2ee370	Add logging when the 'block' action fails ... Also avoid using User, use Authority instead. Bug: T303059 Change-Id: I419ab3726d95ef600e2aa14dca5fa14066d245e3	2022-03-05 19:12:53 +00:00
Daimona Eaytoy	cbea88f818	Add a service to retrieve the filter user ... Unfortunately, this isn't using DI completely, because of the User::newSystemUser call. I'm not even sure if we really need to call it or we can just stick to new UserIdentityValue, but leaving like this for now. Also, the types were weakened to UserIdentity, so the transition is going to be easy anyway. Change-Id: I08f8fae0fcc622ff0ac3f86771476d06d1c18549	2020-10-26 14:06:53 +01:00