3 commits

Author	SHA1	Message	Date
Daimona Eaytoy	0834f37e42	Fix some edge cases in ViewEdit ... Follow-up Iabd0ae5b18571f8cad44ef2d86bcf2519e7f95ba. This patch: - Moves some save-related code to a separate method - Reduces conditionals nesting - Fixes an edge case where the content of the form would be wiped in case the token didn't match. - Adds another (basic) selenium test - Standardizes return types - Moves data load outside of buildFilterEditor Change-Id: I89444b59f04c495c9ab59244151c8ed5d38cf0fe	2020-02-08 15:35:46 +01:00
Daimona Eaytoy	3a9eac9ad5	Unbreak filter edit form ... In Ib7427e15f673a575738489476e604c387f449ddd, I thought that $parameters could've only been null if $action wasn't enabled, but actually, they're null even if the action is just not set. Which is true for all actions when creating a new filter, and all non-set actions when editing an existing one. Hence, revert the part that touched ViewEdit. Also add a selenium test to ensure that warn parameters are visible. Bug: T236286 Change-Id: I8150baa077208eb1fc54ebc1d8415a243d0f3bd3	2019-10-23 18:50:44 +02:00
Daimona Eaytoy	0646b4fe7d	Add config for Selenium and basic tests ... This is some sort of Hello World for selenium. This patch adds the config files and a couple of very basic tests. Bug: T214478 Change-Id: I8193b4edb40332bea1d08e24ec020bf36004320d	2019-09-17 16:23:07 +00:00