wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-27 23:40:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
7362 commits 11 branches 20 tags 106 MiB
Commit graph

7362 commits

This branch
This branch
All branches
Author SHA1 Message Date
Amir Sarabadani 60cbc3b464 BlockedDomains: Use cleaner array building and add tests 
Regarding array building: Instead of adding to array with
$array[] = 'foo' and then doing array_flip(), simply do
$array['foo'] = true;

Regarding tests: I originally wanted to create a unit test but I ended
up mocking so many things that it wasn't worth it and the config variable
is globaly which first we need to clean up after deployment is done.

Bug: T337431
Change-Id: Iac8dca7078668ee3441d19b6aafe499c1aa0d732
 2023-06-12 17:46:55 +00:00
thiemowmde 518955f9c3 Fix error reporting in BlockedDomainStorage for real 
This is a direct follow up for I6373fa6 where we apparently fixed
half of the cases while breaking the other half. There was actualy
a code path that can return null, and anther one that can return a
status object.

Since there is never anything done with the status object we can as
well get rid of it and always return null in case of an error.

Bug: T337431
Bug: T279275
Change-Id: I2ccb58756182897bcd6649c9f589e2f7a0321b20
 2023-06-12 17:11:49 +02:00
jenkins-bot afaf9d34f8 Merge "Fix broken error reporting in BlockedExternalDomains" 2023-06-12 14:20:20 +00:00
jenkins-bot 16e3bcf6db Merge "Localisation updates from https://translatewiki.net." 2023-06-12 11:59:19 +00:00
Translation updater bot 06c0b74fe5 Localisation updates from https://translatewiki.net. 
Change-Id: Iaec054d1a0bcf1b11f92dea6569d9840a50ed4c4
 2023-06-12 13:06:22 +02:00
thiemowmde 1eb985c619 Fix broken error reporting in BlockedExternalDomains 
Apparently a mistake from I3df949c.

Bug: T337431
Bug: T279275
Change-Id: I6373fa6de561b3018e85f61f5e45ed8c886ce311
 2023-06-12 10:52:35 +02:00
thiemowmde 84058c3d96 Make use of the ??= operator and such where it makes sense 
We can avoid a bit of code duplication and move code closer together
when it belongs together.

Change-Id: Iffca7e4abfbf03d4663ee909220057bcbd54da75
 2023-06-12 10:27:03 +02:00
jenkins-bot 6510db57a7 Merge "Make edit summary of blocked domain changes use i18n" 2023-06-09 19:46:38 +00:00
jenkins-bot 651ad4f507 Merge "Add abusefilter-bypass-blocked-external-domains right" 2023-06-09 19:45:55 +00:00
jenkins-bot 563ef601f4 Merge "BlockedDomains: Make lookup for domains added in blocked domains faster" 2023-06-09 19:45:53 +00:00
Translation updater bot 010f3985ee Localisation updates from https://translatewiki.net. 
Change-Id: Iaacffe297a8bb66c72fb6acb2471c3931b5de5f8
 2023-06-09 09:12:20 +02:00
Amir Sarabadani 9ca20e7749 Make edit summary of blocked domain changes use i18n 
It shouldn't be all in English.

Bug: T337431
Change-Id: I57c6b08b652e83baaef41ab0b74af7a4668698a2
 2023-06-08 22:06:19 +02:00
Amir Sarabadani 0acfe05251 Add abusefilter-bypass-blocked-external-domains right 
This is similar to sboverride right in SpamBlacklist. Defaults are also
the same

Bug: T337431
Change-Id: Iaff91c1f9f7aece0787348dd071701ef99e0291d
 2023-06-08 22:06:19 +02:00
Amir Sarabadani 7658885d75 BlockedDomains: Make lookup for domains added in blocked domains faster 
We will have a pretty large list of blocked domains that we need to
swift through in each edit for any added domain. In order to cacth
subdomains being added, we have to do all sorts of complicated
operations and string search in large set of strings which is quite
slow. To fix that, let's simply pretend a user who has added
foo.bar.com, also added bar.com and com and do exact match in array of
strings making it much faster.

h/t Krinkle for the idea

Bug: T337431
Change-Id: I96795ed7d1a25f051db0b591dde21b032b138ded
 2023-06-08 21:50:43 +02:00
Translation updater bot de4dc62043 Localisation updates from https://translatewiki.net. 
Change-Id: I35071de544ce8847db41fb081af7e6476dedc387
 2023-06-08 10:38:37 +02:00
jenkins-bot d6d8608161 Merge "Replace deprecated MWException" 2023-06-07 23:25:54 +00:00
jenkins-bot 90414626fb Merge "Degroup: Return early if user is a temporary user" 2023-06-07 17:18:46 +00:00
Daimona Eaytoy caee78c24d Replace deprecated MWException 
These are all unchecked.

Bug: T328220
Change-Id: I8d2f098a8b634d4a226b40ddaef31f0303a0789f
 2023-06-07 17:41:20 +02:00
Amir Sarabadani 462096f523 Allow interface-admins to edit blocked domains json directly 
For now, we will revisit this in the future. Specially if the
communities think otherwise.

Bug: T337431
Change-Id: I2847264eba9a3cc4fc47a22eacb523199015f9e7
 2023-06-06 23:36:12 +02:00
Siddharth VP 8a22007034 BlockedExternalDomains: validate JSON structure before save 
This makes raw page editing safer, and potentially enables opening up
access to less restricted user groups.

Bug: T337431
Change-Id: I14f21003a551f34b6e524e9b229613e79b0e5a70
 2023-06-06 23:31:28 +02:00
jenkins-bot 1298c9243b Merge "Update block expiry message in AbuseFilter edit view" 2023-06-06 15:58:27 +00:00
Thalia 573838efc5 Degroup: Return early if user is a temporary user 
Treat temporary users the same as IP users. Neither has user groups,
so return early for both.

Bug: T335062
Change-Id: I20b48608cf6ba5f8e8e36a378d66c603d84b032f
 2023-06-06 14:10:21 +01:00
Translation updater bot aa5b57f8a5 Localisation updates from https://translatewiki.net. 
Change-Id: If751ecafe7f3cba692a4de62490a473292f78606
 2023-06-06 08:10:35 +02:00
Translation updater bot c4ae5be1ed Localisation updates from https://translatewiki.net. 
Change-Id: Iac227750c610543c2c4d8002f04c244c41580cff
 2023-06-05 08:39:49 +02:00
jenkins-bot 3feb7d5af0 Merge "BlockedDomains: Put a cache behind parsing of notes of blocked domains" 2023-06-04 15:33:00 +00:00
Amir Sarabadani be928818a4 BlockedDomains: Put a cache behind parsing of notes of blocked domains 
It'll be 6K rows in enwiki, parsing 6000 wikitext notes is going to be
expensive.

Bug: T337431
Change-Id: I010d773a7b096c783f5da0d6997d946b3bfd6b6e
 2023-06-02 20:13:33 +02:00
Translation updater bot 36c7a090cb Localisation updates from https://translatewiki.net. 
Change-Id: I38e39081f757670652a28d4a9c1c477040061e5f
 2023-06-02 09:22:42 +02:00
jenkins-bot 64ed21cff7 Merge "Use new DeferredUpdatesManager service" 2023-06-01 19:00:42 +00:00
James D. Forrester fb50c1f019 BlockedExternalDomains: Make this a special right, prohibit direct editing 
Bug: T337431
Bug: T279275
Change-Id: I96d1e2c8d8728c26e38515032ef773770e26dda4
 2023-06-01 09:20:44 -04:00
Translation updater bot 32ea2e5d76 Localisation updates from https://translatewiki.net. 
Change-Id: I2f28d56f54bb8103092f26a84bd1fdbb9625818d
 2023-06-01 08:42:13 +02:00
Amir Sarabadani adae5b95b5 Minor improvements to blocked domain filtering 
See I3df949c4d41ce

Follows-Up: I3df949c4d41ce65bb4afa013da9c691ac05fc760
Change-Id: I81974a8d935838e00b4155454f2fb619f8a6bad9
 2023-05-31 21:59:45 +02:00
jenkins-bot 3b5356f664 Merge "Introduce Special:BlockedExternalDomains" 2023-05-31 18:50:58 +00:00
Translation updater bot 04980b486c Localisation updates from https://translatewiki.net. 
Change-Id: Ia993164f3fd27238f910fce14fd44170eb624dab
 2023-05-31 08:19:20 +02:00
Amir Sarabadani 53eb27f086 Introduce Special:BlockedExternalDomains 
It is behind a feature flag. Improvements on it can happen in follow
ups. The patch is already quite massive.

Bug: T337431
Bug: T279275
Change-Id: I3df949c4d41ce65bb4afa013da9c691ac05fc760
 2023-05-30 20:48:42 +02:00
Daimona Eaytoy 1c0e558c78 Use new DeferredUpdatesManager service 
And remove some hacks for unit tests.

Change-Id: I4e9932a003ac7420f307f01b8d12062fd05a3bb8
 2023-05-30 12:50:08 +00:00
Translation updater bot 7a3b039882 Localisation updates from https://translatewiki.net. 
Change-Id: Idd4e1396f0aa171b428889e26f7218f81aaca597
 2023-05-30 08:56:08 +02:00
Translation updater bot d89a5d5456 Localisation updates from https://translatewiki.net. 
Change-Id: If47b86517cd80f4d9946c30e4b22e5d1c4192193
 2023-05-29 09:57:57 +02:00
jenkins-bot 7f4af85ce0 Merge "Add tests for temporary user in CheckUserHandlerTest" 2023-05-27 16:31:04 +00:00
Amir Sarabadani e9bec9ffa2 Improve support for read-new wikis with externallinks 
Bug: T337149
Change-Id: I68e72243346725fa78281c78dbd6b4cab0b7cbca
 2023-05-26 15:47:06 +02:00
jenkins-bot 17cb8ac514 Merge "Update user type checks to handle temporary users" 2023-05-26 11:56:35 +00:00
Thalia 56c86a761f Add tests for temporary user in CheckUserHandlerTest 
Follow-up to d42b7335d5

Change-Id: Ia70377bf03a48e006174d6f658cf11142f1dd624
 2023-05-26 14:34:04 +03:00
Thalia 3343acf63f Update block expiry message in AbuseFilter edit view 
Temporary users get the same block expiry as anonymous  (IP) users,
since d42b7335d5.

Update the checkbox label to reflect this.

Change-Id: Ibf60936d9c746d857fc4354552d71e1efdd52066
 2023-05-26 12:45:04 +03:00
AnaïsGueyte d42b7335d5 Update user type checks to handle temporary users 
* Set the same block expiry for temp and anon users
* Don't block autopromote for temp users; they can't be autopromoted
* Bail early from CheckUserHandler if the user is temporary

Bug: T335062
Change-Id: I6b72537f568c4c70a0b86f1825ea30b767f5634a
 2023-05-25 17:26:58 -02:30
Translation updater bot 462bc25418 Localisation updates from https://translatewiki.net. 
Change-Id: Ica9e8bd51d40c1590443fe187ea97ac5985eed45
 2023-05-25 09:07:53 +02:00
Translation updater bot 8452e36957 Localisation updates from https://translatewiki.net. 
Change-Id: I8686896a5b6f92a7de4191141ee212f950c4937e
 2023-05-22 08:44:22 +02:00
jenkins-bot 1cae9034eb Merge "tests: Make some PHPUnit data providers static" 2023-05-21 14:11:32 +00:00
libraryupgrader ed21eb407c build: Updating npm dependencies 
* grunt-banana-checker: 0.10.0 → 0.11.0
* stylelint-config-wikimedia: 0.14.0 → 0.15.0

Change-Id: I5c2eb1325cf0f7d4b01c74720f93595c4b899202
 2023-05-20 22:38:40 +00:00
Umherirrender faaa5126eb tests: Make some PHPUnit data providers static 
Initally used a new sniff with autofix (T333745)

Bug: T332865
Change-Id: I892127a7cf794c52b1106d0239d273476a6113c3
 2023-05-20 21:44:55 +02:00
Umherirrender 0c513ba63e tests: Use static provider in AbuseFilterHookRunnerTest 
Shows up a deprecation message

Follow-Up: I5ff35ad0e894f0a27beae00257dc1fc599ad518d
Change-Id: I2e74ca48374f1ab5901ae3adf891ea29cd322251
 2023-05-19 22:19:48 +02:00
jenkins-bot f30e7e5198 Merge "Update moved class RawMessage" 2023-05-19 14:33:58 +00:00