6 commits

Author	SHA1	Message	Date
Daimona Eaytoy	49dbb21bc2	Improve coverage for Consequences methods ... In particular getMessage Change-Id: I1c0e533bccde458e64008a4e02556273ce11d5e7	2021-01-06 14:07:02 +01:00
Daimona Eaytoy	6e27a9ddb3	Cleanup variables-related classes ... Change-Id: I20a7fe1a40255043ed0d125dee61ea6052dda69c	2021-01-02 18:19:38 +01:00
Daimona Eaytoy	762d71c51d	Create a dedicated namespace for variables-related classes ... Some cleanup is left for later to keep the diff easier to read. Change-Id: Ife445b5e47e707ab77ec867ac3b005866aa74ef2	2021-01-02 18:16:48 +01:00
Daimona Eaytoy	d3b330b6d4	Create a VariablesManager service ... This makes VariableHolder a true value object, and introduces a stateless service, VariableManager, to operate on it. Note, in theory, this new service is still cyclically coupled with LazyVariableComputed. However, it's now two stateless service being coupled, not two smart/god value objects, so we've still earned something. For now, the dependency is hidden by using a callback. Some alternatives for that are mentioned in a code comment. Bug: T261069 Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b	2021-01-02 17:15:31 +00:00
Matěj Suchánek	2793e7f1cf	Reversible consequences ... Introduce ReversibleConsequence interface for Consequence classes whose potentially destructive actions can be reverted using Special:AbuseFilter/revert. This allows moving reverting logic from AbuseFilterViewRevert to individual Consequence classes and testing. Unfortunately, the code is definitely not very clean now. Change-Id: I558da711f1645ccf64792c6102cf743827171320	2020-12-31 14:43:32 +01:00
Matěj Suchánek	63b950e5b6	Test some Consequence classes and clean up ... Sadly, these are not unit tests. Bug: T201193 Change-Id: I4c977ab14b273b02803a63f0a7b152a581a838b2	2020-12-19 16:31:22 +01:00