wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-24 06:03:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
6395 commits 196 branches 0 tags 100 MiB
Commit graph

6395 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 63a9c86607 Merge "Improve test coverage metrics" 2021-02-22 17:00:23 +00:00
jenkins-bot 54c56139a9 Merge "Avoid using User ::getCanonicalName" 2021-02-22 16:56:12 +00:00
jenkins-bot ea6a6ab4fc Merge "Fix StatsdDataFactory injection" 2021-02-22 16:56:09 +00:00
daniel 63a497fb56 Don't set actor on UserIdentityValue in tests. 
The actor ID is being removed from UserIdentityValue. Non-zero values
are triggering a deprecation warning now.

Needed-By: I9925906d11e47efaec3c1f48d5cb3f9896a982c1
Change-Id: Id60e56e70f6e4b44f49887d9e5ae5a23b1fd19a2
 2021-02-22 11:30:54 +00:00
Matěj Suchánek 569c02f3ae Fix StatsdDataFactory injection 
This was an obvious mistake and contradiction to
what the above comment stated.

Bug: T275369
Change-Id: Idf0c012151738fd842101586ab5c3e2656a86db2
 2021-02-22 12:08:50 +01:00
Translation updater bot cc3dbe149d Localisation updates from https://translatewiki.net. 
Change-Id: I1f5f9b45ad3d7f2e80fc5d0b4e90e2b15e6e58b0
 2021-02-22 08:49:55 +01:00
vladshapik dcd038e613 Avoid using User ::getCanonicalName 
Remove using of User::getCanonicalName since this method will be hard-deprecated. Now it is soft-deprecated

Bug: T275030
Change-Id: I3ce1199f18276096279ce3c80f63e53d023a0f5a
 2021-02-21 23:16:40 +02:00
Matěj Suchánek c2376efddc Improve test coverage metrics 
Change-Id: I1618883e3ade7dde538242fb51a36c22999df76d
 2021-02-21 09:59:52 +01:00
jenkins-bot b050e36843 Merge "Align arg counting between the parsers" 2021-02-21 03:37:52 +00:00
Daimona Eaytoy 2470bea0d9 Update hit counts in a DeferredUpdate 
Bug: T274455
Change-Id: Iadd383f150c5f9b736e37bfd8bdad56298f3d8d5
 2021-02-21 03:15:16 +00:00
Matěj Suchánek 4f1a63107d Use a different message for unprivileged users 
Everyone can examine generated variables but not everyone
can test filters. Concerns Special:AbuseFilter/examine.

Change-Id: I9c205a0f1d9a7fdf15c4998d43983b9fa37f4694
 2021-02-20 17:55:09 +01:00
Matěj Suchánek 5d4025d8c9 Create a new method for authorizing access to test tools 
This commit doesn't change any permissions for anybody.
It's the first step to achieve what the task asks for.

Bug: T242821
Change-Id: I8060ca926e6769b11d470fe4037854cda496000d
 2021-02-20 17:54:35 +01:00
jenkins-bot b02594a8aa Merge "Avoid using Title in addNavigationLinks" 2021-02-20 14:52:51 +00:00
jenkins-bot 8575201ab2 Merge "Do not serialize RunnerData to array in FilterRunner" 2021-02-20 14:47:15 +00:00
Daimona Eaytoy 2bb5c3c7b5 Align arg counting between the parsers 
1 - Change the structure of if/elseif for readability
2 - In the old parser, if there's an empty argument, never add it (the
new parser was already doing that).

Bug: T156095
Bug: T156096
Change-Id: I4237b1a0ba01e7ce04dcc945f7daf34612fcf07d
 2021-02-20 14:33:56 +00:00
Matěj Suchánek ca806b46b7 Avoid using Title in addNavigationLinks 
Simple TitleValue object will do the same job.
I verified LinkRenderer localizes the targets.

Change-Id: Ia25659947da1d2d7e5557884b2ab9153c9c1bc43
 2021-02-19 19:00:01 +01:00
Translation updater bot fa0fb1e84b Localisation updates from https://translatewiki.net. 
Change-Id: I9fa983c28a3ea7b3098a84328c239bdbcc67bb7e
 2021-02-18 08:42:07 +01:00
Translation updater bot eeb90040a9 Localisation updates from https://translatewiki.net. 
Change-Id: I4fd12b0457d3409a20ee216f96f197e0bc4c1ad1
 2021-02-17 08:41:36 +01:00
Translation updater bot 552dd86729 Localisation updates from https://translatewiki.net. 
Change-Id: Ic8345610534de54a67b2688f9aba68e662b82ab9
 2021-02-16 08:28:56 +01:00
Translation updater bot ec9cd9a7e0 Localisation updates from https://translatewiki.net. 
Change-Id: I187e09baa3bec5cd150dc4fea063627c58374b3d
 2021-02-15 10:03:28 +01:00
Daimona Eaytoy e64049c30b Create dedicated types of parser exceptions 
Introduce a clear distinction between internal exceptions and
user-visible exceptions, leaving AFPException as base abstract class.

Later, it should be possible to narrow some types around, e.g. in
ParserStatus (that might work with user-visible exceptions only).

Also a future TODO is putting all the exceptions in their own namespace
(probably ...\Parser\Exception).

Change-Id: I4e33a45117f0a3e73af03cc1e3f2734beaf2b5e1
 2021-02-12 13:56:02 +00:00
Matěj Suchánek c18e4a4a5f Do not serialize RunnerData to array in FilterRunner 
Change-Id: Ia803042224959e516bc14bdc034421b8e80390a8
 2021-02-12 14:03:50 +01:00
jenkins-bot 431226ac39 Merge "Serialize all data for edit stash" 2021-02-12 13:01:10 +00:00
Translation updater bot 8f19ca5a87 Localisation updates from https://translatewiki.net. 
Change-Id: I2b21158f8d11a375bca0eb31d322a0f5a33b9c60
 2021-02-12 08:50:36 +01:00
jenkins-bot 3d7da7aa29 Merge "Check response code and prevent exception in worker-abusefilter" 2021-02-12 00:59:50 +00:00
Daimona Eaytoy 607be2d5bb Check response code and prevent exception in worker-abusefilter 
Bug: T274401
Change-Id: I53be8e91c8d4e85df8062504de19929994f56f15
 2021-02-12 00:01:51 +00:00
Reedy e197161c79 Use updated CheckUser Hooks class 
Depends-On: I3f66b660f9d59c0e88b182c9b06ee8cec994348e
Change-Id: Ia488ce647c5dbd0ab83d2782e76d8c6a35f53bfb
 2021-02-11 19:27:06 +00:00
Matěj Suchánek a51b9bf903 Serialize all data for edit stash 
Thanks to this, we will be able to provide more information
to consequences and watchers, which will open door for new
features and possibly cleaner code.

Change-Id: I7135509823ea84b2a2923d2c1831ce293b98a9f9
 2021-02-11 15:09:50 +01:00
Translation updater bot 4dc5e493df Localisation updates from https://translatewiki.net. 
Change-Id: I273f29bf86908d3fe18602848d89a4240fa60d02
 2021-02-11 08:37:11 +01:00
jenkins-bot 64cf6e2e7a Merge "Allow testing Flow edits" 2021-02-10 16:56:08 +00:00
Daimona Eaytoy 4067f54351 Allow testing Flow edits 
Bug: T115128
Depends-On: Ia736596d0e65904b62233e7625868c9988ffa9ff
Change-Id: Ifc014f190298bfcb17f3e9b6c2f630e027cb4116
 2021-02-10 15:04:00 +00:00
Translation updater bot 13b7f2577c Localisation updates from https://translatewiki.net. 
Change-Id: Id8e0260d52010a9745f3f5cd6a3531197f092375
 2021-02-10 08:37:25 +01:00
Translation updater bot 24852ecd45 Localisation updates from https://translatewiki.net. 
Change-Id: I9301361b4bc9def1fd56811f19683bd88cca08f6
 2021-02-09 08:38:34 +01:00
Matěj Suchánek 2b3af752ef Get rid of hitCondLimit parameter and field 
As the todo says, move the check to the callers.

Change-Id: I5c5fbf772ca57758c901a1ae8068a0f119b4f26f
 2021-02-08 15:48:59 +00:00
jenkins-bot 57671efea3 Merge "Create RunnerData class to store data about filter runtime and results" 2021-02-08 15:35:10 +00:00
Matěj Suchánek 1a0a702641 Create RunnerData class to store data about filter runtime and results 
Get rid of the $profilingData property.

Change-Id: I608e7b9bcf9e91d9afaadfb8cd191e60d47f9db7
 2021-02-08 16:06:25 +01:00
jenkins-bot 4737e038f9 Merge "Separate loose and backwards compatible code" 2021-02-08 13:25:22 +00:00
jenkins-bot c6797f502e Merge "Make FilterRunner::checkFilter return ParserStatus" 2021-02-08 11:40:16 +00:00
Matěj Suchánek 0eff5a3fa0 Separate loose and backwards compatible code 
Small refactoring. Create checkAllFiltersInternal and process
its return value in checkAllFilters to ensure compatibility.

Also fix some annotations.

Change-Id: If9d296de48f08d719f1700f88870002b814c5b31
 2021-02-08 11:18:53 +01:00
Translation updater bot 39b547d2c8 Localisation updates from https://translatewiki.net. 
Change-Id: I2d0d20a9db37f347f854825622d458df80997ec7
 2021-02-08 08:36:38 +01:00
Umherirrender 4714a4ed80 Rework time handling in AbuseFilterConsequencesTest::testStashedEdit 
Avoid strtotime and compare TS_MW timestamps
Set a fake time to get the same block expiry for relative times

Bug: T272236
Depends-On: I1357d3a78538b8bcb2a3507d86f35371e3f26d47
Change-Id: I5447953c5a0d7ecf4534f4ac4bc2260fa9f42117
 2021-02-07 14:27:17 +01:00
Matěj Suchánek 865b7023e4 Make FilterRunner::checkFilter return ParserStatus 
This is a small refactoring. The method is protected,
so we only take care of compatibility of ::checkAllFilters.

This might be also be useful if we decide to work on T174554.

Change-Id: I83cd58ec325972264e86d7a73366c0affed0a37e
 2021-02-07 12:28:45 +01:00
jenkins-bot a7b24b1dee Merge "Clean up EditStashCache and test" 2021-02-07 01:32:26 +00:00
Daimona Eaytoy a5d79f426c Clean up EditStashCache and test 
Change-Id: I952b7bb32d8697c89988f4e0eda8d3177cb30972
 2021-02-06 23:16:32 +00:00
jenkins-bot 27c0130d53 Merge "Skip regexp validation if the regex is (partly) unknown" 2021-02-06 21:50:35 +00:00
jenkins-bot d7204eaf73 Merge "Use a different message prefix for parser warnings" 2021-02-06 19:19:19 +00:00
jenkins-bot 3ea76b04ef Merge "Move all "secondary" hooks away from AbuseFilterHooks" 2021-02-06 18:46:01 +00:00
Daimona Eaytoy 4dbde4dcf0 Use a different message prefix for parser warnings 
The abusefilter-warning prefix is reserved for filter warnings. Pointed
out by Matěj.

Change-Id: I169e4c3d29b08c7f5af2136a683fc4427f8e93f5
 2021-02-06 15:42:33 +00:00
jenkins-bot 2de19b61d2 Merge "Introduce EditStashCache" 2021-02-06 15:36:52 +00:00
Matěj Suchánek 6bb44fd088 Introduce EditStashCache 
This class is responsible for interaction with edit stash.

Bug: T271520
Change-Id: I7cc32de0494e76cd9ba12220235c1cdb6b1d5ee1
 2021-02-06 12:43:34 +01:00