3 commits

Author	SHA1	Message	Date
Daimona Eaytoy	60519e1886	updateVarDumps: avoid using services in the constructor ... This is I4df27f3d02432c201c04d9fa118f0129b0a79778 striking again. Fool me once, shame on thee, fool me twice... Change-Id: Icea025a2c81e3b413b7bd9ece52866aeaf42937d	2020-10-03 23:23:37 +00:00
Daimona Eaytoy	55ba083b13	Introduce a KeywordsManager service ... This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717	2020-09-28 23:03:52 +00:00
Daimona Eaytoy	2c03c77d9f	Add a maintenance script to clean afl_var_dump ... This script aims to fix every problem reported in T213006. Subsequent patches will add new code and drop the back-compat one. Bug: T213006 Bug: T187153 Bug: T204236 Bug: T187731 Bug: T204235 Bug: T214193 Bug: T214196 Bug: T34478 Depends-On: I5b29ff556eca45fe59d15e2e3df4d06f1f6b3934 Change-Id: I22cf698c5be77506727cbd227c67e037a5d89b5c	2020-02-28 19:41:30 +00:00