Commit graph

4930 commits

Author SHA1 Message Date
Daimona Eaytoy 39fc7c12af Restore unit tests for CachingParser and fix it
Added cachingParser back to *all* the parser tests, fixed a couple of
differences with the normal parser, and added a couple of tests so that
any cachingParser-related file has 100% coverage. Also move the remaining
get_matches tests inside parserTests, and specify the parser used in case of failure.
This also adds a new base class for parser-related tests with a couple
of util methods.

Bug: T201193
Change-Id: I980aec3481a52ecc35f1811a366014a5581a7cdb
2019-05-25 10:55:24 +02:00
jenkins-bot 1cb80be0ad Merge "Add tests for various data type casts" 2019-05-24 19:19:20 +00:00
jenkins-bot 058e215882 Merge "Refactor tokenizer caching" 2019-05-24 19:09:03 +00:00
Daimona Eaytoy f56562f583 Add tests for global filters
Another crucial part to have covered. Also clarify that
AbuseFilterCentralDB can be of the form "dbname-prefix".

Remove a filter used for profiling and replace it with a global one:
we're still fine, and the list is kept shorter.

Bug: T201193
Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4
Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2019-05-24 16:58:23 +02:00
Daimona Eaytoy b3707106e9 Reset MWTimestamp in tearDown
Follow-up of I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4.

Change-Id: Icf288d7c4a9d087e7e1cd8a6e8c8cc9dac20e532
2019-05-24 16:54:29 +02:00
Daimona Eaytoy a766e39ade Add unit tests for profiling
Yet another important part to have covered. While for normal edits it
already works, for stashed ones it doesn't. That's why we need the patch
for checkAllFilters. Since for stashed edits profiling stats are all
zeros, this may explain T201334.
Changed the timestamp variable to use wfTimestamp instead of time() so
that we can fake it inside unit tests.
In a subsequent patch we should add average runtime conditions to tests
(really tricky).

Bug: T201193
Depends-On: Ib17821240b25c972a187e6b5eae42c5ada6c65e7
Change-Id: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4
2019-05-23 08:47:40 +00:00
Daimona Eaytoy 00b9791349 Add unit tests for stashed edits
This is an important part to cover, and should be further expanded.
Also, fix a couple of minor things around, including making some methods
non-static.

Bug: T201193
Depends-On: I5e35d773904a62105767ce6d7d962ab5525c2d12
Change-Id: Ib17821240b25c972a187e6b5eae42c5ada6c65e7
2019-05-23 08:47:25 +00:00
Daimona Eaytoy 33fca4e096 Ignore trailing commas in function calls
First step before removing this weird syntax. I'd love to add a unit
test for params count, but I couldn't find a way, since doLevelFunction
is protected, relies on class members, and the args count is local.

Bug: T153251
Change-Id: Ica3e49f5b00595a95513d9683732e490aa7aae17
2019-05-21 23:13:31 +00:00
Translation updater bot 6d1386bbcf Localisation updates from https://translatewiki.net.
Change-Id: Ibe5098d575962179d566e08afcf8f9c31d8d1e26
2019-05-20 22:25:24 +02:00
jenkins-bot a9afdc1f80 Merge "Slightly improve degroup action, remove Phan suppressions" 2019-05-19 17:20:23 +00:00
jenkins-bot 48ac8c492b Merge "Temporarily catch another BadMethodCallException" 2019-05-19 17:13:10 +00:00
jenkins-bot e66d30d37c Merge "Don't send empty array to Database::makeList" 2019-05-18 12:27:50 +00:00
jenkins-bot 75e5c907fc Merge "Remove problematic array type hint from hook handler" 2019-05-18 09:01:48 +00:00
Daimona Eaytoy 291c35cea0 Don't send empty array to Database::makeList
Check that the provided param is not empty, as otherwise
Database::makeList will throw and the exception will bubble up to the
user.

Bug: T222531
Change-Id: Icf5db25037a0d0a7b4076f21e7f1c9a6ee1d5a87
2019-05-18 10:55:26 +02:00
Thiemo Kreuz 1c5accd90a Remove problematic array type hint from hook handler
It's possible this parameter is null, as demonstrated in Id2caa44.

Change-Id: I69bf0d70552fb049aa1c93bb12bcb5cc9e457c53
2019-05-18 08:50:22 +02:00
jenkins-bot 6250eaea39 Merge "Add missing type hint to SpecialPage::execute()" 2019-05-16 15:19:22 +00:00
Thiemo Kreuz aba489a1f4 Add missing type hint to SpecialPage::execute()
[Also make use of the list() feature in one case I forgot before in
If2b6c95.]
 -> Changed to use direct array access by Daimona per inline comment.

Change-Id: I708dff30b6e00ccab3257b2e6fa5995eb9e30e0f
2019-05-16 14:31:54 +00:00
Daimona Eaytoy 44632f21a4 Temporarily catch another BadMethodCallException
This is the same as line 224, and I forgot to include this code path in
the same patch.

Bug: T187153
Change-Id: I28074680760a7070eb423b5eada1e35f829ed10a
2019-05-16 15:49:17 +02:00
jenkins-bot 99e821b125 Merge "Upgrade PHPCS and phan" 2019-05-15 19:42:42 +00:00
Daimona Eaytoy 311f68f6e8 Upgrade PHPCS and phan
Change-Id: Ibfb737e4552133d1ddd388e7410c6e1bc3a72e12
2019-05-15 19:06:04 +02:00
jenkins-bot 915bea466e Merge "Make use of PHP's list() feature where possible" 2019-05-15 15:06:20 +00:00
jenkins-bot c52850aae7 Merge "Add missing limits to explode() calls" 2019-05-15 15:06:18 +00:00
Thiemo Kreuz c6f20a64dd Add missing limits to explode() calls
This is fixing potential bugs where invalid strings with more than one
comma have silently been accepted.

Change-Id: Ib1e7d0c99973f243ef6faad6389bab688187c1cf
2019-05-15 16:14:12 +02:00
Thiemo Kreuz 3dece9ef8c Make use of PHP's list() feature where possible
Change-Id: If2b6c95a319800dd4944ecc0d7a8d3a819c846c1
2019-05-15 16:12:51 +02:00
Thiemo Kreuz fa3ce90851 Remove comments literally repeating what the code says
I find it obvious that a file called "AbuseFilterTokenizerTest" is a
"test for the AbuseFilterTokenizer class". A comment that is just
repeating this information is typicalls not helpful, but distracting
and a potential source of mistakes, e.g. when stuff is copy-pasted,
but the comment not adjusted.

Change-Id: I1d4cc06e9e5631955ff73bf675090cf9c33c9390
2019-05-15 16:04:32 +02:00
Translation updater bot 9cb58a4737 Localisation updates from https://translatewiki.net.
Change-Id: I5d5c31e4e1b151c1af2c7afdf1bdaa81767906fd
2019-05-15 09:11:22 +02:00
jenkins-bot 2d98b50a43 Merge "Remove call to deprecated User::isBlocked" 2019-05-14 13:33:39 +00:00
Thalia f23905c402 Remove call to deprecated User::isBlocked
Change-Id: Ibb7412f8aa08a745a211b9b0581ccb6b0ca9eff5
2019-05-14 13:14:57 +01:00
Translation updater bot 9b58deadc7 Localisation updates from https://translatewiki.net.
Change-Id: Iaf97a66213e8b0a93ba5e3196036881c17628607
2019-05-13 23:20:00 +02:00
Translation updater bot 830f3c4220 Localisation updates from https://translatewiki.net.
Change-Id: I0f89b49ecc8a4fcf612ae8c4ebd54e947345a8b8
2019-05-12 22:31:56 +02:00
jenkins-bot 673b0c8435 Merge "Localisation updates from https://translatewiki.net." 2019-05-10 07:22:27 +00:00
Translation updater bot d4c4b66393 Localisation updates from https://translatewiki.net.
Change-Id: I1792a888943c20398a55ef9ecbb49b4bbe03ad73
2019-05-10 09:17:27 +02:00
Translation updater bot c834491468 Localisation updates from https://translatewiki.net.
Change-Id: I794697930b5d3ec775900fbe82f5e3b121797ede
2019-05-09 08:45:47 +02:00
James D. Forrester bdf8c2a39b build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Bug: T220036
Change-Id: Ib35f5c3bd970233ab8b415c206cb8e606ac1f55b
2019-05-06 13:56:54 -07:00
Translation updater bot e25fbc5ee4 Localisation updates from https://translatewiki.net.
Change-Id: I2fb2cdc842c284cd71650b12de718d50a36551d1
2019-05-05 22:19:50 +02:00
Translation updater bot b3cd8790c7 Localisation updates from https://translatewiki.net.
Change-Id: I47104530cc7730c757040ecce159ad27d6f1dd2c
2019-05-03 22:20:47 +02:00
Translation updater bot 7189bbfee0 Localisation updates from https://translatewiki.net.
Change-Id: I7d6ae9858dd55ca0f266207db14679050e258e98
2019-05-01 22:29:25 +02:00
jenkins-bot 06cac3682e Merge "Replace deprecated cache-related functions" 2019-05-01 16:27:56 +00:00
Translation updater bot da29ae0575 Localisation updates from https://translatewiki.net.
Change-Id: Ic7db4b15cabcbe09c3ff6e62ba56d683aef535aa
2019-04-30 22:17:07 +02:00
Translation updater bot 0f2c95cc42 Localisation updates from https://translatewiki.net.
Change-Id: I0e756990238e3d12d3eb250a4f58ff7542efc9bd
2019-04-29 22:14:55 +02:00
Translation updater bot 46416c449e Localisation updates from https://translatewiki.net.
Change-Id: Ifc774f68a65eab84fbe3e6011e044717e06a29af
2019-04-26 22:26:56 +02:00
Translation updater bot d7170e1116 Localisation updates from https://translatewiki.net.
Change-Id: I7759b1107258fd695cfd7df440cd33f763d45fcd
2019-04-24 22:20:16 +02:00
Translation updater bot 875fa9a9e9 Localisation updates from https://translatewiki.net.
Change-Id: I248f204706ffe3d934599213c877fc19c6a3059a
2019-04-23 22:44:27 +02:00
Daimona Eaytoy 2276d8ed2a Refactor tokenizer caching
Split a method, use WAN cache so that we're enabled to use
getWithSetCallback, pass the "version" option there and adapt the test
to it.
Follow-up of I9b3bc36b552901bc6ca7609ee51e80be2979a9c4

Change-Id: I4dd81a723e2bdb828b90594ad66a3918d8ec5b6c
2019-04-23 19:38:10 +02:00
jenkins-bot cf491b18f7 Merge "Avoid sending stashing statsd data for bots in AbuseFilter::filterAction" 2019-04-23 14:08:38 +00:00
Aaron Schulz bc04dd93fe Avoid sending stashing statsd data for bots in AbuseFilter::filterAction
Change-Id: Ic06f64c22fc94665e58620a98e17264d48c97deb
2019-04-22 17:45:51 -07:00
Translation updater bot 9ae5f6b22c Localisation updates from https://translatewiki.net.
Change-Id: I18d0edc7c0aa4a9e27899c8e7609632bc68e2fe7
2019-04-22 09:22:08 +02:00
Translation updater bot 5ee6ec86b7 Localisation updates from https://translatewiki.net.
Change-Id: I35a3b88d44bcac062e5bc06197b535a040fe6ae1
2019-04-19 09:52:09 +02:00
jenkins-bot cdad0e1a14 Merge "Revert "Use string cast for Postgres compatibility"" 2019-04-18 15:31:51 +00:00
Daimona Eaytoy 9a315f2a6e Revert "Use string cast for Postgres compatibility"
This reverts commit 4ab12305f1.

Bug: T221357
Change-Id: Id0f26f48ad9904e73a8b65d76586957c2be93e82
2019-04-18 11:51:16 +00:00