5 commits

Author	SHA1	Message	Date
Daimona Eaytoy	d3a8491c3f	Change throttle selector to restore old functionality, overall improvement ... Long (sigh) explanation in T203587#4569698. Also, simplified the way TagMultiselect are generated, this one and the one for change tags. This new selector is back-compat both with the old textarea and the OOUI checkboxMultiselect; actually, this one is //fully// compatible with the old textarea. Add validation for throttle parameters and unit tests for validation (split from I976c95658cddb2585910b6f8a5f047aadc4e4d47). Added a trim when retrieving throttle identifier to allow syntax like 'ip, user'. Improved the message shown on history. Re-added the maintenance script to clean DB. As I wrote in the task, a review by two other people would be great, at least for the maintenance script (it could potentially break the DB). Bug: T203587 Bug: T203336 Bug: T203584 Bug: T203585 Depends-On: I3b2e763bd8835207dc5df1db43d3e1881e6961c3 Change-Id: I7831dbb0bab55807392ac1f7915d6cb0cb713593	2018-11-14 12:51:36 +01:00
Daimona Eaytoy	cbd57fe7a1	Simplify test parameters ... Instead of having lots of huge arrays, use a fixed one and only overwrite the needed parameters. Change-Id: I3b2e763bd8835207dc5df1db43d3e1881e6961c3	2018-10-12 16:40:44 +02:00
Daimona Eaytoy	0e2ae113fb	Improve parser coverage ... On the way to 100%... Bug: T201193 Change-Id: I5fd311f861acccb31f346da9acb379b0366488e7	2018-08-23 12:13:47 +02:00
Daimona Eaytoy	d35c42757c	Add missing @covers tag ... This should help with tracking code coverage and also explains some coverage discrepancies encountered while writing other tests. Bug: T201193 Change-Id: I8b20abc46c2d6c6f582953139b9a9f3710b2e4ea	2018-08-22 17:00:38 +02:00
Daimona Eaytoy	9440828d13	Add phpunit tests for creating and editing filters ... Adding the template for unit tests and some tests. These should cover all the validation failure cases. Bug: T42478 Depends-On: Ib7a0335fa7fb3b8a21765438a720205656c1ea09 Change-Id: I3fd0d627295d680ed33b1cbc730435df0446277f	2018-07-18 12:30:55 +02:00