wikimedia/mediawiki-extensions-AbuseFilter

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-23 21:53:35 +00:00

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	5fc30112c7	Optimize 'count()' function substr_count() is just as fast as looped strpos() when there are no matches, and gets faster as the number of matches increases. Note that this introduces a small change in behavior when the needle is composed of repeated substrings, e.g. 'asdasdasd' or 'aa', and haystack is such that the needle can be matched in overlapping positions, e.g. 'asdasdasdasd' or 'aaaaa'. The old implementation counted overlapping matches, the new one doesn't. I don't think this behavior was intentional and I don't think this change will cause any real problems. Change-Id: Icc905ca34bf08d63e969787a5e3c119d498bf878	2016-04-17 08:32:27 +02:00
Bartosz Dziewoński	7d83540527	Add some tests for behavior of 'count()' function Change-Id: I29a6c91d0780dc9a1eaee6d29d3b1f9c9c708df7	2016-04-17 08:18:29 +02:00
Marius Hoch	35747761fb	Allow running the AbuseFilter parser tests via phpunit I've also added myself to the credits file as I'm the only maintainer of this extension for a while now. Change-Id: Id998172ea2abd70b8243de9db1a96cc2cfa47a64	2013-07-08 19:22:43 +02:00

Author

SHA1

Message

Date

Bartosz Dziewoński

5fc30112c7

Optimize 'count()' function

substr_count() is just as fast as looped strpos() when there are no
matches, and gets faster as the number of matches increases.

Note that this introduces a small change in behavior when the needle
is composed of repeated substrings, e.g. 'asdasdasd' or 'aa', and
haystack is such that the needle can be matched in overlapping
positions, e.g. 'asdasdasdasd' or 'aaaaa'. The old implementation
counted overlapping matches, the new one doesn't. I don't think this
behavior was intentional and I don't think this change will cause any
real problems.

Change-Id: Icc905ca34bf08d63e969787a5e3c119d498bf878

2016-04-17 08:32:27 +02:00

Bartosz Dziewoński

7d83540527

Add some tests for behavior of 'count()' function

Change-Id: I29a6c91d0780dc9a1eaee6d29d3b1f9c9c708df7

2016-04-17 08:18:29 +02:00

Marius Hoch

35747761fb

Allow running the AbuseFilter parser tests via phpunit

I've also added myself to the credits file as I'm the only
maintainer of this extension for a while now.

Change-Id: Id998172ea2abd70b8243de9db1a96cc2cfa47a64

2013-07-08 19:22:43 +02:00

3 commits