Commit graph

5485 commits

Author SHA1 Message Date
Translation updater bot c48977da9d Localisation updates from https://translatewiki.net.
Change-Id: I7d421c3ac8e1a6b00b5832eca9edcdbfdbb4aa8c
2020-01-21 08:15:13 +01:00
Daimona Eaytoy d8cb1a33a0 Factor out get(Local|Global)Filters methods
This is a preparatory step for T234427 (although not strictly related),
and in the future it will enable us not to use the DB in several tests.

Change-Id: Id069f6e74f9c4df43b3a602d4224473d5ca68ed1
2020-01-20 17:13:06 +01:00
Max Semenik 8e7230076e Fix PHPUnit 8 warning
Bug: T192167
Change-Id: Ifbebbc3467eb0bf3f12cffc9e5601a1c94327bd9
2020-01-20 15:47:45 +00:00
jenkins-bot fdb85d5ef3 Merge "build: Upgrade phan" 2020-01-20 11:57:47 +00:00
Translation updater bot ede43ddc31 Localisation updates from https://translatewiki.net.
Change-Id: Ib18ce3168164322b4b845e58405755c3069fd2ac
2020-01-20 08:47:01 +01:00
Daimona Eaytoy 87459ec679 build: Upgrade phan
Depends-On: I6d538ce3ca7fd2d495c2bafbab7cc279da69db1c
Change-Id: Ic8c3a01a5c37fdf461f4fd5598e597eb9c9073d3
2020-01-19 18:48:51 +00:00
Translation updater bot 1206f464e7 Localisation updates from https://translatewiki.net.
Change-Id: Ic2a1c002efb7ff0e01a7e881a4d9d2c256c639bc
2020-01-17 08:36:01 +01:00
Translation updater bot f1457a10fa Localisation updates from https://translatewiki.net.
Change-Id: I9032b9a5ff34bef0b4f93d1fcb9d071147cfcc75
2020-01-16 09:28:57 +01:00
jenkins-bot 6ee44ae21a Merge "Fix generation of HTML vars, simplify tests" 2020-01-14 19:26:21 +00:00
Translation updater bot 71567b52a7 Localisation updates from https://translatewiki.net.
Change-Id: Ic68d4f485d151f47bdf3128b320a39e925c629b0
2020-01-14 10:58:21 +01:00
Translation updater bot 7e044dc49e Localisation updates from https://translatewiki.net.
Change-Id: I27b7efedac1801d6b98c861eca46e8c990ed8a50
2020-01-13 09:08:27 +01:00
Daimona Eaytoy 44ea3aa7f4 Fix generation of HTML vars, simplify tests
-new_html: also strip the "Transclusion limit" comment if present, and
anyway take it into account (as well as a "</div>"), which right now
prevent the PP limit report from being stripped as well.
-new_text: trim extra whitespace on the right, which is created when
stripping the aforementioned comments.

Also simplify the test for getEditVars, make it not blindly copy what
AFComputedVariable does.

Extra: kill a temporary variable.

These changes are partly taken from
I96785c6c5fdf381c21d5f8930ee12e706abb7f3f.

Change-Id: I2b4c84a3d9d0d17ce229088197b75781d5181b4f
2020-01-12 17:44:02 +00:00
Daimona Eaytoy 10c2fe7151 Stop using deprecated stuff with easy replacements
This patch is mostly replacing Revision::* constants,
Wikimedia\(restore|suppress)Warnings, and wfWikiId.

Change-Id: I13544cc3e12955a9376ccce3c120e2cee1f2ee2e
2020-01-08 14:59:30 +01:00
Translation updater bot 04f91a58cd Localisation updates from https://translatewiki.net.
Change-Id: I0b7e9927553db36e3884deb6360c5d0a10b3edf0
2020-01-08 08:41:29 +01:00
jenkins-bot f0e4c22b53 Merge "Simplify a query in AFComputedVariable" 2020-01-07 19:30:20 +00:00
Daimona Eaytoy c54e2fc180 Simplify throttling code
Change-Id: I54ebdf0bc61d5628d1755b75232a934358b112ff
2020-01-07 17:52:16 +01:00
Translation updater bot 539df33889 Localisation updates from https://translatewiki.net.
Change-Id: Ifd4f12d4badea3795398b4983aaddab7e2f75034
2020-01-07 08:47:07 +01:00
Translation updater bot 4d1bcc6d9d Localisation updates from https://translatewiki.net.
Change-Id: I336f56e58e4535ad477bfb359f21894215cbcb36
2020-01-06 08:47:04 +01:00
Translation updater bot f425d06548 Localisation updates from https://translatewiki.net.
Change-Id: If8fa7277655f0368eec64ca9a4af41316590034a
2020-01-03 08:44:28 +01:00
Translation updater bot e1edbbb5f9 Localisation updates from https://translatewiki.net.
Change-Id: Ibf38ed14f4e37ac881f5fc9ba429ae4809803afa
2020-01-02 08:56:38 +01:00
Translation updater bot 9552c187cc Localisation updates from https://translatewiki.net.
Change-Id: I8c1f45948f926fc2b343e6e7e10abaf9fc2c3701
2019-12-29 20:39:03 +01:00
jenkins-bot eef2760d7b Merge "Use explicit variarg for VariableHolder functions" 2019-12-27 10:24:31 +00:00
jenkins-bot 8fea62529b Merge "Fix AbuseFilterCachingParser violating return type constraint" 2019-12-27 10:04:57 +00:00
jenkins-bot a46c0e7359 Merge "Restore the ability to filter content model changes" 2019-12-27 10:02:50 +00:00
jenkins-bot 5c9fe8bd9b Merge "Always evaluate the offset when retrieving array elements" 2019-12-27 09:58:50 +00:00
Translation updater bot 3d9cbb5a94 Localisation updates from https://translatewiki.net.
Change-Id: I10b2ba68f1cfafea0e6f517b76b7f7259d432bd2
2019-12-26 16:17:47 +01:00
Translation updater bot e3d177ad60 Localisation updates from https://translatewiki.net.
Change-Id: I5ffc9ce13b6547f4654c26826a70af9e1077acb9
2019-12-24 10:00:26 +01:00
Daimona Eaytoy 8ad4ecd31d Always evaluate the offset when retrieving array elements
Even if the array is DUNDEFINED, we need to check the offset to ensure
that it's valid.

Bug: T237351
Change-Id: Ibfa360c4ae1d80abe14d9fdf66991b76cb5954df
2019-12-23 16:04:45 +00:00
jenkins-bot d43756a7f4 Merge "i18n: Rename msg key for abusefilter-view-oldwarning" 2019-12-23 12:16:57 +00:00
jenkins-bot 7fab4d3092 Merge "Clarify error message for non-literals passed to set/set_var" 2019-12-23 12:12:49 +00:00
jenkins-bot ce85c215f4 Merge "Ensure that a min/max arg count is available for all built-in functions" 2019-12-23 12:11:57 +00:00
jenkins-bot db3b4703c5 Merge "Don't use mFilter in ViewTestBatch" 2019-12-23 12:11:52 +00:00
Translation updater bot 0f3d4bddd5 Localisation updates from https://translatewiki.net.
Change-Id: I4cffbdcc8c68e48461c79eec1c6301b0dbcbef58
2019-12-22 17:39:06 +01:00
Translation updater bot edebec193b Localisation updates from https://translatewiki.net.
Change-Id: I76116dcdfb1aa59f9d4011f8a98c88038dfa7e49
2019-12-19 09:13:53 +01:00
Translation updater bot dff56324a3 Localisation updates from https://translatewiki.net.
Change-Id: I1d3ed06bdad1c664a6a4d5699f817653bb2a11f7
2019-12-18 09:24:08 +01:00
jenkins-bot f147164f66 Merge "Localisation updates from https://translatewiki.net." 2019-12-17 09:10:46 +00:00
Translation updater bot b231f1e921 Localisation updates from https://translatewiki.net.
Change-Id: I7a8bff42e49ddb7c23bd7fc125ca55c54676bb68
2019-12-17 10:06:15 +01:00
jenkins-bot 0ecf0bd3dc Merge "Fix silly bug in fixOldLogEntries" 2019-12-17 08:49:42 +00:00
Daimona Eaytoy 395bb9c7e7 Fix silly bug in fixOldLogEntries
If there are no faulty entries, exit early instead of running a query
with 'log_params' => [], which would throw an exception.

Bug: T228655
Change-Id: I6a0f0439d1f3e18f90075a36894f02090cac9202
2019-12-16 17:26:15 +00:00
Daimona Eaytoy b3e0529d55 Log deprecated vars in the cached phase in the new parser
For the new parser, xhgui shows that AbuseFilterParser::getVarValue is
taking up a lot of time; in turn, most of the time spent inside
getVarValue is used to log the use of deprecated variables. Hence, given
that:
 - We should keep the new parser performant
 - There are tons of deprecated variables out there and they likely
 won't be replaced
 - Having gazillions of debugLog entries doesn't help

log them only in the cached phase.

Bug: T234427
Change-Id: I2bfc692c829c3cbe889e5076f5205e2c99097087
2019-12-16 13:54:58 +01:00
Daimona Eaytoy a7dd20b040 Don't use mFilter in ViewTestBatch
In other View* classes, AbuseFilterView::mFilter contains the ID of a
filter, e.g. the filter being edited in ViewEdit. In ViewTestBatch,
however, it is a string containing some filter text. Hence, use a new
private property instead (without the legacy "m" prefix).

Change-Id: Ib22ce238aff4ca5ed57ba725ee9bff7f8c3d153b
2019-12-16 12:17:49 +01:00
Daimona Eaytoy b814c0827a i18n: Rename msg key for abusefilter-view-oldwarning
Thinking about it again, all messages on ViewEdit start with
abusefilter-edit. Also add a reference to the other message to
facilitate translations.

Follow-up: I3717d06d4a757684fe6622961391ae06b5bd3c38
Bug: T235590
Change-Id: I4cbaa2e92d22296f55a4b5ef0c633fe959fe9ea3
2019-12-16 10:56:30 +00:00
DannyS712 12efe4a0ad ApiAbuseLogPrivateDetails: private-details should be privatedetails
Bug: T240812
Change-Id: I263e3a57a48ab6a58e4c7f2181a914d9800a2fc5
2019-12-16 03:25:15 +00:00
jenkins-bot 62f7b574f1 Merge "Add a base class for parser transition" 2019-12-15 19:09:08 +00:00
libraryupgrader b47b6cea38 build: Updating grunt-banana-checker to 0.8.1
Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I51f571f920fde95575497cc7b98ef3b9bbc37d2f
2019-12-15 13:49:12 +00:00
Daimona Eaytoy f382304aae Add a base class for parser transition
Change-Id: I31282b8632c332b6d46a6bb4a42f57ac0d005b5f
2019-12-15 13:29:56 +00:00
Translation updater bot 57657ff317 Localisation updates from https://translatewiki.net.
Change-Id: I3771c60494d46074b661c77ecd256be6275647c9
2019-12-13 09:23:58 +01:00
Translation updater bot 42a76b4695 Localisation updates from https://translatewiki.net.
Change-Id: Iea311665c53fbe36858a11aef4ecf6efab1c4a00
2019-12-12 09:54:26 +01:00
Daimona Eaytoy c432f058fd Restore the ability to filter content model changes
Follows-up I3fb7b36ab38ca1544889a4c233b8ffdfc6c80936

Bug: T240485
Change-Id: I2e8337e6f505932a18a5bb5a0d97b9d6bc3f42c8
2019-12-11 19:42:45 +01:00
James D. Forrester cff9889549 Move test-only classes to new TestAutoloadClasses declaration
Bug: T196090
Depends-On: I88cf69663362fd599c20649b1df641907a02678d
Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 12:18:17 -08:00