Commit graph

57 commits

Author SHA1 Message Date
huji edabcbc6aa Separate parameters for the filter ID and localized filter name in AbuseFilter
Bug: 67254
Change-Id: I0343971b8be6984820ddf861a76132c9dd064829
2014-06-28 15:23:43 -04:00
Jackmcbarn 3ec370357e Support searching for multiple filter IDs
Allow a pipe-separated list of filter IDs to be entered on
Special:AbuseLog, returning all entries that were generated by any of the
given filters.

Change-Id: I170dc46ef51135fe711d0a76113d367033b67cc9
2014-03-22 02:21:38 +00:00
jenkins-bot a23ca862e4 Merge "always show diff link if available" 2014-01-09 13:40:20 +00:00
nullzero ecaa6dcb0d always show diff link if available
This patch makes a diff link appear in Special:Abuselog no matter a filter
is public or private. Because there is much information to figure out which
revision a filter catches, showing a diff link will make patrollers more
convenient without leaking more information.

Bug: 59695
Change-Id: I6a4432cbb41ae78583cc87355514f252984c1005
2014-01-09 04:57:44 +07:00
Jackmcbarn 2bea87c1d0 Restore the Details link in Special:AbuseLog
The fix for bug #50808 resulted in the Details link being hidden from the
log page as well as the details page. This restores it to the log page.

Change-Id: I651f0f41e0d603cbd28cbf920842d6bdd879f4b1
2014-01-07 21:09:30 +00:00
tonythomas01 d96f951afa Removed the "details" link if the user is already in details page
Removed the detailsLink creating code and assignment.
Cleaned Whitespace

Patch courtesy: Sakshi Bansal

Bug: 50808
Change-Id: I06a473550db79752aacb874f17f879f3b1ee1991
2014-01-03 23:40:17 +05:30
Kunal Mehta f7ed4cffee Restore b/c for pre-1.23 MediaWiki versions
Change-Id: Ibcc48b519271645f85f186ecb20fc6d2854aee06
Follows-Up: I67701856297927b94aa443a78376bae7d7860def
2013-12-27 01:32:24 -08:00
Kunal Mehta e7f8acf709 Replace usage of SpecialPage::getTitle with getPageTitle
Was deprecated in 1.23, see Icdcf5d5295ef5e7f08b1d403e0c123f78738fd40

Change-Id: I67701856297927b94aa443a78376bae7d7860def
2013-12-26 22:36:34 -08:00
Siebrand Mazeland b384fe8d8f Declare class properties, update docs
Based on static code analysis.

Change-Id: Ibafe33b6327ab72429ba961079af40039fb41cbf
2013-11-06 16:12:37 +00:00
Simon Walker 938d101711 Add links to abusefilter-edit-done
This adds a link to the diff of the edited filter, and a link to the filter
itself.

Bug: 52590
Change-Id: If741756ef398a61ae0fcd809eaee5a040ac8ca3d
2013-10-07 13:17:07 +01:00
jenkins-bot 666db2e7ef Merge "Make global AbuseFilters searchable on Special:AbuseLog" 2013-07-10 17:17:13 +00:00
Marius Hoch 433da007e0 Make the links in Special:AbuseLog plainlinks
Those shouldn't have the external link icon set

Change-Id: I308c3b0d4ce2e19a1046bf2c16e9168bfcd5c66c
2013-07-10 14:55:00 +00:00
Marius Hoch d2a342788f Make global AbuseFilters searchable on Special:AbuseLog
Global AbuseFilters will be searchable using "global-123"
with this. Furthermore this patch fixes the visibility of
global AbuseFilter ids within the API module.

Bug: 51007
Change-Id: Ia6caba5ae3d727b778076ecdba500b4dc1d55b6f
2013-07-10 14:54:51 +00:00
Marius Hoch 6caff9d822 Link correct Page in AbuseLog for users who can't see details
Right now the extension tries to link a local page
with the given title if the user can't see filter
details instead of linking to the correct page on
the target wiki.

Change-Id: I6bd2ecc48d1c248655ed41fc5ba9e9f286037adc
2013-07-09 18:04:53 +02:00
MatmaRex 6756f6f936 Pass context when contructing DifferenceEngines
Change-Id: I926c910bf983ae023bfc0c20a9262a1bde452a17
2013-06-29 23:52:08 +00:00
Marius Hoch 8957c003ba Revert "Change AbuseFilter to use UserCache instead of user_text fields"
This reverts commit aaa256aa94.

Bug: 49918
Change-Id: I597cbc03e2ecc45cfcca632232d5bbb1ef7be9d8
2013-06-27 01:01:15 +02:00
MatmaRex ddb57635be SpecialAbuseLog: use DifferenceEngine::addHeader to render diffs
Not sure why it wasn't used, maybe because it does a little more
than the bare minimum we need here.

Change-Id: I5e604474849d1389fc4cc260c76cf80e4e466bf5
2013-06-25 17:25:14 +00:00
nischayn22 ca1bb852fb Added css class for hidden logs.
Bug 28247

Change-Id: Icd58fce8f11308ba44abd403c150ebf27a25e0ca
2013-04-22 01:27:17 +05:30
Aaron Schulz 05b38eb613 Merge "Change AbuseFilter to use UserCache instead of user_text fields" 2013-04-09 22:00:51 +00:00
Marius Hoch f835cba0c2 Restore compatibility with MW 1.20 and 1.19
Partly reverts I8e420f0259ef6c9e579f7a00beb58f28af9da37d (untested)

Change-Id: Ib8634a3178a626f50f1150661842c16dc26c9516
2013-04-01 19:54:39 +02:00
Siebrand Mazeland e87bb7a59c Replace 2 deprecated methods
Change-Id: I8e420f0259ef6c9e579f7a00beb58f28af9da37d
2013-04-01 11:05:08 +02:00
Alex Monk aaa256aa94 Change AbuseFilter to use UserCache instead of user_text fields
Change-Id: I51210ff91366a3a1610d34ca20e8966aaded89a0
2013-03-27 15:59:34 +00:00
Marius Hoch 233a850a08 Make AbuseLog searchable by IPv6 IPs
Bug: 39449

Change-Id: Ie331ec7ef3b461ae10f0e28fe50cb86684c6d3a0
2013-03-26 00:30:32 +01:00
Kunal Mehta d87d77db3f (bug 34946) Make afl_user_text availible as $9 for log entries
This would allow for external lookup tools to be linked in the log entry itself

Change-Id: Ia484ad2aedf22a6a22172e6f752165cc0cab4009
2012-12-16 04:21:13 -06:00
Kunal Mehta 71a3679553 (bug 42820) Abusefilter log makes "contribs" link blue even if user has 0 edits
Change-Id: I9f3c35f35a8923e6713caee5b60773ff2de73560
2012-12-14 08:21:14 -06:00
raymond 3f1b73e5f4 Run filter number through formatNum()
Change-Id: If95bbae4af3d4c5a35ee02f1adadc4040ef36009
2012-10-26 20:27:08 +02:00
Catrope 4b6c3b8a16 Merge "Nicer Special:AbuseLog URIs when using the form there" 2012-10-25 03:18:34 +00:00
Siebrand Mazeland 176227e721 Maintenance for AbuseFilter extension.
* Replace deprecated methods.
* Remove no longer needed function fnmatch().
* Remove superfluous newlines.
* Remove unused and redundant local variables and globals.
* Deglobalization.
* Update documentation.
* Fix incorrect return values or add FIXMEs when in doubt.
* Escape output in a few places where needed.
* Remove unneeded MEDIAWIKI constant checks.
* Fix various JSHint/JSLint issues.

Patch Set 11: Merged https://gerrit.wikimedia.org/r/24701 into
this one per Siebrand's request

Change-Id: I02ba4ce31b6aca5b7324114093f8ece143abc295
2012-10-09 22:26:45 +02:00
Marius Hoch ea7b8ac92c Nicer Special:AbuseLog URIs when using the form there
Make the GET URIs constructed by the form on Special:AbuseLog
nicer. Right now they're like Special:AbuseLog?title=Special%3AAbuseLog
(the title is useless as the form is already constructed with
action=/wiki/Special:AbuseLog).

Change-Id: Ibbc294431443730c5862eeadb806fbc091c5ed6d
2012-10-02 17:24:56 +02:00
csteipp 1973ea6714 Add Global Rules
* Update rules list view to show global rules toggle, global rules
* Update rule processing to get global rules from memcache, if no
rule exists, get them from the central database and store them in
memcache
* Delete global rule key whenever global rules are updated
* Add filtering for log by wiki on the central database, updated
table definitions to add index on afl_wiki
* Add global $wgAbuseFilterDisallowGlobalLocalBlocks so local wikis
can prevent global rules from locally blocking, removing or revoking
permissions.

* patchset 13: Include recommendations from Tim. Add db updates to
LoadExtensionSchemaUpdates hook.
* patchset 14: forgot to add new files

Change-Id: Id69a9d603f9679f838e8691c651a3e9d8461b422
2012-08-27 03:30:07 +00:00
Reedy fad1fe4c41 Call to a member function getVars() on a non-object in SpecialAbuseLog.php on line 284
Seen on wmf fatal log

Change-Id: I50eb4f9d1b19c8c39ede07e1149baf475cccaaaf
2012-07-24 14:50:01 +01:00
Demon 95536ef72c Merge "$sk is undefined. Swap for Linker::" 2012-07-18 18:21:51 +00:00
Werdna 61bd427108 Merge "Users able to view private logs should be able to search for them." 2012-07-17 23:03:23 +00:00
Reedy 1a3ac23777 $sk is undefined. Swap for Linker::
Change-Id: I79e19484ffa8ab0d1f3be838a3186e7499b907c1
2012-07-13 23:22:23 +01:00
Andrew Garrett 53aea9c0ce AbuseFilter: Resolve bug 18374, bug 28633.
* Store the revision ID associated with a log entry
 if the action is successful.
* Expose this as a diff link in the UI.
* Implicitly hide log entries if their
 corresponding revisions are also hidden.
* Includes scope for expanding to log entries if desired.

Change-Id: Ie2d43dd1bacf14289fdf0492bb22267590ee649d
2012-07-11 10:16:59 -04:00
Liangent ff4f28339f Users able to view private logs should be able to search for them.
Followup/fix 310ed92824.

Change-Id: I89644992cbce5af9dddd6366dac784d03ed707c1
2012-07-03 11:21:06 +08:00
Liangent 310ed92824 Add new user right: abusefilter-log-private
Now we can allow some users to view log entries of private abuse
filters, without assigning them the right to see how these filters
work. This feature is asked by the community.

Change-Id: Ic93856804da69d2e6cd8342e36584ae16b3a7974
2012-06-18 18:56:48 +08:00
Reedy 434a740ef8 Bug 35886 - AbuseLog broken with upgrade to mediawiki 1.20
Change-Id: I15217295d83c75254399e38633e965f4b230f83f
2012-04-11 14:45:57 +01:00
Sam Reed 69e582dc17 More documentation stubs
Fix Html::inputLabel to Xml::inputLabel

Fix up some deprecated code

Change-Id: If6503b1794d89666206802591094949e5d715ac1
2012-03-26 16:03:23 +02:00
Roan Kattouw 6c4bd57043 Revert r111217 (unreviewed rev in AbuseFilter) and its dependencies r113585, r113587, r113588, r113589.
All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
2012-03-21 19:41:11 +00:00
Sam Reed 05a9d4d061 More documentation stubs
Fix Html::inputLabel to Xml::inputLabel

Fix up some deprecated code
2012-03-11 20:51:54 +00:00
Andrew Garrett 5e4289ce4e AbuseFilter: Resolve bugs 18374, 28633.
* Store the revision ID associated with a log entry if the action is successful.
* Expose this as a diff link in the UI.
* Implicitly hide log entries if their corresponding revisions are also hidden.
* Includes scope for expanding to log entries if desired.
2012-02-10 23:41:05 +00:00
Sam Reed ea1cc05f99 Fix mixed whitespace in r107455 2012-01-06 17:52:15 +00:00
Mark A. Hershberger 4e8be82722 Bug 33380 - Details of actions caught by a private filter should be private
Author: Nikola Kovacs

Hide private information from logs
2012-01-03 17:29:10 +00:00
Mark A. Hershberger 21b1cefe81 r107451 - Add message to special page 2011-12-28 00:37:43 +00:00
John Du Hart a968ea2cd8 Followup r103298 which causes a fatal error 2011-12-23 20:23:29 +00:00
John Du Hart 7cf809bb0e Changes from r103817 2011-11-22 16:08:18 +00:00
John Du Hart 453af554b9 Added context where possible to main AbuseFilter class
Most of the rest cannot get a context since it originates from hooks with no context sources. Instead of just getting the main context we might as well wait for a proper solution.
2011-11-17 00:55:53 +00:00
John Du Hart 274dcd06a2 Pass one of converting AbuseFilter to use ContextSource
The main AbuseFilter class still needs to be fixed up, but that's a bigger job and I'm out of time
2011-11-16 05:34:24 +00:00
Raimond Spekking 4e578cac93 Run some filter IDs through formatNum() for better l10n 2011-10-17 07:56:05 +00:00