Commit graph

5169 commits

Author SHA1 Message Date
DannyS712 338341d097 When viewing old filter revisions, show abusefilter-view-oldwarning to users who cannot edit the filter
Currently, `abusefilter-edit-oldwarning` is shown to all users, but not all users are able to edit the filters, and thus the warning about editing isn't applicable to them.

Bug: T235590
Change-Id: I3717d06d4a757684fe6622961391ae06b5bd3c38
2019-11-12 11:36:44 +00:00
Translation updater bot 93dcea0043 Localisation updates from https://translatewiki.net.
Change-Id: I002d7a6729067b78855a708716a63d7cfbabac7c
2019-11-04 09:25:40 +01:00
jenkins-bot 5562aade87 Merge "Use PHP regexps instead of SQL to filter on Special:AbuseFilter" 2019-11-01 00:52:28 +00:00
Daimona Eaytoy 7bc70d116e Use PHP regexps instead of SQL to filter on Special:AbuseFilter
As the code comment says, and as it was suggested in
Iafe54285384bc28b3e8812b495166f2682d4571c, we were validating the
provided regexp as PCRE, but using it in SQL, which only supports POSIX.
Furthermore, we won't have to worry about cross-DBMS compat anymore.

Bug: T193068
Change-Id: If6d8717795b6c1dcf619a23363eb6144902cfaed
2019-11-01 11:26:17 +11:00
Translation updater bot 61742d946e Localisation updates from https://translatewiki.net.
Change-Id: Ia909ee4552530bd21da4c5e1fec174bcde658468
2019-10-31 09:24:25 +01:00
Petr Pchelko 915b9a1538 Remove usages of deprecated User methods
Bug: T220191
Change-Id: I54e20870a32ff98b41a98495694ff563c4c4c5ca
2019-10-30 12:51:01 +00:00
Translation updater bot e3cffb465d Localisation updates from https://translatewiki.net.
Change-Id: Ide766b61933462b10dfd8c6d2aafb93afa75d070
2019-10-30 09:30:27 +01:00
Daimona Eaytoy 03b3a555ba SECURITY: Check visibility for each version in ViewDiff
Instead of checking if the filter is currently hidden, check the
visibility for each version and, if the user cannot see private filters,
only show the diff if none of the revision is hidden.
Also avoid showing a "diff" link if the user cannot see it.

Bug: T104807
Change-Id: Ie23e8234ae550273bf3f6f9c5ac45b7fc54eec2a
2019-10-28 15:32:00 -05:00
Translation updater bot c3e78ced15 Localisation updates from https://translatewiki.net.
Change-Id: I78563bb06749bdf44aab9539f7c7bbc3204ba9b9
2019-10-28 14:53:16 +01:00
Translation updater bot 037f037995 Localisation updates from https://translatewiki.net.
Change-Id: If929688a7909e9e110a72f7d344fa213ab16a8e3
2019-10-25 09:15:41 +02:00
Translation updater bot aa5c8d8ae3 Localisation updates from https://translatewiki.net.
Change-Id: I31c266b6342164a516f156a843c692eaf9b78002
2019-10-24 10:37:49 +02:00
Daimona Eaytoy 3a9eac9ad5 Unbreak filter edit form
In Ib7427e15f673a575738489476e604c387f449ddd, I thought that $parameters could've only been null if $action wasn't
enabled, but actually, they're null even if the action is just not set.
Which is true for all actions when creating a new filter, and all
non-set actions when editing an existing one.

Hence, revert the part that touched ViewEdit.

Also add a selenium test to ensure that warn parameters are visible.

Bug: T236286
Change-Id: I8150baa077208eb1fc54ebc1d8415a243d0f3bd3
2019-10-23 18:50:44 +02:00
Translation updater bot cdee6802ea Localisation updates from https://translatewiki.net.
Change-Id: I9d7a230175216f5228571eadfd9f0d292656333e
2019-10-23 09:50:54 +02:00
Translation updater bot 25873c9cbe Localisation updates from https://translatewiki.net.
Change-Id: I750fdc2dd1ccd16073f5d2b6072dc40807f21e31
2019-10-22 09:11:08 +02:00
Translation updater bot 65e48fae59 Localisation updates from https://translatewiki.net.
Change-Id: I8fd625c0252a68bd2fafb3240956ecd6e3e9b2b5
2019-10-21 09:56:15 +02:00
libraryupgrader 08d3431130 build: Updating grunt-stylelint to 0.11.1
Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: Ia603aec7dd94a397867a24ebf721906d50b959ea
2019-10-20 23:04:43 +00:00
Thalia 63eb7eafb7 Use AbstractBlock setters and getters instead of deprecated properties
Change-Id: I01728f919254a9435f051af3fc390eb80ca8d17e
2019-10-20 00:35:00 +01:00
jenkins-bot af86fe62a4 Merge "build: Upgrade mediawiki-phan-config to 0.8.0" 2019-10-19 20:04:47 +00:00
Translation updater bot 2c51fb37e9 Localisation updates from https://translatewiki.net.
Change-Id: I4f3768315556119b0bcb8391085333d4d4851760
2019-10-16 20:37:22 +02:00
Translation updater bot 828f1d881c Localisation updates from https://translatewiki.net.
Change-Id: I0fa3509ad517b045d93835777ddc3f553b54fdaa
2019-10-16 10:36:44 +02:00
Translation updater bot 7bd97f6a13 Localisation updates from https://translatewiki.net.
Change-Id: Ic514113078f2f18297269ce445fd265216837df6
2019-10-10 09:30:09 +02:00
James D. Forrester 4d988471be build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: I7ef6ec1614718c016562281a166867ee3bd93df7
2019-10-09 18:34:07 +00:00
Daimona Eaytoy b9e4475985 build: Upgrade mediawiki-phan-config to 0.8.0
This is to verify that our CI is able to handle the new version.

Bug: T235049
Change-Id: Ib7427e15f673a575738489476e604c387f449ddd
2019-10-09 19:12:51 +02:00
Translation updater bot 347146ef8a Localisation updates from https://translatewiki.net.
Change-Id: Ib6d909ccb9160f7ecc1c4888325806df023502c8
2019-10-09 09:15:59 +02:00
Max Semenik b3d11b48cb tests: setExpectedException() is deprecated
Bug: T192167
Change-Id: I899a8f03c6cc1f79f58bec09c2d8b2ba10b895d8
2019-10-08 16:31:15 -07:00
Translation updater bot be360b520d Localisation updates from https://translatewiki.net.
Change-Id: I49f60d52fc29c84916ac282ea641de462366dc8f
2019-10-08 09:30:51 +02:00
Translation updater bot 0465d64a5f Localisation updates from https://translatewiki.net.
Change-Id: Ice510a596cdeeac02f4fa075f7341d5b8571396e
2019-10-07 09:07:26 +02:00
jenkins-bot feae26116a Merge "Remove disabled variables deprecation" 2019-10-04 20:07:10 +00:00
jenkins-bot c6ee722273 Merge "Remove AFPData::dup" 2019-10-04 19:42:52 +00:00
jenkins-bot 9ab13cf24b Merge "Replace array_map with foreach" 2019-10-04 19:42:49 +00:00
Daimona Eaytoy c7fa503e9b Remove AFPData::dup
The method, which simply duplicates an AFPData instance, is only used
when casting types, to return a different instance when the object
already has the desired type.
However, nothing is assuming that, so we can just return the original
instance and save some time.

Bug: T234427
Change-Id: Id8067b418a00260ceead35f234e55268390699ab
2019-10-04 19:15:08 +00:00
Željko Filipin 0a95a6572c Selenium: make it possible to run daily Jenkins job targeting beta cluster
Bug: T199113
Change-Id: Idce6d7d014ab5bb0c9602d5f1e5321cd9c0d1615
2019-10-04 16:23:22 +02:00
Daimona Eaytoy 328dbc99c7 Remove disabled variables deprecation
I just realized that the parser is already throwing if it finds a
disabled variable. Hence, all calls to getVar with a disabled var are
from old entries and the like, and we don't care.

Bug: T234048
Change-Id: I39429d286575df91108a4119177a0d3aef181d0b
2019-10-04 15:03:08 +02:00
Translation updater bot 5b8502caa4 Localisation updates from https://translatewiki.net.
Change-Id: I22dac70a8802c17512d7588114faaf761798c5c4
2019-10-04 09:27:03 +02:00
Daimona Eaytoy 703835e835 Drop HHVM support
Change-Id: Ib7ccb4f68278ba8ca009e9d18e9d8b127f799cde
2019-10-03 12:27:18 +00:00
Translation updater bot 3985f979ea Localisation updates from https://translatewiki.net.
Change-Id: I1b24aff7cc326bb1e3276f21d99b617f60b6ef43
2019-10-03 10:02:29 +02:00
Daimona Eaytoy 337771f83b Replace array_map with foreach
This is a micro-optimization, but IMHO it's necessary. The AF parser
code is executed for every active filter, for every
edit/move/deletion/accountcreation. In PHP, foreach is usually faster
than array_map. Especially in the case of variadic functions potentially
taking hundreds of strings, foreach will consume less time.

Bug: T234427
Change-Id: I1beedf419a6637a9a3dd668635645df950ceda21
2019-10-02 11:29:19 +00:00
Translation updater bot 188742a07e Localisation updates from https://translatewiki.net.
Change-Id: Iec3bf5ff81ce46cd56557aa51a61201d7d028f69
2019-10-02 09:17:45 +02:00
Translation updater bot 39194f3ca0 Localisation updates from https://translatewiki.net.
Change-Id: Ie29a92e5958aba71c9f1ba46f7e5b0c9fea20cb1
2019-09-30 09:15:15 +02:00
Krinkle a532874ee2 Update StringUtils::isValidRegex() call to isValidPCRERegex()
This follows-up 8587576655 (AF) and efbfa0a727 (core). The
method was recently introduced within the 1.34 cycle but
renamed following late CR feedback.

Change-Id: I9986deb080791c6266c6c60cc91022266ad9b5e5
2019-09-28 19:12:11 +00:00
jenkins-bot 952dfa0bb4 Merge "Hard-deprecate requesting disabled variables" 2019-09-28 18:25:24 +00:00
Daimona Eaytoy 0ae24d5489 Hard-deprecate requesting disabled variables
This also includes the filter ID. If the filter ID is not available, it
means that the user is using stuff like /tools, and they'll immediately
see the error.

Bug: T234048
Change-Id: I44a37d98c80df910b0c466fbd464e69042770c0c
2019-09-28 17:57:02 +00:00
jenkins-bot 0e30c1c34e Merge "Add new schemas for splitting afl_filter" 2019-09-27 15:41:06 +00:00
Translation updater bot 8ba9251761 Localisation updates from https://translatewiki.net.
Change-Id: I9298ac154cb12174f15345fff49e8a73ecf92808
2019-09-26 09:11:55 +02:00
Translation updater bot 097fdd2af4 Localisation updates from https://translatewiki.net.
Change-Id: I662b9a984d10b356dbc4eb5afdf895f8e44d4a59
2019-09-25 09:21:39 +02:00
jenkins-bot eb91e1cb41 Merge "Fix params to ParserOutputStashForEdit" 2019-09-24 09:31:34 +00:00
Translation updater bot 1e538e0225 Localisation updates from https://translatewiki.net.
Change-Id: I445eb837dabe772b84738c62c1478d50c22ac27a
2019-09-24 09:54:01 +02:00
Daimona Eaytoy 0119108ee7 Fix params to ParserOutputStashForEdit
$summary and $user are always guaranteed to be passed, and $user is
guaranteed to be a User object. Hence, update the hook handler to
reflect that.

Change-Id: I3a7fcb074b460b77210de5a6bad43f500aff3249
2019-09-23 23:33:51 +02:00
Translation updater bot 8dbbe859e7 Localisation updates from https://translatewiki.net.
Change-Id: I5afd496088aa23f026e5bc08a642a7f3ae18546e
2019-09-23 09:22:33 +02:00
Daimona Eaytoy 9a6dd1307c Add new schemas for splitting afl_filter
It'd be great if we could get this included in 1.34.

Bug: T220791
Change-Id: I62d429d0eb6a7adc51cc37fe18f878077f85a006
2019-09-22 16:04:45 +00:00