6 commits

Author	SHA1	Message	Date
Daimona Eaytoy	3365a648f2	Reject filters with invalid groups ... It is currently possible to save a filter with an invalid group, if you manually change the form data. So prevent this by validating the group before saving. Change-Id: I03f80b8c6ab583a357273f7b2679a424ac784db7	2021-02-27 16:01:09 +00:00
Daimona Eaytoy	a9722868ab	Improve coverage of parser-related classes ... Change-Id: I229c528505f0208b34f37d8c969450731e5a08a3	2021-01-15 03:16:48 +00:00
Daimona Eaytoy	7c1d1c6d7d	Return warnings from the parser, add warning for catch-all regexps ... This commit introduces some boilerplate for emitting warnings from the AbuseFilter parser, and also code for showing these warnings in the ace editor. Adding new warnings should be as simple as appending to AbuseFilterParser::warnings (and adding the relevant i18n). Bug: T264768 Bug: T269770 Change-Id: Ic11021b379f997a89f59c8c0572338d957e089a6	2020-12-18 18:22:41 +01:00
Matěj Suchánek	d76affb1db	Move ChangeTags stuff to separate namespace ... Change-Id: I6d7bed0e62f001f82c00a3528cc0018388c9c70e	2020-11-27 15:13:34 +00:00
Matěj Suchánek	872b6118f4	Introduce ChangeTagValidator service ... Just moving code around. Without a unit test because DI coverage of change tags in core isn't available yet. Change-Id: Iac861e1e24dae13581b8d9173357a1d6c94be88a	2020-11-27 15:11:48 +01:00
Daimona Eaytoy	1bcfdc3b13	Introduce a FilterValidator ... This moves a lot of things away from the AbuseFilter class. There's a nasty static dependency on ChangeTags, but it's very limited anyway, and it's going to be fixed once T245964 is resolved. Change-Id: Ia7df4b4d3289c2722323f59ceecf3fdd38277785	2020-11-18 01:41:31 +00:00