Commit graph

6980 commits

Author SHA1 Message Date
Matěj Suchánek f142fee102 Make a separate method for ManualLogEntry construction
This step is a simple copy-paste. In the next step,
we will change the code a bit.

Change-Id: Id303a5da33ce0bbc0b58656a3f935f6f4c02d84c
2022-07-31 12:39:43 +00:00
Matěj Suchánek cb48a6b3ae Add regression test for abuse log entries
We don't have one, and we will need it for
Ib58193927bc8254d36a8de0fd1b5f9fba68a0cb0.

Change-Id: I55c52df8aa0786f5c73a0c957a06a01f9cb86fcd
2022-07-31 14:33:29 +02:00
jenkins-bot 9b62938507 Merge "Add regression test for RunVariableGenerator" 2022-07-31 12:07:15 +00:00
jenkins-bot 2cff210d31 Merge "Use UserIdentity in VariableGenerator::addEditVars" 2022-07-30 13:55:24 +00:00
Umherirrender 7e8162c705 Special:AbuseFilter: Include primary key for unique pagination
A unique column is needed in the order to ensure the next offset is
correct and does not skip items

As mention in the doc for IndexPager::getExtraSortFields the extra
columns are not for pagination, only to help the optimizer building a
better query plan by mention denormalized columns.

Bug: T191694
Change-Id: I9fb9f848a0b165dbaa0a2b31d9504324f43578de
2022-07-29 17:38:13 +02:00
Umherirrender 081a8e3c3c Add LinkBatch to Special:AbuseFilter/home and /history
Combine the check for red/blue user/talk links into one database query
This can improve the performance of the page view when many filters
from many different users are linked

Change-Id: I0b87ee15ecee4cecd5d5d6164e8c18e1b788ecd1
2022-07-29 13:56:03 +02:00
Umherirrender da4bc8643a Use UserIdentity in VariableGenerator::addEditVars
Change-Id: If0a65d7a86de776e6499d43949bfb217f20d9b07
2022-07-29 12:55:52 +02:00
jenkins-bot f13f3dcd2c Merge "Call IContextSource::getAuthority instead of IContextSource::getUser" 2022-07-29 10:25:23 +00:00
Translation updater bot 4d44f0cea2 Localisation updates from https://translatewiki.net.
Change-Id: Id9dac05709cdd15f979c121a7849ace0fe2ab7be
2022-07-29 08:52:03 +02:00
jenkins-bot 9ea6c5dd8a Merge "Remove deprecated static methods" 2022-07-28 22:40:57 +00:00
Translation updater bot 95d7a28d00 Localisation updates from https://translatewiki.net.
Change-Id: I4a44355e50552620e89b1bd9fbf4e7c4fb20ac42
2022-07-28 08:55:37 +02:00
Matěj Suchánek 3914c913e3 Remove deprecated static methods
They are unused in Wikimedia code (finally).

Change-Id: I74c81d950d992552d3edf184b5eecc46e5e2c567
Depends-On: I62533e21d2bc1a22c3fcba4c7c650ca9d95700ef
Depends-On: I95ce9897d89213e358c436135278b729f0adc3a2
2022-07-27 13:01:10 +02:00
Translation updater bot 678d434626 Localisation updates from https://translatewiki.net.
Change-Id: I81bcdd80fa46512b088f0a74075ee1dce404c2bf
2022-07-26 08:24:24 +02:00
Translation updater bot 8320b3222c Localisation updates from https://translatewiki.net.
Change-Id: I6fdc0c3e2d64f0fd81883544b76ce664e0e13dd9
2022-07-25 08:32:27 +02:00
Translation updater bot 5e8d67919d Localisation updates from https://translatewiki.net.
Change-Id: I2ef98aec44d1323d2cb63b01087fb7f04b1cc90d
2022-07-21 09:02:40 +02:00
jenkins-bot 42165168a6 Merge "VE integration: Remove "unrecoverable" errors" 2022-07-20 13:53:02 +00:00
Translation updater bot 3485b5f2b3 Localisation updates from https://translatewiki.net.
Change-Id: I8e619c736891d6ab4fc57295a218f08dbca38bc2
2022-07-20 08:26:51 +02:00
Bartosz Dziewoński 4b0bc0f47d VE integration: Remove "unrecoverable" errors
Bug: T307330
Depends-On: I9680cc416da5b27881aeb3502f506dcb5d4bb71f
Change-Id: Ie133c74072fa3e9ab934a6a8b2052d25b68d1cbf
2022-07-19 21:46:48 +02:00
Translation updater bot 616bafa80c Localisation updates from https://translatewiki.net.
Change-Id: Iec3d694d3dd7b7ea58538c90dc3f3e505cb31beb
2022-07-19 08:15:32 +02:00
Translation updater bot f063d4224f Localisation updates from https://translatewiki.net.
Change-Id: I7d338d5fc21c9c4ff2659af3bb2dc4032a329ee1
2022-07-18 08:13:25 +02:00
Matěj Suchánek 62e5509772 Add regression test for RunVariableGenerator
Test that null edits do not trigger filters, but sole
content model change does.

Also do some cleanup in AbuseFilterConsequencesTest.
For better isolation, do not access the service
container and do not initialize objects in
the constructor.

Change-Id: I043ecb312226a69d1f485a8382d558ccb899a270
2022-07-16 11:48:42 +02:00
jenkins-bot faf77888ad Merge "Try to unbreak tests on sqlite" 2022-07-16 09:38:44 +00:00
Matěj Suchánek 6b0a8117b8 Try to unbreak tests on sqlite
Change-Id: I65cf163c8698a7457986ef2354c8fa9e30dc47c5
2022-07-16 07:02:48 +00:00
Translation updater bot 16d1ebffc4 Localisation updates from https://translatewiki.net.
Change-Id: Iecd0b763fc160aa700e8524220026a4c94930d2f
2022-07-15 08:42:01 +02:00
Translation updater bot d3c980e62d Localisation updates from https://translatewiki.net.
Change-Id: Ibb65b8b63dac8b81c1cb7a1aba02c73c6991898d
2022-07-14 08:47:09 +02:00
Umherirrender 11386c312d postgres: Fix changeNullableField calls
Follow-Up: I97cb12e6aa25d75ea24e187174db2fe88e5ce790
Change-Id: I61b8e102fd5041685941d89995f54a23ff5509c8
2022-07-13 22:13:48 +02:00
jenkins-bot be1e087474 Merge "tests: Improve tests for postgres" 2022-07-13 18:56:26 +00:00
jenkins-bot eb20298739 Merge "Convert to abstract schema" 2022-07-13 16:47:22 +00:00
libraryupgrader 95d4dc528a build: Updating grunt-banana-checker to 0.10.0
Change-Id: I0149c6a7083891eee6cd101324446e0152fab979
2022-07-11 21:15:23 +00:00
Translation updater bot 11fe5776ed Localisation updates from https://translatewiki.net.
Change-Id: I34c8cd355728f5a03db7ef50c856fbea86acfc5a
2022-07-11 09:48:41 +02:00
Umherirrender da7683bcbc tests: Improve tests for postgres
Change-Id: I9720b6c7d096ae8415c00eb0ac1ddc461ea0a8dc
2022-07-09 21:40:27 +00:00
Umherirrender 3cb0195c4c PurgeOldLogIPData: Fix quoting for postgres
Use addQuotes to quote the empty string instead of hard-coding "",
which not working in postgres

Change-Id: I15bf8c840b3a34dff4db976cb11e740209322bb9
2022-07-09 23:40:15 +02:00
jenkins-bot 4329c21ba7 Merge "Delimit namespace and title text in warning keys" 2022-07-07 18:40:24 +00:00
dreamyjazz 0bb914c482 Add a space between the checkbox and timestamp in Special:AbuseLog
Add a space between the checkbox (shown for users who can hide abuse
filter entries) and the timestamp so that it looks nicer.

Change-Id: I6e495f8cb56ad8f0b53f06d2aecb8ac34b16ff25
2022-07-07 15:51:34 +01:00
Translation updater bot a27c066d59 Localisation updates from https://translatewiki.net.
Change-Id: Id5e074659c73e730e7f362caefbcd54b74b8ad2f
2022-07-07 08:49:33 +02:00
Translation updater bot ebfb84e954 Localisation updates from https://translatewiki.net.
Change-Id: I1ac612bac0321b049e94a710bc455a2a29b79716
2022-07-06 10:16:47 +02:00
jenkins-bot c3c70f7fa0 Merge "FilterProfiler: use WRStats" 2022-07-06 00:05:15 +00:00
Tim Starling cdf2f474e8 FilterProfiler: use WRStats
A new core facility written for this use case.

Bug: T310662
Depends-On: I26b1cdba0a06ad16ad8bb71b455e1b6180924d17
Change-Id: I2b902d034a8c3308c0ba9878b69e873ca8fbda52
2022-07-06 09:35:08 +10:00
jenkins-bot ac256f9557 Merge "Add the ListToggle to Special:AbuseLog for users who can hide entries" 2022-07-05 12:14:25 +00:00
Translation updater bot 1a8fed15e8 Localisation updates from https://translatewiki.net.
Change-Id: I7312ae538681dafde019a05b6a623efb4b99e75e
2022-07-04 08:21:01 +02:00
dreamyjazz 13e6c1c06a Add the ListToggle to Special:AbuseLog for users who can hide entries
Add the ListToggle provided in core's ListToggle.php to
Special:AbuseLog when a list of abuse filter entries are being
shown and the user can hide abuse filter entries. This will allow
them to select multiple checkboxes to hide at once (without having
to shift and selecting the first and last).

Bug: T311954
Change-Id: I1aa4fa3fa7016a5d9ae4a904c151011743d2c8ed
2022-07-03 16:56:03 +01:00
Umherirrender dc4dd928b7 Call IContextSource::getAuthority instead of IContextSource::getUser
Change to use Authority object where possible
to use the interface instead of implementation

Change-Id: I90ef126b3d799c3fc27467a4ffe671785c446d3e
2022-07-03 16:37:18 +02:00
jenkins-bot 2709583b52 Merge "Clean up AbuseFilterViewExamine and AbuseFilterExaminePager" 2022-07-03 14:16:57 +00:00
Matěj Suchánek be247401bb Clean up AbuseFilterViewExamine and AbuseFilterExaminePager
Move most stuff from the pager to the view class to untangle
circular dependency. Declare class properties as private.
Leave input validation to the form.

Change-Id: Ia8b1a9d08af9c0cac23b34f6bbbe2c44d01f6c8c
2022-07-03 11:29:43 +02:00
Matěj Suchánek e7492a230f Replace unnecessary use of User
In action=abusefilterunblockautopromote, leave UserIdentity
instantiation to the parent. Note that this changes the "code"
in the response from "baduser_user" to "baduser".

Change-Id: I97d2bf3fa3c5486e461823f840cad2763e1bcfea
2022-07-02 23:58:08 +00:00
Matěj Suchánek 799e1db093 Convert remaining permissions checks to use Authority
Change-Id: I5e996cac37bc806db6c3d7ad5c666a606cd79236
2022-07-02 14:49:47 +02:00
jenkins-bot f3ec0063ac Merge "Migrate AbuseFilterPermissionManager to authority" 2022-07-01 22:08:17 +00:00
DannyS712 139ca18efe Migrate AbuseFilterPermissionManager to authority
Almost all callers already provide an Authority in the form
of a User object, so mostly just need to change the typehints

Depends-On: I58661943c7e1acb6ff09798ee1a30be0fde3f459
Change-Id: I2ad86859c8194c14d7331f58db62b7cff4698085
2022-07-01 06:58:17 +00:00
Translation updater bot 543f2c81f3 Localisation updates from https://translatewiki.net.
Change-Id: I14f186548cf1fe8f64f10e0891257e4189e8166e
2022-07-01 08:51:32 +02:00
jenkins-bot 27c19027de Merge "Show syntax error message in an error box on Special:AbuseFilter/test" 2022-06-30 21:20:00 +00:00