Commit graph

2 commits

Author SHA1 Message Date
Thalia 0ea7944ea3 Add documentation about running RemoveProtectedFlagFromFilter
Why:

* The maintenance script RemoveProtectedFlagFromFilter was added
  to fix a mistake where a filter was 'protected' that shouldn't
  be.
* There are certain steps that should be taken before and after
  the script is run. These are not yet documented.

What:

* Document that the script should only be run after checking that
  no data will be leaked.
* Document that a note should be left for filter editors to
  explain when and why the script was run.

Bug: T380290
Change-Id: Iffe35c87782fdd499937565f1f8da62bfd36f93d
2024-11-25 12:05:33 +00:00
Thalia 91456d79b2 Add RemoveProtectedFlagFromFilter maintenance script
Why:

* Protected variables were introduced to support temporary accounts
  so that temporary users could be filtered based on their IP address.
* Filters that use protected variables are protected in order to
  preserve privacy. This can't be undone.
* It is mistakenly possible to protect a filter that does not use
  protected variables (T378553). We need a mechanism to fix these
  mistakes.

What:

* Introduce a maintenance script that takes a filter ID and, if the
  filter is protected, sets it to unprotected while maintaining any
  other existing privacy levels.

Bug: T378551
Change-Id: I4dfe3970221397d5be5ea0697490d8c8e3726adf
2024-11-15 13:13:38 +00:00