wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-09-23 10:18:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow users with 'abusefilter-view-private' to view history/diff of private filters

Browse source 
These pages are read only pages so it's better to let users with
'abusefilter-view-private' to view history and diff of private filters
as 'abusefilter-modify' is a read+write right.

Bug: T126129
Change-Id: I9e15326c8d681000ab13ef8a50fa0eed4c24dbe6
This commit is contained in:
Glaisher 2016-04-26 21:13:55 +05:00
parent 9c01e7c0e4
commit d043933791
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Views/AbuseFilterViewDiff.php
View file

@ -99,9 +99,9 @@ class AbuseFilterViewDiff extends AbuseFilterView {
$newSpec = $this->mParams[4];
$this->mFilter = $this->mParams[1];
if ( AbuseFilter::filterHidden( $this->mFilter ) &&
!$this->getUser()->isAllowed( 'abusefilter-modify' ) &&
!$this->getUser()->isAllowed( 'abusefilter-view-private' ) ) {
if ( AbuseFilter::filterHidden( $this->mFilter )
&& !$this->getUser()->isAllowed( 'abusefilter-view-private' )
) {
$this->getOutput()->addWikiMsg( 'abusefilter-history-error-hidden' );
return false;
}

8
Views/AbuseFilterViewHistory.php
View file

@ -17,9 +17,9 @@ class AbuseFilterViewHistory extends AbuseFilterView {
}
# Check perms
if ( $filter &&
!$this->getUser()->isAllowed( 'abusefilter-modify' ) &&
AbuseFilter::filterHidden( $filter ) ) {
if ( $filter && AbuseFilter::filterHidden( $filter )
&& !$this->getUser()->isAllowed( 'abusefilter-view-private' )
) {
$out->addWikiMsg( 'abusefilter-history-error-hidden' );
return;
}
@ -234,7 +234,7 @@ class AbuseFilterHistoryPager extends TablePager {
$info['conds']['afh_filter'] = $this->mFilter;
}
if ( !$this->getUser()->isAllowed( 'abusefilter-modify' ) ) {
if ( !$this->getUser()->isAllowed( 'abusefilter-view-private' ) ) {
// Hide data the user can't see.
$info['conds']['af_hidden'] = 0;
}