Add deprecated variables to PHPUnit tests

Check a bunch of them, they should be computed and be identical to the
ones with new syntax.

Bug: T173889
Depends-On: I5c370b54e6516889624088e27928ad3a1f48a821
Change-Id: I276913a98e06b5f2ff1c5f5f3ba5bcc7b1e8c997
This commit is contained in:
Daimona Eaytoy 2018-08-21 16:46:18 +02:00
parent 6bc630cfef
commit cd30d5146f
2 changed files with 5 additions and 4 deletions

View file

@ -6,6 +6,7 @@
<rule ref="Generic.Files.LineLength">
<exclude-pattern>AbuseFilter\.alias\.php</exclude-pattern>
<exclude-pattern>AbuseFilterParserTest\.php</exclude-pattern>
<exclude-pattern>AbuseFilterConsequencesTest\.php</exclude-pattern>
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>

View file

@ -79,7 +79,7 @@ class AbuseFilterConsequencesTest extends MediaWikiTestCase {
],
2 => [
'af_id' => 2,
'af_pattern' => 'action = "move" & moved_to_title contains "test"',
'af_pattern' => 'action = "move" & moved_to_title contains "test" & moved_to_title === moved_to_text',
'af_enabled' => 1,
'af_comments' => 'No comment',
'af_public_comments' => 'Mock filter for move',
@ -99,7 +99,7 @@ class AbuseFilterConsequencesTest extends MediaWikiTestCase {
],
3 => [
'af_id' => 3,
'af_pattern' => 'action = "delete" & "test" in lcase(page_prefixedtitle)',
'af_pattern' => 'action = "delete" & "test" in lcase(page_prefixedtitle) & page_prefixedtitle === article_prefixedtext',
'af_enabled' => 1,
'af_comments' => '',
'af_public_comments' => 'Mock filter for delete',
@ -114,7 +114,7 @@ class AbuseFilterConsequencesTest extends MediaWikiTestCase {
],
4 => [
'af_id' => 4,
'af_pattern' => 'action contains "createaccount" & accountname rlike "user"',
'af_pattern' => 'action contains "createaccount" & accountname rlike "user" & page_title === article_text',
'af_enabled' => 1,
'af_comments' => '1',
'af_public_comments' => 'Mock filter for createaccount',
@ -257,7 +257,7 @@ class AbuseFilterConsequencesTest extends MediaWikiTestCase {
],
12 => [
'af_id' => 12,
'af_pattern' => 'page_title == user_name',
'af_pattern' => 'page_title == user_name & user_name === page_title',
'af_enabled' => 1,
'af_comments' => '',
'af_public_comments' => 'Mock filter for userpage',