wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-24 06:03:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make Special:AbuseLog pager more efficient

Browse source 
* Use LinkBatch for local page existence queries needed by Linker
* Cache user links as Linker results in duplicate User::getEditCount query for each row
* Store result of SpecialAbuseLog::isHidden() for each row to minimize calls to
   Revision::fetchFromConds
* Use Linker::linkKnown instead of link when linking to special pages

Example improvements seen locally:
 Before: 1152 queries
 After: 243 queries

Change-Id: I22ba68710f3ecea5b48b25d631da84c6445fcb97
This commit is contained in:
Glaisher 2016-08-15 15:08:17 +05:00
parent 65d70aff29
commit 9e75545804
1 changed files with 41 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
special/SpecialAbuseLog.php
View file

@ -454,8 +454,9 @@ class SpecialAbuseLog extends SpecialPage {
$title = Title::makeTitle( $row->afl_namespace, $row->afl_title );
$diffLink = false;
$isHidden = self::isHidden( $row );
if ( self::isHidden( $row ) && !$this->canSeeHidden() ) {
if ( !self::canSeeHidden() && $isHidden ) {
return '';
}
@ -481,8 +482,7 @@ class SpecialAbuseLog extends SpecialPage {
if ( !$row->afl_wiki ) {
// Local user
$userLink = Linker::userLink( $row->afl_user, $row->afl_user_text ) .
Linker::userToolLinks( $row->afl_user, $row->afl_user_text, true );
$userLink = self::getUserLinks( $row->afl_user, $row->afl_user_text );
} else {
$userLink = WikiMap::foreignUserLink( $row->afl_wiki, $row->afl_user_text );
$userLink .= ' (' . WikiMap::getWikiName( $row->afl_wiki ) . ')';
@ -525,7 +525,7 @@ class SpecialAbuseLog extends SpecialPage {
}
$examineTitle = SpecialPage::getTitleFor( 'AbuseFilter', 'examine/log/' . $row->afl_id );
$examineLink = Linker::link(
$examineLink = Linker::linkKnown(
$examineTitle,
$this->msg( 'abusefilter-changeslist-examine' )->parse(),
array()
@ -536,7 +536,7 @@ class SpecialAbuseLog extends SpecialPage {
$actionLinks[] = $diffLink;
if ( $user->isAllowed( 'abusefilter-hide-log' ) ) {
$hideLink = Linker::link(
$hideLink = Linker::linkKnown(
$this->getPageTitle(),
$this->msg( 'abusefilter-log-hidelink' )->text(),
array(),
@ -559,7 +559,7 @@ class SpecialAbuseLog extends SpecialPage {
$title = SpecialPage::getTitleFor( 'AbuseFilter', $row->afl_filter );
$linkText = $this->msg( 'abusefilter-log-detailedentry-local' )
->numParams( $row->afl_filter )->escaped();
$filterLink = Linker::link( $title, $linkText );
$filterLink = Linker::linkKnown( $title, $linkText );
}
$description = $this->msg( 'abusefilter-log-detailedentry-meta' )->rawParams(
$timestamp,
@ -588,11 +588,11 @@ class SpecialAbuseLog extends SpecialPage {
)->params( $row->afl_user_text )->parse();
}
if ( self::isHidden( $row ) === true ) {
if ( $isHidden === true ) {
$description .= ' ' .
$this->msg( 'abusefilter-log-hidden' )->parse();
$class = 'afl-hidden';
} elseif ( self::isHidden( $row ) === 'implicit' ) {
} elseif ( $isHidden === 'implicit' ) {
$description .= ' ' .
$this->msg( 'abusefilter-log-hidden-implicit' )->parse();
}
@ -604,6 +604,17 @@ class SpecialAbuseLog extends SpecialPage {
}
}
protected static function getUserLinks( $userId, $userName ) {
static $cache = array();
if ( !isset( $cache[$userName][$userId] ) ) {
$cache[$userName][$userId] = Linker::userLink( $userId, $userName ) .
Linker::userToolLinks( $userId, $userName, true );
}
return $cache[$userName][$userId];
}
/**
* @param $db DatabaseBase
* @return string
@ -693,6 +704,28 @@ class AbuseLogPager extends ReverseChronologicalPager {
return $info;
}
/**
* @param ResultWrapper $result
*/
protected function preprocessResults( $result ) {
if ( $this->getNumRows() === 0 ) {
return;
}
$lb = new LinkBatch();
$lb->setCaller( __METHOD__ );
foreach ( $result as $row ) {
// Only for local wiki results
if ( !$row->afl_wiki ) {
$lb->add( $row->afl_namespace, $row->afl_title );
$lb->add( NS_USER, $row->afl_user );
$lb->add( NS_USER_TALK, $row->afl_user_text );
}
}
$lb->execute();
$result->seek( 0 );
}
function getIndexField() {
return 'afl_timestamp';
}