wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-27 15:30:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Hard-deprecate requesting disabled variables"

Browse source
This commit is contained in:
jenkins-bot 2019-09-28 18:25:24 +00:00 committed by Gerrit Code Review
parent 0e30c1c34e 0ae24d5489
commit 952dfa0bb4
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/AbuseFilterVariableHolder.php
View file

@ -115,9 +115,14 @@ class AbuseFilterVariableHolder {
// a new name. Translate it back.
$varName = array_search( $varName, AbuseFilter::getDeprecatedVariables() );
}
if ( array_key_exists( $varName, AbuseFilter::$disabledVars ) ) {
if ( array_key_exists( $varName, AbuseFilter::$disabledVars ) && $tempFilter ) {
$this->logger->warning(
"Disabled variable $varName requested. Please fix the filter as this will be removed soon."
"DEPRECATED! Using disabled variables is deprecated as of 1.34 and won't be supported " .
"in 1.35. Found use of {var_name} at filter {filter}. Please fix the affected filter.",
[
'var_name' => $varName,
'filter' => $tempFilter
]
);
}