From 9144dbf4a1ff361d56839410c7751b335057d926 Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Wed, 19 Sep 2018 19:58:30 +0200 Subject: [PATCH] Remove unused parameter Nothing uses it, plus it wouldn't work anyway: AbuseFilterParser constructor only uses $vars if it's instanceof AbuseFilterVariableHolder. Change-Id: Idbf53f6058148e9f0e73beb949e1c028a81663ce --- includes/AbuseFilter.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/AbuseFilter.php b/includes/AbuseFilter.php index ceef79452..fcd64e7a5 100644 --- a/includes/AbuseFilter.php +++ b/includes/AbuseFilter.php @@ -483,10 +483,9 @@ class AbuseFilter { /** * @param string $expr - * @param array $vars * @return string */ - public static function evaluateExpression( $expr, $vars = [] ) { + public static function evaluateExpression( $expr ) { global $wgAbuseFilterParserClass; if ( self::checkSyntax( $expr ) !== true ) { @@ -494,7 +493,7 @@ class AbuseFilter { } /** @var $parser AbuseFilterParser */ - $parser = new $wgAbuseFilterParserClass( $vars ); + $parser = new $wgAbuseFilterParserClass; return $parser->evaluateExpression( $expr ); }