wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-12-18 00:20:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for tinyint(1)'s not accepting ''

Browse source 
These boolean values go through DatabaseBase::makeList,
which passes them along to DatabaseBase::addQuotes, which
shoves the value through DatabaseMysqlBase::strencode,
which in turn passes it on to DatabaseMysqli::mysqlRealEscapeString,
which eventually calls mysqli::real_escape_string on it.

This last one will turn trues into '1' and falses into ''.
MySQL (or at least my version, 5.6.17 Homebrew) complains about
receiving incorrect integer value '' for these tinyint(1) columns.

Bug: T67807
Change-Id: Iaef98c08589370f9288c1f3c80803b1a16b2506e
This commit is contained in:
Matthias Mullie 2014-05-27 15:29:27 +02:00 committed by Nikerabbit
parent ff18e8a06c
commit 8a9fccbcc8
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Views/AbuseFilterViewEdit.php
View file

@ -151,6 +151,14 @@ class AbuseFilterViewEdit extends AbuseFilterView {
$newRow['af_throttled'] = $newRow['af_throttled'] && !$newRow['af_enabled'];
$newRow['af_id'] = $new_id; // ID.
// T67807
// integer 1's & 0's might be better understood than booleans
$newRow['af_enabled'] = (int) $newRow['af_enabled'];
$newRow['af_hidden'] = (int) $newRow['af_hidden'];
$newRow['af_throttled'] = (int) $newRow['af_throttled'];
$newRow['af_deleted'] = (int) $newRow['af_deleted'];
$newRow['af_global'] = (int) $newRow['af_global'];
$dbw->replace( 'abuse_filter', array( 'af_id' ), $newRow, __METHOD__ );
if ( $is_new ) {