wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-27 15:30:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Add _age variables to tests"

Browse source
This commit is contained in:
jenkins-bot 2018-08-23 14:35:33 +00:00 committed by Gerrit Code Review
parent 97f98b029d 90260edad0
commit 826e600731
1 changed files with 48 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
tests/phpunit/AbuseFilterTest.php
View file

@ -220,7 +220,7 @@ class AbuseFilterTest extends MediaWikiTestCase {
/**
* Check that user_age is correct. Needs a separate function to take into account the
* difference between this timestamp and the one in the actual code.
* difference between timestamps due to test execution time
*
* @covers AbuseFilter::generateUserVars
*/
@ -235,7 +235,7 @@ class AbuseFilterTest extends MediaWikiTestCase {
// 10 seconds should be a good confidence interval
10,
$difference,
"AbuseFilter variable user_age is computed wrongly."
"AbuseFilter variable user_age is computed wrongly. Expected: $computed, actual: $actual."
);
}
@ -249,9 +249,10 @@ class AbuseFilterTest extends MediaWikiTestCase {
* the result may be null if the requested variable doesn't exist, or false if there
* has been some other problem.
*/
private static function computeExpectedTitleVariable( $suffix, $options ) {
private static function computeExpectedTitleVariable( $suffix, $options = null ) {
self::$mTitle = Title::newFromText( 'AbuseFilter test' );
$page = WikiPage::factory( self::$mTitle );
$createdAt = microtime( true );
if ( $options === 'restricted' ) {
$action = str_replace( '_restrictions_', '', $suffix );
$namespace = 0;
@ -382,6 +383,9 @@ class AbuseFilterTest extends MediaWikiTestCase {
}
$result = self::$mUser->getName();
break;
case '_age':
$result = microtime( true ) - $createdAt;
break;
default:
$success = false;
$result = null;
@ -471,6 +475,47 @@ class AbuseFilterTest extends MediaWikiTestCase {
];
}
/**
* Check that _age variables are correct. They need a separate function to take into
* account the difference between timestamps due to test execution time
*
* @param string $prefix Prefix of the variable to test
* @covers AbuseFilter::generateTitleVars
* @dataProvider provideAgeVars
*/
public function testAgeVars( $prefix ) {
$varName = $prefix . '_age';
list( $computed, $successfully ) = self::computeExpectedTitleVariable( '_age' );
if ( !$successfully ) {
if ( $computed === null ) {
$this->fail( "Given unknown title-related variable $varName." );
} else {
$this->fail( "AbuseFilter variable $varName is computed wrongly." );
}
}
$variableHolder = AbuseFilter::generateTitleVars( self::$mTitle, $prefix );
$actual = $variableHolder->getVar( $varName )->toNative();
$this->assertLessThanOrEqual(
// 10 seconds should be a good confidence interval
10,
abs( $actual - $computed ),
"AbuseFilter variable $varName is computed wrongly. Expected: $computed, actual: $actual."
);
}
/**
* Data provider for testAgeVars
* @return array
*/
public function provideAgeVars() {
return [
[ 'page' ],
[ 'moved_from' ],
[ 'moved_to' ],
];
}
/**
* Check that our tag validation is working properly. Note that we only need one test
* for each called function. Consistency within ChangeTags functions should be